[Bug 545] Review request: nuvexport - Export MythTV .nuv and .mpeg files to other formats

http://bugzilla.rpmfusion.org/show_bug.cgi?id=545 Till Maas <opensource(a)till.name&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource(a)till.name --- Comment #4 from Till Maas <opensource(a)till.name&gt; 2009-04-13 23:30:10 --- The Makefile installs the modules with executable permissions: 75 .···# Install the modules 76 .···@for i in ${MODULES} ; do \ 77 .··· ${INSTALL} -Dv ${OWNER} -m 0755 $$i ${MODDIR}/$$i; \ 78 .···done -m 0755 should be -m 0644 to remove the executable bits. This would be easy to spot in the build.log, if there was not "@" in front of the for. ;-) Therefore a patch to the Makefile is a nicer solution, than to remove the executable bits afterwards. This also applies for the config files. Btw. you should also add INSTALL="install -p" to the %makeinstall command to preserve the timestamps of the files. Also I would patch the Makefile to support DESTDIR, i.e. change the install lines to ${INSTALL} -Dv ${OWNER} -m 0755 $$i $(DESTDIR)${MODDIR}/$$i and similiar. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.