9:05 a.m.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3539
MartinKG <mgansser(a)alice.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|3 |4
--- Comment #10 from MartinKG <mgansser(a)alice.de> 2015-02-16 10:05:05 CET ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
Note: Cannot find GNU-LICENSE in rpm(s)
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or
later)",
"BSD (2 clause) GPL (v2 or later)", "Unknown or generated". 2
files have
unknown license. Detailed output of licensecheck in
/home/martin/rpmbuild/SPECS/review-kwave/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in kwave
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in kwave
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
Note: Test run failed
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Test run failed
[x]: Packages must not store files under /srv, /opt or /usr/local
Note: Test run failed
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kwave-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[-]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Note: Test run failed
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: kwave-0.8.99-7.fc22.x86_64.rpm
kwave-doc-0.8.99-7.fc22.noarch.rpm
kwave-0.8.99-7.fc22.src.rpm
kwave.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_viewmag.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_viewmagfit.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_loop.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_pause_2.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_record.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_stop.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_fwd.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_pause.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_start.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_end.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_zoom_in.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/apps/kwave.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_rew.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_zoom_original.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_zoom_out.svgz
kwave.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/actions/kwave_player_play.svgz
kwave.x86_64: W: no-manual-page-for-binary kwave
kwave-doc.noarch: W: spelling-error %description -l de architekturunabhängige
-> Dialektunabhängigkeit
kwave.src: W: spelling-error %description -l en_US multi -> mulch, mufti
3 packages and 0 specfiles checked; 0 errors, 20 warnings.
Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:
Requires
--------
kwave-doc (rpmlib, GLIBC filtered):
kde-filesystem
kwave (rpmlib, GLIBC filtered):
/bin/sh
kwave-doc
libFLAC++.so.6()(64bit)
libFLAC.so.8()(64bit)
libQtCore.so.4()(64bit)
libQtDBus.so.4()(64bit)
libQtGui.so.4()(64bit)
libQtNetwork.so.4()(64bit)
libQtSvg.so.4()(64bit)
libQtXml.so.4()(64bit)
libasound.so.2()(64bit)
libasound.so.2(ALSA_0.9)(64bit)
libasound.so.2(ALSA_0.9.0rc4)(64bit)
libaudiofile.so.1()(64bit)
libc.so.6()(64bit)
libfftw3.so.3()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_4.0.0)(64bit)
libid3-3.8.so.3()(64bit)
libkdecore.so.5()(64bit)
libkdeui.so.5()(64bit)
libkfile.so.4()(64bit)
libkio.so.5()(64bit)
libkwave.so.0()(64bit)
libkwavegui.so.0()(64bit)
libm.so.6()(64bit)
libmad.so.0()(64bit)
libogg.so.0()(64bit)
libopus.so.0()(64bit)
libpthread.so.0()(64bit)
libpulse.so.0()(64bit)
libpulse.so.0(PULSE_0)(64bit)
libsamplerate.so.0()(64bit)
libsamplerate.so.0(libsamplerate.so.0.0)(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libvorbis.so.0()(64bit)
libvorbisenc.so.2()(64bit)
libz.so.1()(64bit)
rtld(GNU_HASH)
Provides
--------
kwave-doc:
kwave-doc
kwave:
appdata()
appdata(kwave.appdata.xml)
application()
application(kde4/kwave.desktop)
kwave
kwave(x86-64)
libkwave.so.0()(64bit)
libkwavegui.so.0()(64bit)
mimehandler(application/ogg)
mimehandler(application/x-flac)
mimehandler(application/x-ogg)
mimehandler(audio/basic)
mimehandler(audio/mpeg)
mimehandler(audio/ogg)
mimehandler(audio/opus)
mimehandler(audio/wav)
mimehandler(audio/x-aifc)
mimehandler(audio/x-aiff)
mimehandler(audio/x-flac)
mimehandler(audio/x-ircam)
mimehandler(audio/x-mp1)
mimehandler(audio/x-mp2)
mimehandler(audio/x-mp3)
mimehandler(audio/x-ogg)
mimehandler(audio/x-vorbis+ogg)
mimehandler(audio/x-wav)
Source checksums
----------------
http://downloads.sourceforge.net/kwave/kwave-0.8.99-2.tar.bz2 :
CHECKSUM(SHA256) this package :
94ad5d5d526714c5c496cf2f83d4e1aa34081997f574b465cd1972e5cba377f2
CHECKSUM(SHA256) upstream package :
94ad5d5d526714c5c496cf2f83d4e1aa34081997f574b465cd1972e5cba377f2
Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64-rpmfusion_free -u
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3539
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
OK, looks good.
Package APPROVED !
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.