[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216
--- Comment #10 from Jeremy Newton <alexjnewt(a)hotmail.com> 2012-04-06 20:51:24 CEST
---
(In reply to comment #9)
Sorry for the delay.
(In reply to comment #3)
> A bunch of notes, I can do a full review later:
> [...]
Great help, thanks. I followed almost all of these, and your SRPM was of great
No problem, always up to help :)
> -You missing %post, %postun and %posttrans sections, which are
required for
> desktop files with icons: (you can also see my SPRM below)
> https://fedoraproject.org/wiki/Packaging/Guidelines#Icon_tag_in_Desktop_F...
Well, in https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
says that is to do when 'an application installs icons into one of the
subdirectories in %{_datadir}/icons/', but that's not the case anymore. Seeing
your SRPM example, I wrote the icon into %_datadir/pixmaps/, so the previous
condition is not fulfilled anymore. For that reason, I did not add those
scriptlets. Correct me if I'm wrong, please.
I believe pixmaps is also a part of the icon cache, thus it still needs to be
updated, though I am not completely sure on this. I'll let you know when I
figure that out. I guess I just always assumed it should be there without
checking.
> By the way, kudos for the idea of getting the logo from the love
file, it never
> occurred to me to do that.
Thanks. If you are thinking about packaging mari0, just mention that you can do
that there too. If not, I can package it.
I have mari0 packaged, I just need to upload it. I got love accepted into
Fedora, so I just want to run a quick test before I upload it.
> -Man pages are not vital for getting your package accepted, but
it is suggested
> to look into making one.
I have not a clue about how to do this. I think this should be upstream work,
though.
It's very simple, you can make one in a few minutes. Take a look at my love
package for an example:
http://kojipkgs.fedoraproject.org/packages/love/0.8.0/2.fc18/src/love-0.8...
Just open the love.1 with a text editor and the rest is easy.
You can either make one or ask upstream to make one, which I highly doubt they
will. If you do make one, you can send it upstream and they may include it in
the linux version though.
I would like to strongly note that you are not required to make a man page,
though it's just highly suggested.
> -To my knowledge %defattr(-, root, root) shouldn't be
required, but to be
> honest I've never used it before.
I never really understood that. I used to put it because I saw it in a lot of
places. Anyway I removed that.
I believe that is for compatibility with RedHat EL 5, and unless you plan to
package for EPEL 5, it's pointless. As well I'm only currently maintaining love
for Fedora 15, 16, 17, devel/rawhide
On another note, the version of love I submitted for fedora, which is still in
updates testing, is version 0.8.0. Though they have not advertised it on their
website yet, love 0.8.0 has been tagged in their SCM (bitbucket). I'm not sure
what this is all about.
Anyway, Not tetris at the moment does not work on 0.8.0, and I contacted
upstream about this. They said until love 0.8.0 is "official released" they
don't plan to update Not Tetris.
Naturally this issue puts this review on hold unless you would like to take a
crack at making a patch yourself or would like to contact upstream for one.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.