4:26 a.m.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=310
--- Comment #17 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-06-15 06:26:58 ---
Thanks for the update. Here is the rest of the package review:
* Please remove the Authors section from %description. It is not our custom to
put this information in %description.
* %package -n %{name}-sounds
%description -n %{name}-sounds
%files -n %{name}-sounds
can be simplified to
%package sounds
%description sounds
%files sounds
Similarly for other subpackages.
* The .desktop file carries the Mimetype key. We need to use the scriptlets
from
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database
? Why are
%dir %{_datadir}/%{name}/books
%dir %{_datadir}/%{name}/bases
owned by the main package but not by their respective subpackages? (In
contrast, the
%{_datadir}/%{name}/sounds/
directory is owned by the subpackage.)
* The commented out section (lines 124-138) can be removed. Beware though, when
you want to use macros in comments and in the changelog, you need to escape
them with an extra %
! The line
%doc %{_datadir}/doc/%{name}-%{version}
can be replaced by
%{_docdir}/%{name}-%{version}/
Note that you don't need to put an extra %doc when you use %{_docdir}
! Also, I recommend indicating directories in %files sections with a trailing /
For instance
%{_datadir}/%{name}/data/
? What is this line for:
iconv -f cp1251 -t utf8 tcl/lang/russian.tcl -o tcl/lang/russian.tcl.utf8 &&
mv -f tcl/lang/russian.tcl.utf8 tcl/lang/russian.tcl
You didn't package this. Something missing?
* Fedora specific optflags are not used for all compilations. From the
build.log:
g++ -pipe -Wall -fno-exceptions -fno-rtti -O3 -fstrict-aliasing
-fomit-frame-pointer -c -o eval.o eval.cpp
gcc -O3 -Wall -fomit-frame-pointer --std=gnu89 -D_GNU_SOURCE -DGNUFUN -c
killers.c -o .o/killers.o
This needs attention. Do a
rpm -E %{optflags}
to see what flags need to be passed. Remember that these flags should not be
overriden.
* There are a few compilation warnings of type
src/egtb/tbindex.cpp:1204: warning: format '%d' expects type 'int',
but
argument 2 has type 'size_t'
Please fix them as they might cause problems in 64bit systems. (Replacing %d by
%zd should solve it) Don't forget to send the patch upstream and provide a link
from their tracker.
* Please explain in the SPEC file where
Source2: %{name}.png
Source3: %{name}.svg
come from. Also you could try to upstream them along with
Source1: %{name}.desktop
I just realized that you don't use Source2 anywhere. Did you miss something?
* It appears to me that the help/ directory is worth putting in %doc
* Also please include the doc files in src/egtb/ in %doc
? What is all that stuff it the pocket/ directory? Don't we want them?
! Please remove the directory
src/zlib
in %prep to make sure we are not using it.
* %global is preferred over %define according to the new guidelines.
* TCL packaging guidelines
http://fedoraproject.org/wiki/Packaging:Tcl
tell us that we must use
Requires: tcl(abi) = 8.5
to indicate which Tcl version they were built against.
? You define these
%{!?tcl_sitearch: %define tcl_sitearch %{_libdir}/tcl%{tcl_version}}
%{!?tcl_sitelib: %define tcl_sitelib %{_datadir}/tcl%{tcl_version}}
but you don't use them at all. I am a little confused here. TCL guidelines tell
us to use %{tcl_sitelib} as datadir, but you use SHAREDIR=%{_datadir}/%{name}
in the SPEC file. Is this what you are supposed to do? If yes, can't we remove
the above two lines from the SPEC file?
Now about the license:
* You say in comment #6 that scid/books/Performance.bin and
scid/books/varied.bin are freely redistributable. (they are otherwise non-free
because they are not modifiable, are they?)
We need to indicate this in the license tag by adding "freely redistributable".
* Nalimov's code is distributable only in Scid, so we need to add something
like "distributable only in Scid" to the license tag.
* The final license tag will then be something like
License: GPLv2+ and freely redistributable and distributable only in Scid
Also please explain briefly with comments next to the license tag what files
belong to each group.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.