[Bug 195] Review request: perl-Crypt-IDEA - Perl interface to IDEA block cipher
http://bugzilla.rpmfusion.org/show_bug.cgi?id=195
--- Comment #3 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-01-17 14:37:48 ---
(In reply to comment #2)
(In reply to comment #1)
> The package seems in shape. There are a suggestion (!), a few issues that need
> to be corrected (*) and a question (?)
> ! If you use a delimiter other than / on sed, it will make things easier to
> read.
Wrong. / is mandatory on sed "deletes".
Wrong. You can use other delimiters with sed "delete". These can
probably be
found in some basic bash scripting documentation which you should be familiar
with.
> * Please explain all non-trivial things you do in a SPEC file
(especially the
> sed and rm commands) as comments
These are common Fedora perl packaging standards, you should be familiar with.
There is nothing in the Perl guidelines [1] about removal of .bs and .packlist
files. Also no specific perl guideline about removing shebangs [1].
> * Please preserve the timestamps of non-compiled files.
Superfluous - It's an urban legend that this would fix anything.
It is a very common practice in Fedora and rpmfusion and is told by many
reviewers. You'd see this before if you weren't that picky for picking out
bugzilla threads to troll and took your time to do some actual review(s).
> * The file "changes" should go to %doc
Correct ... SHOULD.
That's what the guidelines say.
> ? Packages must not own files or directories already owned by
other packages.
> %{perl_vendorarch}/Crypt/ and %{perl_vendorarch}/auto/Crypt/ are owned by
> crypto-utils. But there is an exception rule for perl packages and I believe
> this package falls into that category. Am I right?
Almost. Your final conclusion is right (these dirs must be owned), but your
explanation is not quite right.
You might be correct but I don't think I am eager to hear your explanation.
I am kindly asking you to not write in the bugs that I write. I don't like your
attitude and I think that I can be more productive without your presence. While
I can't force you to do this, I can only re-iterate this request.
[1] http://fedoraproject.org/wiki/Packaging/Perl
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.