[Bug 2483] Review request: msttcore-fonts - TrueType core fonts for the web
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2483
--- Comment #6 from Rob Janes <janes.rob(a)gmail.com> 2012-09-16 15:10:14 CEST ---
(In reply to comment #5)
(In reply to comment #3)
>
> So, yes, this could very well go into the rpmfusion nonfree section, given some
> work to make it comply with fedora's packaging guidelines.
I'm not sure if "some" is the right word here. My view:
* post scripts that put somewhere that are not tracked by rpm are a no go
(maybe /opt/ or /usr/local/ might be an exception, but I'm not even sure about
that)
* a post script that long looks unacceptable to me, too
I'd say a better short term solution might be a rpm called
""msttcore-fonts-download-script" that contains a script the user has to
call
manually. That script then could do everything that is needed, as that makes it
way more obvious what's happening instead of abusing rpm (and it's pre and post
scripts) and kind of hiding what's really happening.
A proper long term solution might be extending akmods (or writing something
similar) that can download things, run a rpmbuild with a spec file that uses
those things and installs the resulting rpm afterwards.
All that of course: IMHO and YMMV
I had a look at debian's ttf-mscorefonts-installer. Specifically,
ttf-mscorefonts-installer_3.3ubuntu3_all.deb. It's in the multiverse pool, so
it seems to be part of standard ubuntu.
It does what this script does. It has huge pre and post scripts in the deb
that install the fonts when the deb is installed. Also, it installs the fonts
from the same sourceforge site.
Additionally, it puts out some microsoft EULA that has to be agreed to. I'm
not sure if that's necessary. It seems to defeat batch installs.
My intent in this was to write up a convenience rpm that could be easily
installed in one step.
The pre and post scripts of the deb are interesting. There are things done
that my scripts don't do. And, there are things my script does that the deb
does not do.
The integration with core X and Xft is not there. Maybe there's a level of
automation in ubuntu that fedora doesn't have, such that putting a new
directory and a font in that directory automatically causes updates of the
fontdir and cache and such.
However, the deb has more knowledge about the fonts and tracks what to
uninstall better.
So, I'd argue that a one stop installer rpm is an acceptable way to go. I'd
also argue that there is nothing intrinsically wrong with long scripts in the
spec file. The big script is in the preinstall section, so putting it into a
file installed by the rpm would be problematic. Possible, but that would mean
the grunt work is done in the postinstall section with a callout to this
script. My preference is not to do that external install and remove script.
In the deb package, the preinstall is all about the EULA, and it's the
postinstall that actually downloads the fonts. The preinstall is 75 lines
long, and the postinstall is 294 lines.
I like the name of the package. ttf-mscorefonts-installer.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.