[Bug 2161] Review request: pcsxr - A plugin based PlayStation (PSX) emulator with high compatibility

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2161 --- Comment #14 from Alec Leamas <leamas.alec(a)gmail.com&gt; 2012-01-31 11:40:30 CET --- The commments on how to retrieve the source: since the License tag (and related conflicts) only applies to the binary RPM:s, I think you should move the code cleanup to the %prep section. Something like %prep %setup -q chmod 755 plugins/dfinput/util.* rm -rf macosx win32 debian-upstream This way manual source generation becomes simpler, and when upstream releases a usable version which can be stated as a %source url it will "Just Work"(tm). The patch/not patch discussion: simple misunderstanding. You send report/patches upstream, and chooses to patch or not later. Agreed. We need the upstream reference before this is over. License breakdown: done in comments, which basically is fine. However, you miss some of the information in debian/copyright, notably the note on psemu_plugin_defs. Personally, I think I would have created a new file like LICENSES based on the debian stuff, but I guess either way is OK. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.