1:27 p.m.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2711
Hans de Goede <j.w.r.degoede(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|2 |3
--- Comment #2 from Hans de Goede <j.w.r.degoede(a)gmail.com> 2013-04-07 15:27:49 CEST
---
Good:
- rpmlint checks return:
assaultcube.src: W: invalid-license Expat
assaultcube.src: W: invalid-license Redistributable
assaultcube.src: W: strange-permission AssaultCube-startscript.sh 0755L
assaultcube.src: W: strange-permission AssaultCube-server.sh 0755L
assaultcube.x86_64: W: invalid-license Expat
assaultcube.x86_64: W: invalid-license Redistributable
These can be ignored
- package meets naming guidelines
- package meets packaging guidelines
- license (Expat + Redistributable) OK
- spec file legible, in am. english
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
Needs work:
assaultcube.src: W: invalid-url Source1:
http://transact.dl.sourceforge.net/sourceforge/actiongame/AssaultCube_v1....
<urlopen error [Errno -2] Name or service not known>
assaultcube.src: W: invalid-url Source0:
http://transact.dl.sourceforge.net/sourceforge/actiongame/AssaultCube_v1....
<urlopen error [Errno -2] Name or service not known>
assaultcube.x86_64: W: spurious-executable-perm
/usr/share/doc/assaultcube-1.1.0.4/docs/colouredtext.txt
assaultcube.x86_64: W: file-not-utf8
/usr/share/doc/assaultcube-1.1.0.4/docs/package_copyrights.txt
assaultcube.x86_64: E: non-standard-dir-perm
/usr/share/assaultcube/packages/maps 01757L
assaultcube.x86_64: W: file-not-in-%lang
/usr/share/assaultcube/packages/locale/de/LC_MESSAGES/AC.mo
assaultcube-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/1.1.0.4/source/enet/include/enet/unix.h
assaultcube-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/1.1.0.4/source/enet/host.c
assaultcube-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/1.1.0.4/source/enet/protocol.c
assaultcube-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/1.1.0.4/source/enet/include/enet/list.h
assaultcube-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/1.1.0.4/source/enet/unix.c
assaultcube-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/1.1.0.4/source/enet/packet.c
assaultcube-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/1.1.0.4/source/enet/list.c
assaultcube-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/1.1.0.4/source/enet/include/enet/protocol.h
assaultcube-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/1.1.0.4/source/enet/include/enet/enet.h
assaultcube-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/1.1.0.4/source/enet/include/enet/types.h
assaultcube-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/1.1.0.4/source/enet/peer.c
Please fix all these:
- do chmod -x on the source files in %prep
- See: http://pkgs.fedoraproject.org/cgit/usbview.git/tree/usbview.spec for
an example howto fix
the utf8 warning
- Use find_lang for the translations (or mark them manually if there are only
a few)
- chmod the spurious dir in %prep to something reasonable
- desktop files not properly installed. The desktop files should be "generated"
in the build dir
and then installed with desktop-file-install, related to this the desktop files
should not contain the Version field, this gets set by desktop-file-install
- RPM_OPT_FLAGS is not honored. .c files are compiled without any flags, .cpp
files are compiled with "-O3 -fomit-frame-pointer", both are wrong. Be sure to
keep the -fsigned-char. This may be due to the use of %optflags, which should
be %rpmoptflags or $RPM_OPT_FLAGS under Fedora
-drop the %make_install, it does not do anything other then copying the
binaries from source/src/ac_client to bin_unix/native_client and
source/src/ac_server to bin_unix/native_server, instead just install the
binaries directly from source/src/ac_*
-instead of "cd source/src .... cd ../.." use "pushd source/src ....
popd"
-Source urls are wrong, see:
http://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net
-The data files license as described here:
http://packages.debian.org/changelogs/pool/non-free/a/assaultcube-data/as...
Seems to be missing from %doc
-Drop the bogus software downscaled images, desktop environments can do scaling
of icons just fine, multiple size icons are useful when they are hand-drawn,
software scaled versions are useless. You can then also drop the ImgaeMagick
BuildRequires.
Not checked due to needs work items:
- source matches upstream
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.