https://bugzilla.rpmfusion.org/show_bug.cgi?id=2531
--- Comment #2 from Antonio <anto.trande(a)gmail.com> 2012-10-16 11:56:40 CEST ---
(In reply to comment #1)
Hello,
Just a few comments:
- You don't need to add the first line (# This file is made...). The identity
of the packager is evident from the changelog entry;
- It would be nice if you add one package per line in Requires/BuildRequires;
- You can remove BuidRoot and Groups tags [1]
- Replace %{_make} and %{_rm} with make and rm [2]. Do not use macros for
simple things. You never know if/how they are defined;
- You should own the directory %{_datadir}/%{name} [3];
[1] -
http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[2] -
http://fedoraproject.org/wiki/Packaging:Guidelines#Macros
[3] -
http://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Own...
Hi eldermarco.
http://sagitter.fedorapeople.org/moc.spec
http://sagitter.fedorapeople.org/moc-2.5.0-0.1.beta1.fc17.src.rpm
$ rpmlint moc-2.5.0-0.1.beta1.fc17.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint moc-2.5.0-0.1.beta1.fc17.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Thank you.
--
Configure bugmail:
https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.