[Bug 4363] Review request: chromium-libs-media-freeworld - Chromium media libraries built with all possible codecs
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4363
--- Comment #49 from Miro Hrončok <mhroncok(a)redhat.com> ---
(In reply to Miro Hrončok from comment #48)
(In reply to Nicolas Chauvet from comment #47)
> (In reply to Miro Hrončok from comment #46)
> > The builds are failing:
> >
> > http://koji.rpmfusion.org/koji/taskinfo?taskID=151088
> > http://koji.rpmfusion.org/koji/taskinfo?taskID=151158
> > http://koji.rpmfusion.org/koji/taskinfo?taskID=151369
> Missing -lavcodec or else somewhere.
Will look.
Not sure if
obj/third_party/ffmpeg/ffmpeg_internal/aacsbr.o:(.rodata.ff_sbr_noise_table+0x0):
multiple definition of `ff_sbr_noise_table'
obj/third_party/ffmpeg/ffmpeg_internal/autorename_libavcodec_sbrdsp.o:(.rodata.ff_sbr_noise_table+0x0):
first defined here
can be done by missing -l flag.
> > Nevertheless there's one more thing: Even if the
freeworld value is flipped
> > to 1, the Name of the (source) package remains chromium, which might be
> > problematic. Would you accept a change that would do:
> >
> >
> > %if %{freeworld}
> > Name: chromium%{chromium_channel}-libs-media-freeworld
> > %else
> > Name: chromium%{chromium_channel}
> > %endif
> I would simplify with chromium%{chromium_channel}%{?freeworld:-%{freeworld}}
That would do, I guess.
Actually chromium%{chromium_channel}%{?freeworld:-freeworld}
--
You are receiving this mail because:
You are on the CC list for the bug.
Attachments:
- attachment.html (text/html — 2.8 KB)