[Bug 1786] Review request: wbar - wbar is a quick launch bar.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1786 Richard <hobbes1069(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hobbes1069(a)gmail.com --- Comment #4 from Richard <hobbes1069(a)gmail.com&gt; 2011-06-04 18:16:38 --- I can't accept review responsibilty at this time. Too many irons in the fire. But I'll suggest some fixes. All 3 macros at the top of your spec file are unnecessary. Both %{name} and %{version} will get assigned automatically from the Name: and Version: fields. Since %{release} is not used anywhere else but the Release: field it's not needed either. BuildRoot: and %clean are not needed at all if you're not going to build for EPEL. Remove the unneeded newline after %description. Under %setup I don't think you need the -n option. It should look in %{name}-%{version} by default. Under %install just use "make" you don't need to use the macro for it. As I understand it the macros are for situation where you need to override the default behavior. That's all I can see in a very quick review. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.