[Bug 3576] Review request: obs-studio - Open Broadcaster Software Studio
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3576
MartinKG <mgansser(a)alice.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mgansser(a)alice.de
--- Comment #1 from MartinKG <mgansser(a)alice.de> 2015-03-29 18:42:57 CEST ---
This is not a full review, bu a view things that should be changed.
1. Please use macro %cmake it already sets CMAKE_INSTALL_PREFIX.
Look at "rpm -E %cmake" to see what I mean. It would be odd if had to add these
to get the proper behavior.
2. for better readability you should write a new line for each BR.
BuildRequires: gcc-objc
BuildRequires: cmake
BuildRequires: libX11-devel
....
3. belongs to a devel-package:
obs-studio.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libobsglad.so
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.
obs-studio.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libobs.so
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.
obs-studio.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/libobs-opengl.so
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.
obs-studio.x86_64: E: incorrect-fsf-address /usr/share/doc/obs-studio/COPYING
The Free Software Foundation address in this file seems to be outdated or
misspelled. Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.
4. The incorrect FSF address needs to be reported upstream, don't change the
license text.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.