[Bug 1355] Review request: minitube - A YouTube desktop client

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1355 --- Comment #44 from Kalev Lember <kalev(a)smartlink.ee&gt; 2010-08-11 12:57:29 --- (In reply to comment #43) That patch looks nice, props to Leigh. Magnus, can you submit the patch upstream so that it'll be included in the next release? I think the reasoning that it's needed for rpm's find_lang to work is good enough. Some issues with the package: Mustfix: - /usr/share/minitube/ and /usr/share/minitube/locale/ directories are unowned. Nice to have: - can you sort the list of files with license info at the top of the spec file? It's a bit hard to read the way it is now. - file names like lang.patch and QString.patch have a good chance of clashing with files from other source packages (not in the official build system, but when people "rpm -i" the source rpms in their own computer). Can you prefix them with minitube- like minitube-lang.patch, minitube-QString.patch? - it might be safer to BR qt4-devel instead of qt-devel, but see below: $ repoquery --whatprovides qt-devel qt-devel-1:4.6.3-8.fc13.i686 qt-devel-1:4.6.3-8.fc13.x86_64 qt-devel-1:4.6.2-16.fc13.i686 qt3-devel-0:3.3.8b-29.fc13.x86_64 qt3-devel-0:3.3.8b-29.fc13.i686 qt-devel-1:4.6.2-16.fc13.x86_64 qt-devel-1:4.6.3-8.fc13.i686 qt-devel-1:4.6.3-8.fc13.x86_64 Kevin: Why do the qt3-devel packages Provide qt-devel? Is it really needed? Looks like a good way to shoot yourself in the foot. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.