[Bug 2216] Review request: Not Tetris 2 - Classic Tetris mixed with physics

(In reply to comment #9)

> > -You missing %post, %postun and %posttrans sections, which are required for > > desktop files with icons: (you can also see my SPRM below) > > https://fedoraproject.org/wiki/Packaging/Guidelines#Icon_tag_in_Desktop_F... > > Well, in https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache > says that is to do when 'an application installs icons into one of the > subdirectories in %{_datadir}/icons/', but that's not the case anymore. Seeing > your SRPM example, I wrote the icon into %_datadir/pixmaps/, so the previous > condition is not fulfilled anymore. For that reason, I did not add those > scriptlets. Correct me if I'm wrong, please. I believe pixmaps is also a part of the icon cache, thus it still needs to be updated, though I am not completely sure on this. I'll let you know when I figure that out. I guess I just always assumed it should be there without checking.

> > -To my knowledge %defattr(-, root, root) shouldn't be required, but to be > > honest I've never used it before. > > I never really understood that. I used to put it because I saw it in a lot of > places. Anyway I removed that. I believe that is for compatibility with RedHat EL 5, and unless you plan to package for EPEL 5, it's pointless. As well I'm only currently maintaining love for Fedora 15, 16, 17, devel/rawhide