[Bug 4363] Review request: chromium-libs-media-freeworld - Chromium media libraries built with all possible codecs
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4363
--- Comment #39 from Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net>
---
(In reply to Nicolas Chauvet from comment #38)
(In reply to Dominik 'Rathann' Mierzejewski from comment
#35)
> Created attachment 1812 [details]
> patch to ship libmedia.so, libffmpeg.so and libwidevinecdm.so with
> alternatives support
>
> Would something like this patch be acceptable? koji scratch build in
> progress here: https://koji.fedoraproject.org/koji/taskinfo?taskID=20263514 .
This looks to be in the right way. Thx for handling this.
Few comments,
- You are probably missing to remove the Obsoletes/Replace
Probably. ;)
- If libwidevinecdm.so doesn't need to be replaced by a freeworld
version,
maybe you can avoid to rename it ?
True, but this allows replacing it by users without affecting the packaged
files.
I have a locally built widevine RPM that uses alternatives, but obviously isn't
redistributable.
- Using 0%{?freeworld} seems more robust than %{freeworld} in case
the
define is unset (it should be set to 0 by default, but it cannot be unset).
Ok.
--
You are receiving this mail because:
You are on the CC list for the bug.
Attachments:
- attachment.html (text/html — 2.7 KB)