[Bug 4215] Review Request: mlt - freeworld
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4215
--- Comment #2 from Sérgio Basto <sergio(a)serjux.com> 2016-08-28 21:28:00 CEST ---
(In reply to comment #1)
Quick spec review first.
- Summary tag on top? ;)
fixed
- BSD File
# mlt/src/win32/fnmatch.{c,h} are BSD-licensed.
Does fnmatch end up in the linux version since it's in the win32 folder? If not
then you don't need to consider it for licensing purposes.
This are the licenses of source code , should I change here ? or in Fedora
proper ? , but see that we don't remove win32 , from source , don't know what
should do.
- Could use %make_install in %install (not the same as the
depreciated
%makeinsall)
fixed use %make_install and %make_build
I re-uploaded the source of the links .
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.