[Bug 2763] Review request: warsow-data - Game data for Warsow

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2763 Hans de Goede <j.w.r.degoede(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |j.w.r.degoede(a)gmail.com Blocks|2 |4 AssignedTo|rpmfusion-package-review@rp |j.w.r.degoede(a)gmail.com |mfusion.org | --- Comment #1 from Hans de Goede <j.w.r.degoede(a)gmail.com&gt; 2013-05-05 21:21:14 CEST --- Full review done: Good: - rpmlint checks return: warsow-data.src: W: invalid-license Warsow Content License warsow-data.noarch: W: invalid-license Warsow Content License warsow-data.noarch: E: arch-independent-package-contains-binary-or-object /usr/share/warsow/basewsw/modules_10.pk3 warsow-data.noarch: E: arch-independent-package-contains-binary-or-object /usr/share/warsow/basewsw/modules_101.pk3 warsow-data.noarch: E: arch-independent-package-contains-binary-or-object /usr/share/warsow/basewsw/modules_102.pk3 -These can all be ignored - package meets naming guidelines - package meets packaging guidelines - license (Warsow Content License) OK for non-free, text in %doc, matches source - spec file legible, in am. english - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Should fix: -rpmlint: warsow-data.noarch: W: file-not-utf8 /usr/share/doc/warsow-data-1.02/mousefilter.txt warsow-data.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/warsow-data-1.02/changelog.txt warsow-data.noarch: W: file-not-utf8 /usr/share/doc/warsow-data-1.02/old_changelog.txt warsow-data.noarch: W: file-not-utf8 /usr/share/doc/warsow-data-1.02/license.txt -See warsow review for some suggestions how to fix these No blockers: approved. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.