[Bug 585] Review Request: z-push - ActiveSync over-the-air implementation for mobile syncing

http://bugzilla.rpmfusion.org/show_bug.cgi?id=585 --- Comment #28 from Thorsten Leemhuis <fedora(a)leemhuis.info&gt; 2011-06-04 06:34:30 --- = Heads up for @rpmfusion-developers-list = This package afaics aims the free repo these days; it's "AGPLv3 with exceptions". Here is the exception (copy'n'pasted from index.php): * According to sec. 7 of the GNU Affero General Public License, version 3, * the terms of the AGPL are supplemented with the following terms: * * "Zarafa" is a registered trademark of Zarafa B.V. * "Z-Push" is a registered trademark of Zarafa Deutschland GmbH * The licensing of the Program under the AGPL does not imply a trademark license. * Therefore any rights, title and interest in our trademarks remain entirely with us. * * However, if you propagate an unmodified version of the Program you are * allowed to use the term "Z-Push" to indicate that you distribute the Program. * Furthermore you may use our trademarks where it is necessary to indicate * the intended purpose of a product or service provided you use it in accordance * with honest practices in industrial or commercial matters. * If you want to propagate modified versions of the Program under the name "Z-Push", * you may only do so if you have a written permission by Zarafa Deutschland GmbH * (to acquire a permission please contact Zarafa at trademark(a)zarafa.com). The file permission.pdf contains a written permission, that allows us to call our package z-push. So IOW and roughly speaking: the situation is similar to Firefox in Fedora, but not as strictly handled afaics. That's fine for me, but other RPM Fusion developers should have a chance to raise concerns. Hence I'll wait until at least Tuesday next week before I approve this package; of course we can always rename the package later or move it to the nonfree repo if we want to. = Review = Ony a few minor things: * I for one find the spec file line License: AGPLv3 with exceptions confusing, as the "with exceptions" is not explained anywhere in an obvious place. I'd say a clarifying comment or section in the README.FEDORA.package would be a good idea. Normally I'd say you should bug upstream to add it to LICENSE or create a file LICENSE.exception instead of adding it to files like index.php only, as people might not see it there and think it's a regular AGPLv3 * BTW, I'd give files like README.FEDORA.package a prefix with %{name} in the SRPM, as otherwise bad things bappen when people install multiple SRPMs that contain files with that name * rpmlint gives a warning on the SRPM: z-push.src:11: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 3) * should zarafa-z-push have a dep on zarafa or something else that owns /etc/zarafa/? Comment on those and I'll approve it nobody complains about the naming. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.