[Bug 308] Review request: ultrastardx - Karaoke game inspired by a popular commercial karaoke game

http://bugzilla.rpmfusion.org/show_bug.cgi?id=308 Orcan Ogetbil <oget.fedora(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oget.fedora(a)gmail.com Blocks|2 |3 Status|NEW |ASSIGNED --- Comment #2 from Orcan Ogetbil <oget.fedora(a)gmail.com&gt; 2009-01-12 18:17:04 --- The package needs some work. Here's the initial review: * Package does not build in mock. Must add BR: libpng-devel desktop-file-utils * It would be better to supply a fetch script (see e.g. ffmpeg) to gather and pack the svn sources. You should remove the .svn directories from the source tarball. * The source contains fonts in the game/fonts directory. They must be removed and symlinks to internal Fedora fonts should be provided. Don't forget to add the relevant Requires. * There are a vast amount of precompiled binary files in the tarball. They need to be removed during %prep (or it would be even better if they are removed in the fetch script). e.g. .res .dll files. There may be more, just run and look at the output of find . -exec file {} \; * The application has support for various additional libraries. See src/lib directory, also http://ultrastardeluxe.xtremeweb-hosting.net/wiki/doku.php?id=development... . For instance we have libprojectM in Fedora. You can most likely add some flags to the configure command to make these compile. The general policy is to enable as much as possible. * The package must own the directory: %{_datadir}/%{name} * The package must not own the directory %{_datadir}/icons/hicolor/ Just use %{_datadir}/icons/hicolor/*/*/* in the %files section. * Please make use of the %{name} macro. * Please yield the guidelines for icon cache: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache * the --vendor field should be blank for new desktop applications. Also please remove the Category "Application" and add a GenericName in the .desktop file. You can also add some audio related category(ies) to the .desktop file. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.