[Bug 3694] Review request: flowblade - A fast, efficient video editor
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3694
--- Comment #4 from MartinKG <mgansser(a)alice.de> 2015-06-21 01:14:38 CEST ---
(In reply to comment #2)
2 big issues
1- python setup.py install --root=%{buildroot}
--install-lib=/usr/share/pyshared --optimize=1
should be something simple like this:
%install
python setup.py install --root %{buildroot}
%files
%{python_sitearch}/Flowblade/
%{python_sitearch}/flowblade*
done
2- flowblade.src:100: E: hardcoded-library-path in
/usr/lib/mime/packages/flowblade
/usr/lib/mime/packages/flowblade ? what is this ?
Scriptlets for Desktop files and mimeinfo are correct but
/usr/lib/mime/packages/flowblade maybe should be in /usr/libexec/
3- Please could you comment explain what this do ?
find . -type f -print0 | xargs -0 -n 250 chmod a-x
find . -type f | xargs grep -El '\#!/usr/bin/env|\#!BPY' | xargs chmod a+x
only copied from the existing rpm spec file, don't know what makes it exactly.
and
find %{buildroot}/%{_datadir}/pyshared/Flowblade/locale -name "*.mo" | sed
's:'%{buildroot}'::
s:.*/\([a-zA-Z]\{2\}\).qm:%lang(\1) \0:' > %{name}.lang ?
because macro "%find_lang %{name}" did not work
NEW rpms
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/flowblade.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/flowblade-1.0.0-2.git94f69...
%changelog
* Sat Jun 20 2015 Martin Gansser <martinkg(a)fedoraproject.org> -
1.0.0-2.git94f69ce
- used macro %%{python_sitearch}
- spec file cleanup
- mime file belong to %%{_libexecdir}
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.