[Bug 2140] bombono-dvd - DVD authoring program with nice and clean GUI
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2140
--- Comment #48 from Alec Leamas <leamas.alec(a)gmail.com> 2012-04-01 11:37:39 CEST
---
Links updated.
http://dl.dropbox.com/u/17870887/bombono-dvd/bombono-dvd.spec
http://dl.dropbox.com/u/17870887/bombono-dvd/bombono-dvd-1.2.0-1.20120401...
Trying to summarize:
The group category should be removed, as it is no longer required.
Kept the tag, as proposed in
http://fedoraproject.org/wiki/Packaging_tricks#Recommended_values_for_the...
[-] spec file is legible
-Please add something along the lines of "##Commands to grab from git" above
the commands to grab the source.
Fixed
[-] sources match upstream: md5sum do not match...
As
explained, because git clone from gitorious does not retain file
modification dates. I suggest this is handled the same way as sources from svn
repos, which always have this issue. In this case, a diff -r is used instead of
md5sum to verify the sources. See e. g.
https://bugzilla.redhat.com/show_bug.cgi?id=707613#c12
-%{?rel_tag} should not be in the version, please remove it and move
it to
release
Fixed (after asking on mailing list).
Requires(post) and (postun) is not necessary, please remove it
Fixed
I bumped up the karma on ASL release 8, though I still could not test
mock...
Thanks. I have pushed ASL release 8 to stable, and bombono now builds in
mock
for me. (to my regret, there was still a bug about missing ExcludeArch in ASL,
but it does not affect rpmfusion builds on i686/x86_64)
Also, I noticed you explicitly required 5 packages. Explicit requires
are only
needed if they are not needed or are picked up by RPMBUILD or a requirement of
one of those picked by RPMBuild. Please double check these!
These are as prescribed by upstream in the README. They need to be explicit
since they are not linked but rather invoked from the application.
The date should be changed on a git snapshot only when the source is
re-pulled from git...
I have a script generating the sources, which actually makes a "git pull" each
time. So I guess it's OK?!
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.