On Seg, 2016-09-26 at 11:59 +0200, Nicolas Chauvet wrote:
2016-09-24 5:39 GMT+02:00 Sérgio M. Basto
<sergiomb(a)rpmfusion.org>:
>
> commit 36ac6ae0d5cb72b37ba60a8dc69eae3b147e0935
> Author: Sérgio M. Basto <sergio(a)serjux.com>
> Date: Sat Sep 24 04:31:21 2016 +0100
>
> Update to 0.148-20160924-86b7198 version
> %endif
--- a/x264.spec
+++ b/x264.spec
@@ -1,7 +1,7 @@
-# globals for x264-0.148-20160614-a5e06b9.tar.bz2
+# globals for x264-0.148-20160924-86b7198.tar.bz2
%global api 148
-%global gitdate 20160614
-%global gitversion a5e06b9
+%global gitdate 20160924
+%global gitversion 86b7198
%global snapshot %{gitdate}-%{gitversion}
%global gver .%{gitdate}git%{gitversion}
%global branch stable
@@ -29,8 +29,8 @@
Summary: H264/AVC video streams encoder
Name: x264
-Version: 0.%{api}
-Release: 11%{?gver}%{?_with_bootstrap:_bootstrap}%{?dist}
+Version: 0.%{api}%{?gver}
+Release: 1%{?_with_bootstrap:_bootstrap}%{?dist}
Version: 0.148.20160924git86b7198-1
vs live555 Version: 2016.07.19
Version 0.148 is useful, you suggest 0.148.2016.09.24.git86b7198-1 ? ,
also git hash is useful ... or like this 0.148.20160924.86b7198-1
without git world ?
yeah I think version should be with date of the source and git
shortcommit : %{gitdate}.git%{shortcommit} this should be part of
version, if not, one day we are in 0.148-117 and counting, is like
rtmpdump.spec ! , the version almost stopped , so our version should
include %{gitdate}.git%{shortcommit} .
This is approved ?
Thanks
> %changelog
> +* Sat Sep 24 2016 Sérgio Basto <sergio(a)serjux.com> -
> 0.148.20160924git86b7198-1
> +- Update to 0.148-20160924-86b7198 version
> +- Change versioning of the package in order to have better
> information, now the
> + package version include date plus git short commit, as result we
> may reset the
> + release count.
This versionning change violate the packaging guideline.
https://fedoraproject.org/wiki/Packaging:Versioning
I've untagged this build for now.
If you want to enforce dependencies based on snapshot date, please
have a look on live555 instead.
Thx
--
Sérgio M. B.