[Bug 1156] Review request: performous - Karaoke game

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1156 Robert-André Mauchin <zebob.m(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m(a)gmail.com --- Comment #19 from Robert-André Mauchin <zebob.m(a)gmail.com&gt; --- - Remove the unneeded cruft: - Group: - BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) - rm -rf $RPM_BUILD_ROOT - %clean rm -rf $RPM_BUILD_ROOT - %defattr(-,root,root,-) - You add a patch but you don't apply it? #%%patch0 -p1 #%%patch1 -p1 Please explain. Also if you do add the patches, add a comment above thm explaining why they are needed. - %post -p /sbin/ldconfig %postun -p /sbin/ldconfig Use the brand new ldconfig macro instead: %ldconfig_scriptlets See https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets for rationale. - pushd build/popd Just use cd build, you don't actually need the pushd/popd mechanism here. - Use an URL for Source0, not a zip: Source0: https://github.com/performous/performous/archive/%{version}/%{name}-%{ver... - make %{?_smp_mflags} → %make_build - make install DESTDIR=$RPM_BUILD_ROOT → %make_install - -DSHARE_INSTALL:PATH=share/performous → -DSHARE_INSTALL:PATH=%{_datadir}/performous - Add the license as a Source from https://raw.githubusercontent.com/performous/performous/master/licence.txt and install it with %license. Haven't started fedora-review yet, I'll let you fix these first then I'll continue. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.