[Bug 89] Review request: avbin - Cross-platform media decoding library

http://bugzilla.rpmfusion.org/show_bug.cgi?id=89 Stewart Adam <s.adam(a)diffingo.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |s.adam(a)diffingo.com Status|REOPENED |ASSIGNED --- Comment #9 from Stewart Adam <s.adam(a)diffingo.com&gt; 2009-01-15 18:22:26 --- (Tibbs review tempate - https://fedoraproject.org/wiki/User:Tibbs/Review_Template) + source files match upstream: 46a7e5ee68601e2053587d3248e7dfe81375aee1 + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. + license text included in package. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package installs properly. + debuginfo package looks complete. + rpmlint is silent. + final provides and requires are sane + shared libraries are present, ldconfig is run. "ldd /usr/lib64/libavbin.so.7" shows that the linking has been done well and it's linking dynamically to ffmpeg. + no duplicates in %files. + file permissions are appropriate. + no libtool .la droppings. It's a minor issue, but I noticed that the description lines all end well short of the 80 character limit - could you reformat them so that they are closer to the 80 character limit? This way when users view it on the terminal or from the UI, the text won't appear odd. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.