[Bug 563] Review request: xorg-x11-drv-catalyst - AMD's proprietary driver for ATI graphic cards
http://bugzilla.rpmfusion.org/show_bug.cgi?id=563
--- Comment #8 from NicolasChauvet <kwizart(a)gmail.com> 2009-05-01 20:22:28 ---
I cannot test until monday, but i't rather good, so still few minor comments:
- Requires(post): ldconfig is undeeded since we use %post libs -p
/sbin/ldconfig
- Requires(post): catalyst-kmod >= %{version} - IS this needed ?, Requires is
already set, everything which isn't mandatory should be avoided to prevent
weird effect or case corner at the rpm transaction check while updating the
driver.
( in theory it should only be: "Requires: catalyst-kmod = %{version}" ).
- This one is more important and was missing: (for the main package).
Requires: %{name}-libs-%{_target_cpu} = %{version}-%{release}
the requirement for the libs subpackage must be architecture dependant.
- Are you really sure that all files in /etc should be set as %config ?!
- #ExclusiveArch: x86_64 i586
We talk about that previously, use the same tweak as the nvidia driver, less
problem...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.