[Bug 2319] Review request: vdr-markad - Advanced commercial detection for VDR
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2319
--- Comment #15 from MartinKG <mgansser(a)alice.de> 2014-05-02 22:30:58 CEST ---
(In reply to comment #14)
- Compiler flags are not honored.
http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
fixed, added %%{optflags} macro
- /usr/share/locale/sk_SK directory should be owned by
'filesystem' package.
It's not an issue related to this package.
don't know how to fix this.
- %{vdr_vardir}/markad/logos contains images. Why they are marked as
configuration files?
fixed, because this are no config files.
Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/vdr-markad.spec
SRPM URL:
http://martinkg.fedorapeople.org/Review/SRPMS/vdr-markad-0.1.4-4.20140421...
%changelog
* Fri May 02 2014 Martin Gansser <martinkg(a)fedoraproject.org> -
0.1.4-4.20140421git3c99d47
- removed %%config(noreplace) flag in %%file section for logo dir
- added %%{optflags} macro in build section
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.