[Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
Orcan Ogetbil <orcanbahri(a)yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|rpmfusion-package- |orcanbahri(a)yahoo.com
|review(a)rpmfusion.org |
Status|ASSIGNED |NEW
--- Comment #9 from Orcan Ogetbil <orcanbahri(a)yahoo.com> 2008-11-25 20:58:21 ---
Thanks for the update!
(In reply to comment #8)
(In reply to comment #7)
> * For the .desktop file:
> ** Use Name: Gambatte Qt instead of QT
Fixed.
Actually, you'll need to make a s/QT/Qt/ for the whole spec file. Sorry I
should've been clearer.
> ** Please add a Generic Name
GenericName is not required by the Desktop entry specification. Anyway I added
it.
I'm not sure. It is in the sample .desktop file given in the guidelines:
http://fedoraproject.org/wiki/Packaging/Guidelines#.desktop_file_creation
They are nice to have in my opinion. Having a bunch of applications with a
Generic Name makes those without a Generic Name look dull in the menu.
> ? Any possible (license) issues with the 2 source images you
added?
I looked a lot for a Gameboy icon image. Most are unusable because they are
either too big, poorly drown or copyrighted.
The one I used is taken from:
http://modmyi.com/forums/skinning-themes-discussion/17378-gameboy-advance...
Unluckily there is no statement about its licensing.
That link doesn't lead to the website of the creator of these images. I just do
not want us to get into trouble. Let me ask other people.
> ? What are the 4 exports in the %build section for? Aren't they too many?
They are all required. The first two are needed for libgambatte and
gambatte-sql. The latter two for gambatte-qt.
Then why are you passing the %optflags once more to the scons for libgambatte
and gambatte_sdl ?
> ! You may want to consider adding mime-types for gameboy rom
images in the qt
> package (you can use the same icons). Mime-types provide convenience.
There are no standard mime types for gameboy ROM types.
Moreover, I don't think they are so useful in this particular case because most
of the times ROMs are compressed (in .zip files) and the emulators can directly
open these compressed files.
I saw the references to .gb, .gbc, .sgb filetypes when I went to File->Open in
Gambatte-Qt. I'm not familiar with gameboy roms but if you think adding
mimetypes for these flavors won't provide much convenience, then it's fine to
leave it out.
Additionally, you can use for-loops such as
for txtfile in README \
gambatte_qt/man/gambatte_qt.6 \
gambatte_sdl/man/gambatte_sdl.6;
do
iconv --from=ISO-8859-1 --to=UTF-8 $txtfile > tmp
touch -r $txtfile tmp
mv tmp $txtfile
done
to improve the code. I leave this up to you.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.