http://bugzilla.rpmfusion.org/show_bug.cgi?id=32 Thorsten Leemhuis <fedora(a)leemhuis.info&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|2 |3 Status|NEW |ASSIGNED --- Comment #2 from Thorsten Leemhuis <fedora(a)leemhuis.info&gt; 2008-08-03 13:53:50 --- Some comments: * > Source0: %{name}-%{version}.%{snapshot}.tar.bz2 Please provide a full url for Source0 and/or describe how one can download the snapshot to check that the sources are unmodified upstream sources. See http://fedoraproject.org/wiki/Packaging/SourceURL for details. * The description is quite short; would be nice it it would actually describe what one can do with the software. * > Requires: a52dec Why is this needed? the dep "liba52.so.0()" is added automatically by rpm; if /usr/bin/a52dec or /usr/bin/extract_a52 are called then use something like Requires: %{_bindir}a52dec Looks good apart from the above and rpmlint is silent. The package does some unusual things here and there, but seems that's normal for VDR plugins. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=32 --- Comment #4 from Thorsten Leemhuis <fedora(a)leemhuis.info&gt; 2009-01-24 14:10:17 --- - This IMHO is not enough -- the comment should state the exact commands that are needed to get exactly the checkout that is found in the tarball. This should allow the reviewer to easily compare the source from the tarball with the upstream source; it sometimes also makes updating to a later checkout easier; http://fedoraproject.org/wiki/Packaging/SourceURL has more details - you should have updated the changelog ;-) - rpmlint is silent I'll approve this once the first point got fixed -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=32 Richard <hobbes1069(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hobbes1069(a)gmail.com --- Comment #6 from Richard <hobbes1069(a)gmail.com&gt; 2011-06-28 19:39:29 --- The URLs to the spec and source rpm are broken. Should this review request be closed? -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=32 Richard <hobbes1069(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|3 | -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.