[Bug 3328] New: Review request: pianobar - console-based client for the personalized online radio Pandora
2:56 a.m.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
Bug #: 3328
Summary: Review request: pianobar - console-based client for
the personalized online radio Pandora
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: maxamillion(a)fedoraproject.org
CC: rpmfusion-package-review(a)rpmfusion.org
Spec: https://maxamillion.fedorapeople.org/pianobar.spec
SRPM: https://maxamillion.fedorapeople.org/pianobar-2014.06.08-1.fc20.src.rpm
pianobar is a free/open-source, console-based client for the personalized
online radio Pandora
Package is not eligible in Fedora because it requires ffmpeg-devel as a build
requirement.
$ rpmlint
/var/lib/mock/fedora-20-x86_64-rpmfusion/result/pianobar-2014.06.08-1.fc20.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[21:50:55|admiller@carbon(0) ~/rpmbuild/SOURCES/pianobar-2014.06.08]
$ rpmlint
/var/lib/mock/fedora-20-x86_64-rpmfusion/result/pianobar-2014.06.08-1.fc20.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
This is my first RPMFusion package, I am currently a Fedora packager:
https://admin.fedoraproject.org/pkgdb/packager/maxamillion/
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:57 a.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
Adam Miller <maxamillion(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |2
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3 a.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #1 from Adam Miller <maxamillion(a)fedoraproject.org> 2014-08-12 05:00:30
CEST ---
I forgot to mention, I've also submitted my patch to the Makefile upstream:
https://github.com/PromyLOPh/pianobar/pull/474
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:39 p.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #2 from Adam Miller <maxamillion(a)fedoraproject.org> 2014-08-12 17:39:48
CEST ---
Spec: https://maxamillion.fedorapeople.org/pianobar.spec
SRPM: https://maxamillion.fedorapeople.org/pianobar-2014.06.08-2.fc20.src.rpm
Removed patch based on upstream feedback.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:40 p.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
Nicolas Reed <sgtbigman(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sgtbigman(a)gmail.com
--- Comment #3 from Nicolas Reed <sgtbigman(a)gmail.com> 2014-12-22 15:40:11 CET ---
I have built an rpm package for Fedora 21 (using your .spec file), and was
wondering if you would need any help supporting pianobar for Fedora 21 on copr.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:37 p.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
Antonio Trande <anto.trande(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |anto.trande(a)gmail.com
--- Comment #4 from Antonio Trande <anto.trande(a)gmail.com> 2014-12-22 16:37:14 CET
---
- make can be omitted among BR packages.
- %doc %{_mandir}/man1/%{name}*
Remove %doc macro from this line.
- Use %license macro to package the COPYING file.
- %exclude %{_docdir}/%{name}/INSTALL
This line is unnecessary.
- Are optimization flags respected ?
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:43 p.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hobbes1069(a)gmail.com
--- Comment #5 from Richard <hobbes1069(a)gmail.com> 2015-01-14 22:43:17 CET ---
It looks like some feedback has been given but no one has take up the review
formally. Are you still interested in packaging this for RPM Fusion?
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:35 a.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #6 from Nicolas Reed <sgtbigman(a)gmail.com> 2015-01-15 01:35:27 CET ---
If the original submitter is not available or has too many other things going
on at the moment, I'm open to packaging a Fedora 21 build for RPM Fusion. I
just didn't want to step on anyone else's work before doing so, especially
since I'm working off of his original spec file.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:46 a.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #7 from Richard <hobbes1069(a)gmail.com> 2015-01-17 04:46:28 CET ---
Let's give them a few more days to respond to make sure but I don't have a
problem with that.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:46 p.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |stephendherr(a)gmail.com
--- Comment #8 from Richard <hobbes1069(a)gmail.com> ---
*** Bug 3833 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
6:47 p.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #9 from Richard <hobbes1069(a)gmail.com> ---
Nicolas, are you still up for packaging this?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
7:16 p.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #10 from stephendherr(a)gmail.com ---
Well I'm not Nicolas, but I'm still up for packaging it.
SPEC: https://www.dropbox.com/s/kczgg3fm1ajfjob/pianobar.spec?dl=1
SRPM:
https://www.dropbox.com/s/jiakm17yrfs5hqt/pianobar-2016.06.02-1.fc24.src....
2016.06.02 is still the newest released version:
https://6xq.net/pianobar/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
6:16 p.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #11 from Richard <hobbes1069(a)gmail.com> ---
Ok, working on what to do here. Your spec file is pretty out of date with the
packaging guidelines. I actually package it for myself but that would be
awkward to provide that to you and then do the package review.
Would it be better for me to post my package and let you review it? We can
co-maintain it, not that it's updated frequently.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
8:32 p.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #12 from stephendherr(a)gmail.com ---
That's fine. I don't care about who packages it, I just think it's a
worthwhile
thing to have available.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
12:07 p.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|2 |3
Assignee|rpmfusion-package-review@rp |stephendherr(a)gmail.com
|mfusion.org |
--- Comment #13 from Richard <hobbes1069(a)gmail.com> ---
SPEC: https://hobbes1069.fedorapeople.org/pianobar.spec
SRPM: https://hobbes1069.fedorapeople.org/pianobar-2016.06.02-1.fc25.src.rpm
Referenced Bugs:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2
[Bug 2] Tracker: New packages awaiting review
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3
[Bug 3] Tracker: Packages under review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
1:14 p.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #14 from stephendherr(a)gmail.com ---
I'm not sure if there's a more formal review process that I'm supposed to be
following or something, but this looks good to me. I reviewed the src rpm with
the sha256 sum of:
55ee0da9bc5e437717ef1798276415c0675db3e4708e1d9caab4742d9709eb05
SPEC file makes sense, rpmlint is happy, only source is the tarball from the
pianobar website, build / install scripts are simple and obvious, description
is good, dependencies declared properly.
I'd say it's good to be built / shipped.
--
You are receiving this mail because:
You are on the CC list for the bug.
1:28 p.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #15 from Richard <hobbes1069(a)gmail.com> ---
The preference is to use fedora-review which automates a lot of checks but it's
broken for RPM Fusion right now. It searches the mock config file for the root
name but RPM Fusion mock config files use an include statement to pull in the
parent Fedora mock config file and fedora-review doesn't know how to handle
that.
Are you currently a Fedora packager?
--
You are receiving this mail because:
You are on the CC list for the bug.
1:34 p.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
Vasiliy Glazov <vascom2(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |vascom2(a)gmail.com
--- Comment #16 from Vasiliy Glazov <vascom2(a)gmail.com> ---
Spec has one significant problem: not used fedora flags while linking.
You should use
%prep
%autosetup
touch configure
chmod +x configure
%build
%configure
instead of CFLAGS="%{optflags}";export CFLAGS
--
You are receiving this mail because:
You are on the CC list for the bug.
2:47 p.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #17 from stephendherr(a)gmail.com ---
(In reply to Richard from comment #15)
Are you currently a Fedora packager?
No I'm not.
If fedora-review is broken what do you want me to do?
--
You are receiving this mail because:
You are on the CC list for the bug.
6:51 p.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #18 from Richard <hobbes1069(a)gmail.com> ---
Sorry, I assumed you were a packager already. We'll need to find someone else
to officially review the package...
Vasiliy?
--
You are receiving this mail because:
You are on the CC list for the bug.
3:46 a.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
Vasiliy Glazov <vascom2(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
You are receiving this mail because:
You are on the CC list for the bug.
3:47 a.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
Vasiliy Glazov <vascom2(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|stephendherr(a)gmail.com |vascom2(a)gmail.com
--
You are receiving this mail because:
You are on the CC list for the bug.
10:46 a.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #19 from Richard <hobbes1069(a)gmail.com> ---
I've already included your previous improvements. Anything else before I post
new links?
--
You are receiving this mail because:
You are on the CC list for the bug.
11:17 a.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #20 from Vasiliy Glazov <vascom2(a)gmail.com> ---
You can post new links. I will see it in next few days.
--
You are receiving this mail because:
You are on the CC list for the bug.
7:29 p.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #21 from Richard <hobbes1069(a)gmail.com> ---
SPEC: https://hobbes1069.fedorapeople.org/pianobar.spec
SRPM: https://hobbes1069.fedorapeople.org/pianobar-2016.06.02-2.fc25.src.rpm
* Wed May 24 2017 Richard Shaw <hobbes1069(a)gmail.com> - 2016.06.02-2
- Use configure so linker flags are utilized.
--
You are receiving this mail because:
You are on the CC list for the bug.
3:24 a.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
Vasiliy Glazov <vascom2(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Blocks|3 |4
Resolution|--- |FIXED
--- Comment #22 from Vasiliy Glazov <vascom2(a)gmail.com> ---
APPROVED
You will need to request branches on the link below
https://admin.rpmfusion.org/pkgdb/request/package/
Referenced Bugs:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3
[Bug 3] Tracker: Packages under review.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4
[Bug 4] Tracker: Accepted packages.
--
You are receiving this mail because:
You are on the CC list for the bug.
12:33 p.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review+
--
You are receiving this mail because:
You are on the CC list for the bug.
12:34 p.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review+ |
--- Comment #23 from Richard <hobbes1069(a)gmail.com> ---
(In reply to Vasiliy Glazov from comment #22)
APPROVED
You will need to request branches on the link below
https://admin.rpmfusion.org/pkgdb/request/package/
You also need to set the fedora-review flag to +. It doesn't like me doing it.
--
You are receiving this mail because:
You are on the CC list for the bug.
12:43 p.m.
New subject: [Bug 3328] Review request: pianobar - console-based client for the
personalized online radio Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
Vasiliy Glazov <vascom2(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review+
--- Comment #24 from Vasiliy Glazov <vascom2(a)gmail.com> ---
We have not simple step-by-step insctuction and I am always forget somthing :)
--
You are receiving this mail because:
You are on the CC list for the bug.
12:53 p.m.
New subject: [Bug 3328] Review request: pianobar - Console-based client for
Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Review request: pianobar - |Review request: pianobar -
|console-based client for |Console-based client for
|the personalized online |Pandora
|radio Pandora |
--
You are receiving this mail because:
You are on the CC list for the bug.
8:26 a.m.
New subject: [Bug 3328] Review request: pianobar - Console-based client for
Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
leigh scott <leigh123linux(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |leigh123linux(a)gmail.com
--- Comment #25 from leigh scott <leigh123linux(a)gmail.com> ---
Package processed
--
You are receiving this mail because:
You are on the CC list for the bug.
8:32 a.m.
New subject: [Bug 3328] Review request: pianobar - Console-based client for
Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #26 from Nicolas Chauvet <kwizart(a)gmail.com> ---
package is still not imported.
Is there any reason for that?
Please escalate to me if any issue.
--
You are receiving this mail because:
You are on the CC list for the bug.
2:07 p.m.
New subject: [Bug 3328] Review request: pianobar - Console-based client for
Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #27 from Richard <hobbes1069(a)gmail.com> ---
Sorry, first time for a new package in the new infra. I don't remember seeing
an email that it was ready for import. I'll work on that now.
--
You are receiving this mail because:
You are on the CC list for the bug.
7:13 p.m.
New subject: [Bug 3328] Review request: pianobar - Console-based client for
Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #28 from Richard <hobbes1069(a)gmail.com> ---
Built for Rawhide. F25/26 building now.
--
You are receiving this mail because:
You are on the CC list for the bug.
7:56 p.m.
New subject: [Bug 3328] Review request: pianobar - Console-based client for
Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #29 from leigh scott <leigh123linux(a)gmail.com> ---
(In reply to Richard from comment #28)
Built for Rawhide. F25/26 building now.
Can you remove the extra (it's lisred twice)
BuildRequires: libmad-devel
--
You are receiving this mail because:
You are on the CC list for the bug.
8:03 p.m.
New subject: [Bug 3328] Review request: pianobar - Console-based client for
Pandora
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3328
--- Comment #30 from Richard <hobbes1069(a)gmail.com> ---
Fixed, but not worth new builds :)
--
You are receiving this mail because:
You are on the CC list for the bug.
2734
days inactive
3789
days old
rpmfusion-developers@lists.rpmfusion.org
35 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla