9:02 a.m.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
Summary: Review request: gambatte - An accuracy-focused Game Boy
/ Game Boy Color emulator
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: musuruan(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
Blocks: 2
Estimated Hours: 0.0
http://www.webalice.it/musuruan/RPMS/reviews/gambatte.spec
http://www.webalice.it/musuruan/RPMS/reviews/gambatte-0.4.0-1.fc9.src.rpm
Gambatte is an accuracy-focused, open-source, cross-platform
Game Boy / Game Boy Color emulator written in C++. It is based on hundreds of
corner case hardware tests, as well as previous documentation and reverse
engineering efforts.
This package cannot go in Fedora because emulators are not permitted.
Rpmlint output is clean.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:40 a.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
Conrad Meyer <konrad(a)tylerc.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |konrad(a)tylerc.org
--- Comment #1 from Conrad Meyer <konrad(a)tylerc.org> 2008-11-16 10:40:28 ---
It's not strictly true to say emulators are not permitted in Fedora (for
example qemu and bochs are perfectly acceptable); can this run e.g. homebrew
games without requiring original gameboy firmware?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:13 a.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #2 from Andrea Musuruane <musuruan(a)gmail.com> 2008-11-16 11:13:32 ---
(In reply to comment #1)
It's not strictly true to say emulators are not permitted in
Fedora (for
example qemu and bochs are perfectly acceptable); can this run e.g. homebrew
games without requiring original gameboy firmware?
Gnuboy is here in RPM Fusion. Gameboy and other Nintendo emulators aren't
welcomed in Fedora.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:23 a.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #3 from Conrad Meyer <konrad(a)tylerc.org> 2008-11-16 11:23:22 ---
(In reply to comment #2)
Gnuboy is here in RPM Fusion. Gameboy and other Nintendo emulators
aren't
welcomed in Fedora.
I would wait for a reply from spot on
https://bugzilla.redhat.com/show_bug.cgi?id=466658 before jumping to that
inclusion. It *is* rpm fusion policy to really only distribute what Fedora can
(or will) not.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:23 a.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #4 from Conrad Meyer <konrad(a)tylerc.org> 2008-11-16 11:23:58 ---
Sorry, I meant `conclusion,' not `inclusion.'
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:40 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
Thorsten Leemhuis <fedora(a)leemhuis.info> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fedora(a)leemhuis.info
--- Comment #5 from Thorsten Leemhuis <fedora(a)leemhuis.info> 2008-11-16 13:40:31
---
(In reply to comment #3)
I would wait for a reply from spot on
https://bugzilla.redhat.com/show_bug.cgi?id=466658 before jumping to that
conclusion. It *is* rpm fusion policy to really only distribute what Fedora can
(or will) not.
Spot according to https://bugzilla.redhat.com/show_bug.cgi?id=466658#c8
forwarded this to legal four weeks ago. I'd ping him and ask for a update. If
nothing happens within one week I'd say the package is acceptable for RPM
Fusion; once it got accepted it's easy to do a second review and to move .
Just my 2 cent. Site note: This sort of problem (package inclusion in Fedora
gets delayed; packager doesn't want to wait) already was discussed on the
developers list a few weeks ago.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
3:45 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #6 from Andrea Musuruane <musuruan(a)gmail.com> 2008-11-19 16:45:04 ---
(In reply to comment #3)
I would wait for a reply from spot on
https://bugzilla.redhat.com/show_bug.cgi?id=466658 before jumping to that
conclusion. It *is* rpm fusion policy to really only distribute what Fedora can
(or will) not.
A reply arrived and it did not surprise me: "Red Hat legal gave this a lot of
thought, but in the end, they decided this one was too risky."
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:45 a.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
Orcan Ogetbil <orcanbahri(a)yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |orcanbahri(a)yahoo.com
Status|NEW |ASSIGNED
--- Comment #7 from Orcan Ogetbil <orcanbahri(a)yahoo.com> 2008-11-25 05:45:13 ---
I reviewed this package. There are a couple minor issues, and I also have a few
questions:
* Each package must consistently use macros, as described in the macros section
of Packaging Guidelines. There are usages of both %{buildroot} and
$RPM_BUILD_ROOT; also %{optflags} and $RPM_OPT_FLAGS. Please stick to one
notation.
* Please preserve the timestamps of the doc files by using "touch -r file1
file2" when you are fixing the encoding
* For the .desktop file:
** Use Name: Gambatte Qt instead of QT
** Please add a Generic Name
* About %description. There are a few files compiled in the SDL-package that
are in C.
? Any possible (license) issues with the 2 source images you added?
? What are the 4 exports in the %build section for? Aren't they too many?
? What is the hwtests directory for? Worth to package?
! You may want to consider adding mime-types for gameboy rom images in the qt
package (you can use the same icons). Mime-types provide convenience.
? Can't you just use "%post qt" instead of "%post -n gambatte-qt"
?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:45 a.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
Orcan Ogetbil <orcanbahri(a)yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|2 |3
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #8 from Andrea Musuruane <musuruan(a)gmail.com> 2008-11-25 15:00:23 ---
(In reply to comment #7)
* Each package must consistently use macros, as described in the
macros section
of Packaging Guidelines. There are usages of both %{buildroot} and
$RPM_BUILD_ROOT; also %{optflags} and $RPM_OPT_FLAGS. Please stick to one
notation.
Fixed.
* Please preserve the timestamps of the doc files by using
"touch -r file1
file2" when you are fixing the encoding
Fixed.
* For the .desktop file:
** Use Name: Gambatte Qt instead of QT
Fixed.
** Please add a Generic Name
GenericName is not required by the Desktop entry specification. Anyway I added
it.
* About %description. There are a few files compiled in the
SDL-package that
are in C.
Description is taken from the README file and I'm not very keen in changing it.
? Any possible (license) issues with the 2 source images you added?
I looked a lot for a Gameboy icon image. Most are unusable because they are
either too big, poorly drown or copyrighted.
The one I used is taken from:
http://modmyi.com/forums/skinning-themes-discussion/17378-gameboy-advance...
Unluckily there is no statement about its licensing.
? What are the 4 exports in the %build section for? Aren't they
too many?
They are all required. The first two are needed for libgambatte and
gambatte-sql. The latter two for gambatte-qt.
? What is the hwtests directory for? Worth to package?
This directory is only useful for a developer who wants to improve gambatte. It
is not useful for the final user. Therefore I decided not to package it.
! You may want to consider adding mime-types for gameboy rom images
in the qt
package (you can use the same icons). Mime-types provide convenience.
There are no standard mime types for gameboy ROM types.
Moreover, I don't think they are so useful in this particular case because most
of the times ROMs are compressed (in .zip files) and the emulators can directly
open these compressed files.
? Can't you just use "%post qt" instead of "%post
-n gambatte-qt" ?
Fixed.
Updated package:
http://www.webalice.it/musuruan/RPMS/reviews/gambatte.spec
http://www.webalice.it/musuruan/RPMS/reviews/gambatte-0.4.0-2.fc9.src.rpm
* Tue Nov 25 2008 Andrea Musuruane <musuruan(a)gmail.com> - 0.4.0-2
- Improved macro usage
- Preserved timestamp of doc files converted to UTF-8
- Cosmetic changes
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:58 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
Orcan Ogetbil <orcanbahri(a)yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|rpmfusion-package- |orcanbahri(a)yahoo.com
|review(a)rpmfusion.org |
Status|ASSIGNED |NEW
--- Comment #9 from Orcan Ogetbil <orcanbahri(a)yahoo.com> 2008-11-25 20:58:21 ---
Thanks for the update!
(In reply to comment #8)
(In reply to comment #7)
> * For the .desktop file:
> ** Use Name: Gambatte Qt instead of QT
Fixed.
Actually, you'll need to make a s/QT/Qt/ for the whole spec file. Sorry I
should've been clearer.
> ** Please add a Generic Name
GenericName is not required by the Desktop entry specification. Anyway I added
it.
I'm not sure. It is in the sample .desktop file given in the guidelines:
http://fedoraproject.org/wiki/Packaging/Guidelines#.desktop_file_creation
They are nice to have in my opinion. Having a bunch of applications with a
Generic Name makes those without a Generic Name look dull in the menu.
> ? Any possible (license) issues with the 2 source images you
added?
I looked a lot for a Gameboy icon image. Most are unusable because they are
either too big, poorly drown or copyrighted.
The one I used is taken from:
http://modmyi.com/forums/skinning-themes-discussion/17378-gameboy-advance...
Unluckily there is no statement about its licensing.
That link doesn't lead to the website of the creator of these images. I just do
not want us to get into trouble. Let me ask other people.
> ? What are the 4 exports in the %build section for? Aren't they too many?
They are all required. The first two are needed for libgambatte and
gambatte-sql. The latter two for gambatte-qt.
Then why are you passing the %optflags once more to the scons for libgambatte
and gambatte_sdl ?
> ! You may want to consider adding mime-types for gameboy rom
images in the qt
> package (you can use the same icons). Mime-types provide convenience.
There are no standard mime types for gameboy ROM types.
Moreover, I don't think they are so useful in this particular case because most
of the times ROMs are compressed (in .zip files) and the emulators can directly
open these compressed files.
I saw the references to .gb, .gbc, .sgb filetypes when I went to File->Open in
Gambatte-Qt. I'm not familiar with gameboy roms but if you think adding
mimetypes for these flavors won't provide much convenience, then it's fine to
leave it out.
Additionally, you can use for-loops such as
for txtfile in README \
gambatte_qt/man/gambatte_qt.6 \
gambatte_sdl/man/gambatte_sdl.6;
do
iconv --from=ISO-8859-1 --to=UTF-8 $txtfile > tmp
touch -r $txtfile tmp
mv tmp $txtfile
done
to improve the code. I leave this up to you.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5:08 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #10 from Andrea Musuruane <musuruan(a)gmail.com> 2008-11-26 18:08:42 ---
(In reply to comment #9)
Actually, you'll need to make a s/QT/Qt/ for the whole spec file.
Sorry I
should've been clearer.
Fixed. I found only one occurrence.
I'm not sure. It is in the sample .desktop file given in the
guidelines:
http://fedoraproject.org/wiki/Packaging/Guidelines#.desktop_file_creation
They are nice to have in my opinion. Having a bunch of applications with a
Generic Name makes those without a Generic Name look dull in the menu.
In the Freedesktop specs it is marked as optional:
http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-la...
Anyway, as I said, I added it because I agree with you that it has a purpose.
That link doesn't lead to the website of the creator of these
images. I just do
not want us to get into trouble. Let me ask other people.
OK. I'll wait for this reply before submitting a new version. If you can
provide a better (licensed) icon you are welcome of course! :)
Then why are you passing the %optflags once more to the scons for
libgambatte
and gambatte_sdl ?
I just noticed that the following lines were redundant.
export CFLAGS="%{optflags}"
export CXXFLAGS="%{optflags}"
Therefore I removed them.
But calling scons in the following format is correct.
scons %{?_smp_mflags} CFLAGS="%{optflags}" CXXFLAGS="%{optflags}"
Upstream SConstruct files require both variable to be present to work.
Additionally, you can use for-loops such as
for txtfile in README \
gambatte_qt/man/gambatte_qt.6 \
gambatte_sdl/man/gambatte_sdl.6;
do
iconv --from=ISO-8859-1 --to=UTF-8 $txtfile > tmp
touch -r $txtfile tmp
mv tmp $txtfile
done
to improve the code. I leave this up to you.
Done.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
6 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #11 from Orcan Ogetbil <orcanbahri(a)yahoo.com> 2008-11-26 19:00:23 ---
I learned that you can use a 3rd party image only if it is under a permissible
license. So you may want to ask the fedora-art-list to make an icon for you.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
6:12 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #12 from Orcan Ogetbil <orcanbahri(a)yahoo.com> 2008-11-26 19:12:22 ---
I meant, you can ask to someone you might know from fedora-art team, otherwise
it is not their duty to make icons for 3rd party repos.
It is OK if you can find a licensed image online. For instance I found this on
wikimedia:
http://commons.wikimedia.org/wiki/Image:Gameboy.jpg
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:24 a.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #13 from Andrea Musuruane <musuruan(a)gmail.com> 2008-11-27 09:24:10 ---
(In reply to comment #12)
I meant, you can ask to someone you might know from fedora-art team,
otherwise
it is not their duty to make icons for 3rd party repos.
It is OK if you can find a licensed image online. For instance I found this on
wikimedia:
http://commons.wikimedia.org/wiki/Image:Gameboy.jpg
To speed up this review, can I took out the current icon and provide a package
without it?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
2 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #14 from Orcan Ogetbil <orcanbahri(a)yahoo.com> 2008-11-27 15:00:25 ---
I guess so, you can take it out for now (but please don't leave it that way);
OR you can use one of the default Fedora icons, one of those game(s) icons
perhaps.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:56 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #15 from David Timms <dtimms(a)iinet.net.au> 2008-11-27 21:56:26 ---
Created an attachment (id=38)
--> (http://bugzilla.rpmfusion.org/attachment.cgi?id=38)
30x32 png icon
(In reply to comment #13)
To speed up this review, can I took out the current icon and provide
a package
without it?
I'd like to see one there. I noticed the cartoon style one someone
in #rf
mentioned has svg source:
http://www.koders.com/noncode/fid668B722B9BC56B3FD24F4A5A8C495CA67C704861...
click on the download link at left/top.
This seems to scale to 30x32 OK, if you want to use that (seems to be in
debians icon collection). (Using inkscape).
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
10:32 a.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #16 from Andrea Musuruane <musuruan(a)gmail.com> 2008-11-28 11:32:51 ---
I found two interesting icons. The first one has been made by Peter Verschoor:
http://iconzworld.com/nx06-icons.html
I'm talking with him if and under which license it is OK to distribute the
icon. ATM he is worried about having trouble with Nintendo. I told him that he
shouldn't have any trouble as long as he remove the Nintendo logo from the
image.
The second one has been made by durex86 and it is in the Open Clip Art Library
and released under public domain:
http://openclipart.org/Xiph/files/Anonymous/7076
I hope to use one of the two.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
10:35 a.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
Andrea Musuruane <musuruan(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
3:04 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #17 from Andrea Musuruane <musuruan(a)gmail.com> 2008-11-29 16:04:20 ---
http://www.webalice.it/musuruan/RPMS/reviews/gambatte.spec
http://www.webalice.it/musuruan/RPMS/reviews/gambatte-0.4.0-3.fc9.src.rpm
%changelog
* Wed Nov 26 2008 Andrea Musuruane <musuruan(a)gmail.com> - 0.4.0-3
- Used an icon made by Peter Verschoor
- Cosmetic changes
Permission to use the Gameboy icon has been granted by Peter Verschoor:
"About the license, my english isn't good enough to understand all the things
that the website says, but I released my icons to be used by anyone, and
modifying them is fine with me to. Same with using them in applications."
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:56 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #18 from Orcan Ogetbil <orcanbahri(a)yahoo.com> 2008-11-29 20:56:00 ---
Thank you. We are almost there.
I downloaded some roms and checked the application itself. Apparently only the
null and oss engines [1] are getting built inside the qt application and in
Fedora 10, I was not able to get any sound out of it. You should make sure that
at least alsa [2] engine is built too.
[1] You can see the available sound engines in Settings->Sound.
[2] Ideally, if possible, you should also build the openal engine.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:15 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #19 from Orcan Ogetbil <orcanbahri(a)yahoo.com> 2008-11-29 21:15:35 ---
I found out that the rpmlint on the installed libgambatte package gives:
$ rpmlint libgambatte
libgambatte.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgambatte.so.0 /lib64/libz.so.1
libgambatte.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgambatte.so.0 /lib64/libm.so.6
See if these can be fixed.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
2:58 a.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #20 from Orcan Ogetbil <orcanbahri(a)yahoo.com> 2008-11-30 03:58:11 ---
I don't know how long the current qt-devel will carry the virtual provides
qt4-devel. It would be better to use BR: qt-devel >= 4.some_version in new
packages.
Sorry for the partial review messages, but I believe this is all.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
12:52 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #21 from Andrea Musuruane <musuruan(a)gmail.com> 2008-11-30 13:52:04 ---
(In reply to comment #18)
Thank you. We are almost there.
I downloaded some roms and checked the application itself. Apparently only the
null and oss engines [1] are getting built inside the qt application and in
Fedora 10, I was not able to get any sound out of it. You should make sure that
at least alsa [2] engine is built too.
[1] You can see the available sound engines in Settings->Sound.
[2] Ideally, if possible, you should also build the openal engine.
Are you sure about this? In F9 and F10 alsa-lib-devel is a dependency of
SDL-devel (which is among the BR). Therefore alsa engine should always be
built. It is built in my case and it works (on F9). I must add that even OSS
engine works too. Openal it is not supported AFAIK.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
3:18 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #22 from Andrea Musuruane <musuruan(a)gmail.com> 2008-11-30 16:18:00 ---
(In reply to comment #19)
I found out that the rpmlint on the installed libgambatte package
gives:
$ rpmlint libgambatte
libgambatte.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgambatte.so.0 /lib64/libz.so.1
libgambatte.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgambatte.so.0 /lib64/libm.so.6
See if these can be fixed.
I've no experience in removing those warning. Help appreciated.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
5:12 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #23 from Orcan Ogetbil <orcanbahri(a)yahoo.com> 2008-11-30 18:12:50 ---
* For instance, if you do a
"s|conf.CheckLib('z', autoadd=1) and||"
on your patch you will get rid of one of them. For the other one, do something
similar (find the unnecessary linking and get rid of it).
* Here are my mock buildlogs for F-9 and F-10:
http://6mata.com:8014/review/build.log.f9
http://6mata.com:8014/review/build.log.f10
(Search for the words 'alsa' and 'asound' in them, no hits, but
"oss" will give
hits) The alsa engine is definitely not built in my case, but only oss engine
is. I can also tell this form the fact that there is an object file
"ossengine.o" created in the gambatte_qt/src build directory but no object file
like "alsaengine.o".
Btw, I found a way to make the oss engine work. That one was my bad. But still,
we need to have the alsa engine built for sure. Can you upload your buildlog?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:52 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #24 from Andrea Musuruane <musuruan(a)gmail.com> 2008-11-30 21:52:42 ---
(In reply to comment #23)
* For instance, if you do a
"s|conf.CheckLib('z', autoadd=1) and||"
on your patch you will get rid of one of them. For the other one, do something
similar (find the unnecessary linking and get rid of it).
If I do that, it won't build minizip support.
Regarding for the other library, I cannot find where it is linked with.
* Here are my mock buildlogs for F-9 and F-10:
http://6mata.com:8014/review/build.log.f9
http://6mata.com:8014/review/build.log.f10
(Search for the words 'alsa' and 'asound' in them, no hits, but
"oss" will give
hits) The alsa engine is definitely not built in my case, but only oss engine
is. I can also tell this form the fact that there is an object file
"ossengine.o" created in the gambatte_qt/src build directory but no object
file
like "alsaengine.o".
Btw, I found a way to make the oss engine work. That one was my bad. But still,
we need to have the alsa engine built for sure. Can you upload your buildlog?
Strange thing. I just compiled gambatte under my new x86_64 PC and I have the
same problem. Maybe this problem is arch dependant. The other PC where I tried
it is a i386.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
4:06 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #25 from Andrea Musuruane <musuruan(a)gmail.com> 2008-12-01 17:06:43 ---
Created an attachment (id=50)
--> (http://bugzilla.rpmfusion.org/attachment.cgi?id=50)
mock F9/i386 build log
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
4:10 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #26 from Andrea Musuruane <musuruan(a)gmail.com> 2008-12-01 17:10:41 ---
(In reply to comment #23)
* Here are my mock buildlogs for F-9 and F-10:
http://6mata.com:8014/review/build.log.f9
http://6mata.com:8014/review/build.log.f10
(Search for the words 'alsa' and 'asound' in them, no hits, but
"oss" will give
hits) The alsa engine is definitely not built in my case, but only oss engine
is. I can also tell this form the fact that there is an object file
"ossengine.o" created in the gambatte_qt/src build directory but no object
file
like "alsaengine.o".
I attached my mock build log for F9/i386. As you can see alsa support is
compiled. This is definitely arch dependant :(
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
4:28 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #27 from Andrea Musuruane <musuruan(a)gmail.com> 2008-12-01 17:28:21 ---
(In reply to comment #26)
I attached my mock build log for F9/i386. As you can see alsa support
is
compiled. This is definitely arch dependant :(
It seems that "linux-g++" is false the following code sniplet in framework.pro
when compiling under x86_64 but it is true when compiling under i386. I have no
idea why. Any qmake expert around here?
linux-g++ {
SOURCES += framework/addaudioengines_linux.cpp \
framework/audioengines/alsaengine.cpp \
framework/SDL_Joystick/src/linux/SDL_sysjoystick.c
HEADERS += framework/audioengines/alsaengine.h
LIBS += -lasound
}
else {
SOURCES += framework/addaudioengines_unix.cpp
freebsd-g++|netbsd-g++|openbsd-g++ {
exists( /usr/include/usb.h ):DEFINES += HAVE_USB_H
exists( /usr/include/usbhid.h ):DEFINES += HAVE_USBHID_H
exists( /usr/include/libusb.h ):DEFINES += HAVE_LIBUSB_H
exists( /usr/include/libusbhid.h ):DEFINES += HAVE_LIBUSBHID_H
SOURCES += framework/SDL_Joystick/src/bsd/SDL_sysjoystick.c
}
else:darwin-g++:SOURCES +=
framework/SDL_Joystick/src/darwin/SDL_sysjoystick.c
else:SOURCES += framework/SDL_Joystick/src/dummy/SDL_sysjoystick.c
}
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
5:04 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #28 from Orcan Ogetbil <orcanbahri(a)yahoo.com> 2008-12-01 18:04:29 ---
It looks like a goof of upstream and I think it should be reported.
For 64 bit system "linux-g++" is false but "linux-g++-64" is true. The
only
occurence of "linux-g++" is in this file, so you can probably fix this issue
with a simple sed.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
2:56 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #29 from Andrea Musuruane <musuruan(a)gmail.com> 2008-12-02 15:56:42 ---
(In reply to comment #28)
It looks like a goof of upstream and I think it should be reported.
The bug has been reported upstream:
https://sourceforge.net/tracker/index.php?func=detail&aid=2377772&...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
2:58 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #30 from Andrea Musuruane <musuruan(a)gmail.com> 2008-12-02 15:58:47 ---
http://www.webalice.it/musuruan/RPMS/reviews/gambatte.spec
http://www.webalice.it/musuruan/RPMS/reviews/gambatte-0.4.0-4.fc10.src.rpm
* Tue Dec 02 2008 Andrea Musuruane <musuruan(a)gmail.com> - 0.4.0-4
- Changed qt4-devel to qt-devel in BR
- Added a patch to compile alsa under linux 64bit systems
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
5:58 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
Orcan Ogetbil <orcanbahri(a)yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|3 |4
--- Comment #31 from Orcan Ogetbil <orcanbahri(a)yahoo.com> 2008-12-02 18:58:25 ---
Thanks. I think this is good now
--------------------------------------------------------------
This package (gambatte) is APPROVED by oget for rpmfusion-free
--------------------------------------------------------------
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:14 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #32 from Andrea Musuruane <musuruan(a)gmail.com> 2008-12-02 20:14:28 ---
Package CVS request
======================
Package Name: gambatte
Short Description: An accuracy-focused Game Boy / Game Boy Color emulator
Owners: musuruan(a)gmail.com
Branches: F-10 F-9
InitialCC:
----------------------
License tag: free
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
12:25 a.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
Orcan Ogetbil <orcanbahri(a)yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
8:40 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
Xavier Lamien <lxtnow(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lxtnow(a)gmail.com
Blocks|33 |
--- Comment #33 from Xavier Lamien <lxtnow(a)gmail.com> 2008-12-03 21:40:23 ---
cvs done.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
3:30 a.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
--- Comment #34 from Kevin Kofler <kevin.kofler(a)chello.at> 2008-12-08 04:30:00 ---
I don't know how long the current qt-devel will carry the virtual
provides
qt4-devel. It would be better to use BR: qt-devel >= 4.some_version in new
packages.
NO!
Please DO NOT BR qt-devel! qt4-devel is there to stay, it allows backporting
your package to older Fedora and RHEL releases more easily and it will also
help in the future when there will be a Qt 5. Please change it back!
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
1:05 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
Andrea Musuruane <musuruan(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #35 from Andrea Musuruane <musuruan(a)gmail.com> 2008-12-15 14:05:00 ---
(In reply to comment #34)
Please DO NOT BR qt-devel! qt4-devel is there to stay, it allows
backporting
your package to older Fedora and RHEL releases more easily and it will also
help in the future when there will be a Qt 5. Please change it back!
I will revert it in the next release.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
6:06 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
Orcan Ogetbil <oget.fedora(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|4 |
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
12:42 p.m.
New subject: [Bug 163] Review request: gambatte - An accuracy-focused Game Boy / Game Boy Color emulator
http://bugzilla.rpmfusion.org/show_bug.cgi?id=163
Thorsten Leemhuis <fedora(a)leemhuis.info> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |4
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
5811
days inactive
5880
days old
rpmfusion-developers@lists.rpmfusion.org
40 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla