11:08 a.m.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
Summary: Review-request: r5u87x-loader - R5U87x webcam firmware
loader
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: j.w.r.degoede(a)hhs.nl
CC: rpmfusion-package-review(a)rpmfusion.org
Blocks: 2
Estimated Hours: 0.0
SPEC: http://people.atrpms.net/~hdegoede/r5u87x-loader.spec
SRPM:
http://people.atrpms.net/~hdegoede/r5u87x-loader-0.2.0-1.32a27008b8b9.fc1...
This package contains a firmware load tool and udev rules to load the
firmware needed to make cameras based on Ricoh R5U87x chipsets work with the
uvcvideo driver.
Why RPMFusion ? -> Non Free
Why Non Free -> because of the firmware microcode files
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:51 p.m.
New subject: [Bug 794] Review-request: r5u87x-loader - R5U87x webcam firmware loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
--- Comment #1 from NicolasChauvet <kwizart(a)gmail.com> 2009-08-31 15:51:23 ---
I don't understand what is nonfree here ?
firmwares that aren't aimed to run on cpu (but hardware device) are allowed in
fedora as an exception despite been nonfree.
Then, As the loader is GPLv2+ it should be allowed in fedora as other firmware
loader are... (such as alsa-tools-firmware).
So this have to be splited between the loader and the firmware, (and both can
go to fedora). That been said, maybe the driver could use the kernel firmware
loading functions instead of this special loader, but that's another subject.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:56 p.m.
New subject: [Bug 794] Review-request: r5u87x-loader - R5U87x webcam firmware loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
Peter Lemenkov <lemenkov(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lemenkov(a)gmail.com
--- Comment #2 from Peter Lemenkov <lemenkov(a)gmail.com> 2009-08-31 15:56:07 ---
I agree with Nicolas. We already have packaged loaders and extractors of
proprietary firmware in Fedora:
https://fedoraproject.org/wiki/Firmware#Tools_for_loading.2Fextracting.2F...
I think, that, at least, loader part may be submitted into Fedora. Not sure
about firmware, but if it is redistributable, then it can be submitted to
Fedora as well.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:58 p.m.
New subject: [Bug 794] Review-request: r5u87x-loader - R5U87x webcam firmware loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
--- Comment #3 from Hans de Goede <j.w.r.degoede(a)hhs.nl> 2009-08-31 15:58:37 ---
(In reply to comment #1)
I don't understand what is nonfree here ?
firmwares that aren't aimed to run on cpu (but hardware device) are allowed in
fedora as an exception despite been nonfree.
Then, As the loader is GPLv2+ it should be allowed in fedora as other firmware
loader are... (such as alsa-tools-firmware).
So this have to be splited between the loader and the firmware, (and both can
go to fedora). That been said, maybe the driver could use the kernel firmware
loading functions instead of this special loader, but that's another subject.
What is non free here is that we have no License Document saying these firmware
files are freely redistributable. We don't have anything saying the contrary
either, so after discussing this with Pix (our ftpmaster if you want) and
getting an ok from him, I've submitted this. But it is definitely not suitable
for Fedora.
As for this being part of the driver, the uvc driver is a driver for all new
standard webcams. Think usb mass storage but then for video. Except these
webcams are like very special usb-stick which will only talk mass storage
protocol after giving them some firmware. Most braindead design ever make your
device use a standardized hardware interface but only after it has been hit
with some proprietary commands, great huh. I'm in contact with the UVC driver
author and he definitely does not want to pollute the generic UVC driver with
custom crap for these broken devices.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4 a.m.
New subject: [Bug 794] Review-request: r5u87x-loader - R5U87x webcam firmware loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
Michel Alexandre Salim <Michael.Silvanus(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |Michael.Silvanus(a)gmail.com
AssignedTo|rpmfusion-package- |Michael.Silvanus(a)gmail.com
|review(a)rpmfusion.org |
--- Comment #4 from Michel Alexandre Salim <Michael.Silvanus(a)gmail.com> 2009-09-01
06:00:17 ---
Taking the review. Hans, I'm assuming you can verify that the webcam works
using this firmware loader, since I cannot test functionality?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4 a.m.
New subject: [Bug 794] Review-request: r5u87x-loader - R5U87x webcam firmware loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
Michel Alexandre Salim <Michael.Silvanus(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:04 a.m.
New subject: [Bug 794] Review-request: r5u87x-loader - R5U87x webcam firmware loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
Hans de Goede <j.w.r.degoede(a)hhs.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|Michael.Silvanus(a)gmail.com |rpmfusion-package-
| |review(a)rpmfusion.org
Status|ASSIGNED |NEW
--- Comment #5 from Hans de Goede <j.w.r.degoede(a)hhs.nl> 2009-09-01 09:04:13 ---
(In reply to comment #4)
Taking the review. Hans, I'm assuming you can verify that the
webcam works
using this firmware loader, since I cannot test functionality?
I've reports of several users that it does, but I do not have such a webcam
myself.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:05 a.m.
New subject: [Bug 794] Review-request: r5u87x-loader - R5U87x webcam firmware loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
Hans de Goede <j.w.r.degoede(a)hhs.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|rpmfusion-package- |Michael.Silvanus(a)gmail.com
|review(a)rpmfusion.org |
--- Comment #6 from Hans de Goede <j.w.r.degoede(a)hhs.nl> 2009-09-01 09:05:05 ---
Sorry about the re-assign (fat fingers misclicked the radio button and then
commit) fixing.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
7:09 a.m.
New subject: [Bug 794] Review-request: r5u87x-loader - R5U87x webcam firmware loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
NicolasChauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kwizart(a)gmail.com
--- Comment #7 from NicolasChauvet <kwizart(a)gmail.com> 2009-09-01 09:09:36 ---
(In reply to comment #3)
...
What is non free here is that we have no License Document saying
these firmware
files are freely redistributable. We don't have anything saying the contrary
either, so after discussing this with Pix (our ftpmaster if you want) and
getting an ok from him, I've submitted this. But it is definitely not suitable
for Fedora.
What have been done to known if theses firmware can be redistributed ?
Does a mail to any hardware vendor have been sent ?
We used to be allowed to [at least] redistribute the content as an entry point
for entering in rpmfusion. If this agreement isn't available, we could also
allow macromedia flash to go in...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:20 a.m.
New subject: [Bug 794] Review-request: r5u87x-loader - R5U87x webcam firmware loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
--- Comment #8 from Hans de Goede <j.w.r.degoede(a)hhs.nl> 2009-09-01 09:20:12 ---
(In reply to comment #7)
(In reply to comment #3)
...
> What is non free here is that we have no License Document saying these firmware
> files are freely redistributable. We don't have anything saying the contrary
> either, so after discussing this with Pix (our ftpmaster if you want) and
> getting an ok from him, I've submitted this. But it is definitely not suitable
> for Fedora.
What have been done to known if theses firmware can be redistributed ?
Does a mail to any hardware vendor have been sent ?
Yes, no answer though.
We used to be allowed to [at least] redistribute the content as an
entry point
for entering in rpmfusion. If this agreement isn't available, we could also
allow macromedia flash to go in...
No, because it comes with a License which explicitly forbids this.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
2:46 p.m.
New subject: [Bug 794] Review-request: r5u87x-loader - R5U87x webcam firmware loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
Michel Alexandre Salim <Michael.Silvanus(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #9 from Michel Alexandre Salim <Michael.Silvanus(a)gmail.com> 2009-09-13
16:46:52 ---
Some tiny things to fix, and I'm not sure about the package name (see below),
after that, the package is ready to go.
MUST
• rpmlint
source: two warnings
r5u87x-loader.src: W: invalid-license Distributable
this is fine; that's why it's in RPMfusion anyway
r5u87x-loader.src: W: strange-permission r5u87x-loader-flip.patch 0600
harmless, but probably should be fixed anyway
binaries: license warnings, see above
r5u87x-loader.x86_64: W: invalid-license Distributable
r5u87x-loader-debuginfo.x86_64: W: invalid-license Distributable
? package name:
the package installs a binary called r5u87x-loader, but on the other hand,
most of the content is firmware files. Should probably be r5u87x-firmware,
in common with many other firmware packages
? spec file name
matches SRPM name; see above
OK package guideline-compliant
OK license complies with guidelines
for RPMfusion
? license field accurate
loader.{c,h} are GPLv2+, should probably be GPLv2+ and Distributable
NA license file not deleted -- no license file
OK spec in US English
OK spec legible
OK source matches upstream
note: filename is awkward, but unfortunately it bitbucket does not name the
file as '.tar.bz2'
OK builds under >= 1 archs, others excluded
tested on x86_64. Not using Fedora's Koji as it might be bad to have this
package on Fedora servers, even transiently
OK build dependencies complete
OK own all directories
(depends on udev for /lib/firmware)
OK no dupes in %files
OK permission
OK %clean RPM_BUILD_ROOT
OK macros used consistently
OK Package contains code
NA large docs => -doc
OK clean buildroot before install
OK filenames UTF-8
SHOULD
? if license text missing, ask upstream to include it
should probably get upstream to clarify licensing here
• package build in mock on all architectures
• package functioned as described
assuming Hans already tested this
OK scriplets are sane
no scriplets
OK require package not files
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
10:04 a.m.
New subject: [Bug 794] Review-request: r5u87x-firmware - R5U87x webcam firmware and loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
Hans de Goede <j.w.r.degoede(a)hhs.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Review-request: r5u87x- |Review-request: r5u87x-
|loader - R5U87x webcam |firmware - R5U87x webcam
|firmware loader |firmware and loader
--- Comment #10 from Hans de Goede <j.w.r.degoede(a)hhs.nl> 2010-01-27 11:04:57 ---
Hi,
Sorry for the long silence on this (too much other stuff to work on). And
unfortunately people.atrpms.net is no more so now I have no place to
host rpmfusion srpms for review (suggestions very welcome).
Anyways I'll attach an updated specfile and the one remaining patch, you
can get Source0 by using "spectool -g", which is how I downloaded it too.
This new version:
-Is updated to the latest upstream, meaning the vflip patch is dropped
and a COPYING file now is included
-Is renamed to r5u87x-firmware, as requested
This should solve all issues you found during your review.
Regards,
Hans
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
10:05 a.m.
New subject: [Bug 794] Review-request: r5u87x-firmware - R5U87x webcam firmware and loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
--- Comment #11 from Hans de Goede <j.w.r.degoede(a)hhs.nl> 2010-01-27 11:05:28 ---
Created an attachment (id=362)
--> (http://bugzilla.rpmfusion.org/attachment.cgi?id=362)
Updated spec file
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
10:05 a.m.
New subject: [Bug 794] Review-request: r5u87x-firmware - R5U87x webcam firmware and loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
--- Comment #12 from Hans de Goede <j.w.r.degoede(a)hhs.nl> 2010-01-27 11:05:48 ---
Created an attachment (id=363)
--> (http://bugzilla.rpmfusion.org/attachment.cgi?id=363)
The one patch file still needed for this package
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:22 a.m.
New subject: [Bug 794] Review-request: r5u87x-firmware - R5U87x webcam firmware and loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
--- Comment #13 from Hans de Goede <j.w.r.degoede(a)hhs.nl> 2010-06-18 09:22:44 ---
Here is an updated version which fixes the udev rules to work with the latest
udev releases:
Spec: http://jwrdegoede.danny.cz/r5u87x-firmware.spec
SRPM:
http://jwrdegoede.danny.cz/r5u87x-firmware-0.2.0-3.a9b2171d762b.fc11.src.rpm
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:13 p.m.
New subject: [Bug 794] Review-request: r5u87x-firmware - R5U87x webcam firmware and loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
--- Comment #14 from Michel Alexandre Salim <Michael.Silvanus(a)gmail.com> 2010-06-18
21:13:55 ---
Reviewing now. Couple of notes beforehand:
- could you persuade upstream to tag his releases? It's a bit hard to track
down -- the latest README says version "0.2.1", which after cloning the repo I
tracked down to revision 52
- I'll review the current SRPM. Any chance you could incorporate the
human-readable changeset number as well as the hash? 64.a9b2171d762b is easier
to read.
- And since revision 64 is after the README was bumped to 0.2.1, it's unclear
whether this is a 0.2.1 postrelease or prerelease. Again, would be nice if
upstream actually tags :(
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:24 p.m.
New subject: [Bug 794] Review-request: r5u87x-firmware - R5U87x webcam firmware and loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
Michel Alexandre Salim <Michael.Silvanus(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|2 |4
--- Comment #15 from Michel Alexandre Salim <Michael.Silvanus(a)gmail.com> 2010-06-18
21:24:01 ---
Apart from the version/release number concern, the package is good to go. I'll
let you sort it out with upstream -- no reason to delay this package.
APPROVED.
* DONE Review [100%]
** DONE Names [2/2]
*** DONE Package name
*** DONE Spec name
** DONE source files match upstream
** DONE License [2/2]
*** DONE License field accurate
*** DONE License included iff packaged by upstream
** DONE rpmlint [2/2]
*** DONE on src.rpm
$ rpmlint ./r5u87x-firmware-0.2.0-3.a9b2171d762b.fc11.src.rpm
r5u87x-firmware.src: W: spelling-error %description -l en_US chipsets -> chip
sets, chip-sets, chippers
r5u87x-firmware.src: W: spelling-error %description -l en_US uvcvideo ->
videodisc, videotex, videotape
r5u87x-firmware.src: W: spelling-error %description -l en_US udev -> udder,
rude, Devi
r5u87x-firmware.src: W: invalid-license Distributable
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
*** DONE on x86_64.rpm
$ rpmlint ~/Downloads/r5u87x-firmware-*
r5u87x-firmware.x86_64: W: spelling-error %description -l en_US chipsets ->
chip sets, chip-sets, chippers
r5u87x-firmware.x86_64: W: spelling-error %description -l en_US uvcvideo ->
videodisc, videotex, videotape
r5u87x-firmware.x86_64: W: spelling-error %description -l en_US udev -> udder,
rude, Devi
r5u87x-firmware.x86_64: W: invalid-license Distributable
r5u87x-firmware.x86_64: W: no-manual-page-for-binary r5u87x-loader
r5u87x-firmware-debuginfo.x86_64: W: invalid-license Distributable
2 packages and 0 specfiles checked; 0 errors, 6 warnings.
** DONE Language & locale [3/3]
*** DONE Spec in US English
*** DONE Spec legible
*** N/A Use %find_lang to handle locale files
** DONE Build [3/3]
*** DONE Koji results
http://koji.fedoraproject.org/koji/taskinfo?taskID=2258372
*** DONE BRs complete
*** DONE Directory ownership
** DONE Spec inspection [8/8]
*** N/A ldconfig for libraries
*** DONE No duplicate files
*** DONE File permissions
*** DONE Filenames must be UTF-8
*** DONE Has %clean section
(except F-13+:
https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean)
*** DONE %buildroot cleaned on %install
*** DONE Macro usage consistent
*** DONE Documentation [2/2]
**** N/A If large docs, separate -doc
**** DONE %doc files are non-essential
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:37 a.m.
New subject: [Bug 794] Review-request: r5u87x-firmware - R5U87x webcam firmware and loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
Hans de Goede <j.w.r.degoede(a)hhs.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33
--- Comment #16 from Hans de Goede <j.w.r.degoede(a)hhs.nl> 2010-06-22 09:37:23 ---
Thanks for the review. I'll mail upstream asking for a proper release
incorporating all the latest changes.
Package CVS request
======================
Package Name: r5u87x-firmware
Short Description: R5U87x webcam firmware and loader
Owners: jwrdegoede
Branches: F-12 F-13
InitialCC:
----------------------
License tag: nonfree
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
11:14 a.m.
New subject: [Bug 794] Review-request: r5u87x-firmware - R5U87x webcam firmware and loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
Ankur Sinha <sanjay.ankur(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sanjay.ankur(a)gmail.com
--- Comment #17 from Ankur Sinha <sanjay.ankur(a)gmail.com> 2010-06-27 13:14:10 ---
(In reply to comment #4)
Taking the review. Hans, I'm assuming you can verify that the
webcam works
using this firmware loader, since I cannot test functionality?
hi,
Tested:
Bus 001 Device 003: ID 05ca:1810 Ricoh Co., Ltd Pavilion Webcam [R5U870]
[Ankur@localhost ~]$ rpm -q r5u87x-firmware
r5u87x-firmware-0.2.0-3.a9b2171d762b.fc13.x86_64
Works.
regards,
Ankur
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
9:51 p.m.
New subject: [Bug 794] Review-request: r5u87x-firmware - R5U87x webcam firmware and loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
NicolasChauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|33 |
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:17 p.m.
New subject: [Bug 794] Review-request: r5u87x-firmware - R5U87x webcam firmware and loader
http://bugzilla.rpmfusion.org/show_bug.cgi?id=794
Hans de Goede <j.w.r.degoede(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #18 from Hans de Goede <j.w.r.degoede(a)gmail.com> 2010-07-16 21:17:08
---
Thanks!
Imported and build for F-14 - F-12, closing.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
5243
days inactive
5562
days old
rpmfusion-developers@lists.rpmfusion.org
20 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla