as of 0.051, bsnes is now GPL. This is not the only change, however. It also now requires an additional library [1] to support compressed ROM images. The problem is that this library seems (at the first glance) contain mostly duplicated code from rar, 7-zip and friends, albeit modified. I have no skills nor time to try patching it up to use system-wide libs, so I have no idea how to proceed. For now, I have requested the latest bsnes build not to be pushed to stable, but it is of course only temporary. I have attached a preliminary spec file, which gets the job done. The thing is whether we are willing to accept such a chunk of (at least partially) duplicated code to save the ability of bsnes to use compressed ROM images.

I only had a quick look, and the RAR code is the only problematic one, but it seems that RAR support can be disabled. Does the fact that the libsnesreader.so is dlopened and not linked to change anything here?

Also, unless somebody is willing to do the work to make this monster acceptable for a Review, we have two options: 1. keep updating the emulator regardless of the missing compressed ROM images support, or 2. stay at version 0.050 indefinitely I'd go with option 1, maybe including a note in the readme explaining why the support is missing and what can be done to help the situation. What do you guys think?

0.053 brought yet another code separation, libsnesfilter. Having said that, in the process of severely crippling snesfilter (only zlib support), I have managed to make it work with system zlib. Spec files and srpms are available on my fedorapeople page: http://belegdol.fedorapeople.org/snes/ Please have a look. Also, won't these be suitable for Fedora proper (after removing unrar code, of course)?

On Thu, Oct 22, 2009 at 9:23 AM, Andrea Musuruane <musuruan(a)gmail.com&gt; wrote: > On Wed, Oct 21, 2009 at 8:08 PM, Julian Sikorski <belegdol(a)gmail.com&gt; wrote: >> 0.053 brought yet another code separation, libsnesfilter. Having said >> that, in the process of severely crippling snesfilter (only zlib >> support), I have managed to make it work with system zlib. Spec files >> and srpms are available on my fedorapeople page: >> http://belegdol.fedorapeople.org/snes/ >> Please have a look. Also, won't these be suitable for Fedora proper >> (after removing unrar code, of course)? I had only a quick glance: * If you have to exclude unrar code because of licensing issue, you MUST repack the source: https://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Pro... * You should not patch the Makefile with the hard-coded value of $RPM_OPT_FLAGS. Your "sed -i "s#-O3#$RPM_OPT_FLAGS#"" is not applied because it is in conflict with your systemlib patch. * Your "sed -i "s/link := -s/#link := -s/" Makefile" is not applied because it is in conflict with your systemlib patch. * To be sure you do not use any file of the local libraries you should delete the related source in %prep; i.e. rm -rf zlib etc... HTH, Andrea.