http://bugzilla.rpmfusion.org/show_bug.cgi?id=1936 Xavier Bachelot <xavier(a)bachelot.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xavier(a)bachelot.org --- Comment #1 from Xavier Bachelot <xavier(a)bachelot.org&gt; 2011-09-14 17:33:56 --- There's already a review request opened for this package. One of the 2 probably needs to be closed as duplicate of the other. See http://bugzilla.rpmfusion.org/show_bug.cgi?id=746 -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1936 --- Comment #3 from Xavier Bachelot <xavier(a)bachelot.org&gt; 2011-09-14 18:01:26 --- Oops, sorry. Anyway, #746 might still contains useful information for this review. Sorry again for the noise. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1936 Richard <hobbes1069(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hobbes1069(a)gmail.com --- Comment #5 from Richard <hobbes1069(a)gmail.com&gt; 2011-09-26 15:46:52 --- Some suggestions: 1. You don't need "lives_version". Just put the version in the Version: field and you can use %{version} instead. 2. For your subpackages, I don't think you need things like "%{release}" in "Release:" if you just leave it out it will be the same release as the main package. 3. Don't use macros for common bash commands and utilities (rm, mv, make . It's not necessary and hurts readability. 4. If you're not building for EL 5, you can drop "rm -rf %{buildroot}" from %install, %defattr from %files, and "BuildRoot:" entirely. I see you already removed %clean.. You can probably also drop the static libraries unless you already have plans for something to use them that can't use the shared libraries. This is a quick 5 minute review so I don't have time to be thourogh, but I see in you %files you're using a lot of %dir and then grabbing the files under that dir on the next line. For example: %dir %{_appdatadir}/themes %{_appdatadir}/themes/* could just be: %{_appdatadir}/themes which will grab the directory and everything under it. Unless it causes a problem I think you could just do: %{_appdatadir} and then list any excludes under it (like the resources dir). Richard -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1936 --- Comment #7 from Nicolas Chauvet <kwizart(a)gmail.com&gt; 2011-09-26 20:04:17 --- As stated in https://bugzilla.rpmfusion.org/show_bug.cgi?id=746#c1 The libweed library need to be splitted off from the lives distribution. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1936 --- Comment #9 from Sérgio Basto <sergio(a)serjux.com&gt; 2011-09-26 20:53:59 --- (In reply to comment #7) but libweed is not in Fedora or else where . just found that "LIVES" is in ATrpms. http://packages.atrpms.net/dist/f15/lives/ -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1936 --- Comment #11 from Richard <hobbes1069(a)gmail.com&gt; 2011-09-26 22:47:57 --- Updating my previous comments: (In reply to comment #5) Never mind, I see that the subpackage with a different version overrides the main package version. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=1936 Richard <hobbes1069(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kwizart(a)gmail.com --- Comment #13 from Richard <hobbes1069(a)gmail.com&gt; 2011-10-06 19:33:58 --- I'm with Kevin on this one... Nicolas, Does Kevin's argument change your mind? Or is this review more or less dead? Thanks, Richard -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.