2:39 p.m.
Hi,
I was going to update ZSNES to explicitly requires pulseaudio-libs
(BZ #1926) and I found out that ZSNES doesn't compile with gcc 4.6.0
(F15+).
The buildlog is here (for devel):
http://buildsys.rpmfusion.org/logs/fedora-development-rpmfusion_free/1018...
The problem seems to be that _FORTIFY_SOURCE breaks parsegen:
https://bugs.launchpad.net/ubuntu/+source/zsnes/+bug/819774/comments/8
Ubuntu *fixed* this disabling _FORTIFY_SOURCE for parsegen. This is
not permitted in Fedora. Unluckily I don't have the necessary
knowledge to fix this myself.
Any help is appreciated.
Thanks,
Andrea.
5:40 p.m.
Hi,
On 09/04/2011 04:39 PM, Andrea Musuruane wrote:
Hi,
I was going to update ZSNES to explicitly requires pulseaudio-libs
(BZ #1926) and I found out that ZSNES doesn't compile with gcc 4.6.0
(F15+).
The buildlog is here (for devel):
http://buildsys.rpmfusion.org/logs/fedora-development-rpmfusion_free/1018...
The problem seems to be that _FORTIFY_SOURCE breaks parsegen:
https://bugs.launchpad.net/ubuntu/+source/zsnes/+bug/819774/comments/8
Ubuntu *fixed* this disabling _FORTIFY_SOURCE for parsegen. This is
not permitted in Fedora. Unluckily I don't have the necessary
knowledge to fix this myself.
Any help is appreciated.
Hmm, the problem is some auto-generated code, making this not easy and the
error is rather obscure too.
Attached is what I believe is an elegant solution, which only disables
FORTIFY_SOURCE for the auto-generated files. I believe it is even
suitable for sending upstream.
Regards,
Hans
11:01 p.m.
Hans de Goede wrote:
Hmm, the problem is some auto-generated code, making this not easy
and the
error is rather obscure too.
The error CLAIMS that the problem is that fprintf is being called indirectly
through some function pointer. However, I don't see parsegen.cpp generate
any code which would do that. I searched for "fprintf" and I found only
direct function calls.
It might be some GCC optimization making the calls indirect. (Try -fno-
function-cse maybe?)
Kevin Kofler
3:33 a.m.
On 09/04/2011 04:39 PM, Andrea Musuruane wrote:
Hi,
I was going to update ZSNES to explicitly requires pulseaudio-libs
(BZ #1926) and I found out that ZSNES doesn't compile with gcc 4.6.0
(F15+).
The buildlog is here (for devel):
http://buildsys.rpmfusion.org/logs/fedora-development-rpmfusion_free/1018...
The problem seems to be that _FORTIFY_SOURCE breaks parsegen:
https://bugs.launchpad.net/ubuntu/+source/zsnes/+bug/819774/comments/8
Ubuntu *fixed* this disabling _FORTIFY_SOURCE for parsegen. This is
not permitted in Fedora. Unluckily I don't have the necessary
knowledge to fix this myself.
Any help is appreciated.
From what I can gather, parsegen is choking upon
"-Wp,-D_FORTIFY_SOURCE" being passed as argument to it.
At least separating the call to the compiler from parsegen's code
generation seems to fix the issue.
c.f. patch below.
This lets parsegen generate *.h+*.c's and causes the *.c's to be
compiled by "normal compilation rules", instead of trying to compile
them "on the fly" through "parsegen".
Ralf
5:34 p.m.
On Mon, Sep 5, 2011 at 5:33 AM, Ralf Corsepius <rc040203(a)freenet.de> wrote:
From what I can gather, parsegen is choking upon
"-Wp,-D_FORTIFY_SOURCE"
being passed as argument to it.
At least separating the call to the compiler from parsegen's code generation
seems to fix the issue.
c.f. patch below.
This lets parsegen generate *.h+*.c's and causes the *.c's to be compiled by
"normal compilation rules", instead of trying to compile them "on the
fly"
through "parsegen".
I'm very late but I'm updating zsnes to use your patch instead of the
one made by Hans because it has the advantage to use standard Fedora
CFLAGS an no workarounds.
Thanks!
Andrea.
4814
days inactive
4828
days old
rpmfusion-developers@lists.rpmfusion.org
4 comments
4 participants
participants (4)
-
Andrea Musuruane -
Hans de Goede -
Kevin Kofler -
Ralf Corsepius