http://bugzilla.rpmfusion.org/show_bug.cgi?id=118
Hans de Goede <j.w.r.degoede(a)hhs.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #1 from Hans de Goede <j.w.r.degoede(a)hhs.nl> 2008-11-04 12:19:28 ---
Hi,
Some initial comments from looking over the spec. file:
%define _default_patch_fuzz 2
Fixing this isn't that hard and if don't fix it now we will be stuck with it
for a long long time, please fix (should fix).
# Needeed to regenerate old-style font.scale and then fonts.dir
#Requires: ttmkfdir, xorg-x11-font-utils
Please just nuke these 2 lines
# Warning: MMX is MMX32 only
# (produce an error on F-8 but only a warning on F-7 )
But you are enabling mmx for x86_64 now too, I think this comment is obsolete,
or?
%description
This is the Community maintained Version of cinelerra
Erm, this needs some work, when this is in comps we want to show something
better to the user.
%if 0
# rename the mpeg3 utils so they can be installed alongside native versions
( cd $RPM_BUILD_ROOT%{_bindir}
mv mpeg3toc mpeg3toc.hv
mv mpeg3cat mpeg3cat.hv
mv mpeg3dump mpeg3dump.hv
mv mplexlo mplexlo.hv
# from cinelerra-cvs-current.spec - but produce an error at run time
#ln -s ../../bin/mpeg2enc %{buildroot}%{_libdir}/cinelerra/mpeg2enc.plugin
)
%else
Maybe just nuke these lines? Even when we need to use the internal copy, I see
no reason for installing these.
# Remove uneeded fonts - you want them ?
# get msttcorefonts and regenerate fonts.dir instead
# (with packages ttmkfdir and xorg-x11-font-utils)
rm -rf %{buildroot}%{_datadir}/fonts/%{name}
Erm, I think this is meant to go into the free repo, right? Then we really
should remove the fonts from the source tarbal.
%pre
sed -i -e "/# Added by Cinelerra RPM from RPM Fusion/d"
%{_sysconfdir}/rc.local
sed -i -e "/kernel\/shmmax=0x7fffffff/d" %{_sysconfdir}/rc.local
??? I think this is old cruft, or ... ?
%if 0
%{_bindir}/mpeg3cat.hv
%{_bindir}/mpeg3dump.hv
%{_bindir}/mpeg3toc.hv
%{_bindir}/mplexlo.hv
%endif
Once again I think these lines might just as well be removed, but that is not a
blocker.
--
Configure bugmail:
http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.