1:45 p.m.
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2342
Bug #: 2342
Summary: Review Request: 0ad - Cross-Platform RTS Game of
Ancient Warfare
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: paulo.cesar.pereira.de.andrade(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
Spec URL: http://fedorapeople.org/~pcpa/0ad.spec
SRPM URL: http://fedorapeople.org/~pcpa/0ad-r11863-3.fc18.src.rpm
Description: 0 A.D. (pronounced "zero ey-dee") is a free, open-source,
cross-platform
real-time strategy (RTS) game of ancient warfare. In short, it is a
historically-based war/economy game that allows players to relive or rewrite
the history of Western civilizations, focusing on the years between 500 B.C.
and 500 A.D. The project is highly ambitious, involving state-of-the-art 3D
graphics, detailed artwork, sound, and a flexible and powerful custom-built
game engine.
The game has been in development by Wildfire Games (WFG), a group of volunteer,
hobbyist game developers, since 2001.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:51 p.m.
New subject: [Bug 2342] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2342
--- Comment #1 from pcpa <paulo.cesar.pereira.de.andrade(a)gmail.com> 2012-05-25
15:51:19 CEST ---
I made it as one of my initial requests for fedora, request at
https://bugzilla.redhat.com/show_bug.cgi?id=818401
but there is uncertainty about s3tc patent.
The srpm hosted in fedorapeople.org disables s3tc usage, but I am
not 100% certain it now does either only use argb textures or
pass textures uncompressed to the 3d graphics engine. Asked for
some details at http://trac.wildfiregames.com/ticket/1427
But I think nvtt support may be desirable; it is at least required
for the %check section of the spec.
I have a nvidia-textures-tools also as review request, currently
blocked in FE-LEGAL, that I can submit for review at rpmfusion,
if considered ok:
https://bugzilla.redhat.com/show_bug.cgi?id=823096
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:03 p.m.
New subject: [Bug 2342] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2342
Richard <hobbes1069(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hobbes1069(a)gmail.com
--- Comment #2 from Richard <hobbes1069(a)gmail.com> 2012-05-26 23:03:27 CEST ---
I tried building for F16 and it failed with the following error:
g++ -Iobj/engine_Release -include obj/engine_Release/precompiled.h -O2 -g -pipe
-Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -O2 -g -pipe -Wall -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -MMD -MP
-DNDEBUG -DCONFIG_FINAL=1 -DCONFIG2_NVTT=0 -DLIB_STATIC_LINK
-DINSTALLED_BINDIR= -DINSTALLED_DATADIR= -DINSTALLED_LIBDIR= -DUSING_PCH
-DWITH_SYSTEM_MOZJS185 -I/usr/X11R6/include/X11 -I/usr/X11R6/include
-I/usr/include/X11 -I../../../source/pch/engine -I../../../source -g -Wall -O3
-Wno-switch -Wno-reorder -Wno-invalid-offsetof -Wextra
-Wno-missing-field-initializers -Wunused-parameter -Wredundant-decls
-Wnon-virtual-dtor -Wundef -fstack-protector-all -D_FORTIFY_SOURCE=2
-fstrict-aliasing -fpch-preprocess -fno-omit-frame-pointer -msse
-fvisibility=hidden `pkg-config mozjs185 --cflags` `sdl-config --cflags`
`pkg-config libxml-2.0 --cflags` -MF obj/engine_Release/ProfileViewer.d -MT
"obj/engine_Release/ProfileViewer.o" -o
"obj/engine_Release/ProfileViewer.o" -c
"../../../source/ps/ProfileViewer.cpp"
../../../source/network/NetServer.cpp: In member function 'bool
CNetServerWorker::SetupConnection()':
../../../source/network/NetServer.cpp:168:67: error: too many arguments to
function 'ENetHost* enet_host_create(const ENetAddress*, size_t, enet_uint32,
enet_uint32)'
/usr/include/enet/enet.h:461:21: note: declared here
make[1]: *** [obj/network_Release/NetServer.o] Error 1
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:23 p.m.
New subject: [Bug 2342] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2342
--- Comment #3 from pcpa <paulo.cesar.pereira.de.andrade(a)gmail.com> 2012-05-26
23:23:11 CEST ---
(In reply to comment #2)
I tried building for F16 and it failed with the following error:
g++ -Iobj/engine_Release -include obj/engine_Release/precompiled.h -O2 -g -pipe
-Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m64 -mtune=generic -O2 -g -pipe -Wall -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -MMD -MP
-DNDEBUG -DCONFIG_FINAL=1 -DCONFIG2_NVTT=0 -DLIB_STATIC_LINK
-DINSTALLED_BINDIR= -DINSTALLED_DATADIR= -DINSTALLED_LIBDIR= -DUSING_PCH
-DWITH_SYSTEM_MOZJS185 -I/usr/X11R6/include/X11 -I/usr/X11R6/include
-I/usr/include/X11 -I../../../source/pch/engine -I../../../source -g -Wall -O3
-Wno-switch -Wno-reorder -Wno-invalid-offsetof -Wextra
-Wno-missing-field-initializers -Wunused-parameter -Wredundant-decls
-Wnon-virtual-dtor -Wundef -fstack-protector-all -D_FORTIFY_SOURCE=2
-fstrict-aliasing -fpch-preprocess -fno-omit-frame-pointer -msse
-fvisibility=hidden `pkg-config mozjs185 --cflags` `sdl-config --cflags`
`pkg-config libxml-2.0 --cflags` -MF obj/engine_Release/ProfileViewer.d -MT
"obj/engine_Release/ProfileViewer.o" -o
"obj/engine_Release/ProfileViewer.o" -c
"../../../source/ps/ProfileViewer.cpp"
../../../source/network/NetServer.cpp: In member function 'bool
CNetServerWorker::SetupConnection()':
../../../source/network/NetServer.cpp:168:67: error: too many arguments to
function 'ENetHost* enet_host_create(const ENetAddress*, size_t, enet_uint32,
enet_uint32)'
/usr/include/enet/enet.h:461:21: note: declared here
make[1]: *** [obj/network_Release/NetServer.o] Error 1
For fedora 16, it is required to use the bundled enet. You can
make a minor adaptation of the first spec I made, before having
a fedora account, in the first entry at
https://bugzilla.redhat.com/show_bug.cgi?id=818401
or the direct link :-)
http://kenobi.mandriva.com/~pcpa/0ad.spec
What is the proper way to check for what fedora version it
is being built? I can update the spec to automatically do
that, that is, adding back the "with_system_enet" macro,
that would be set to 0 if in fedora 16.
Probably responding myself, it is ok to add:
%if "%{dist}" == ".fc16"
if so, I can upload a new srpm.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:28 p.m.
New subject: [Bug 2342] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2342
--- Comment #4 from Richard <hobbes1069(a)gmail.com> 2012-05-26 23:28:13 CEST ---
(In reply to comment #3)
For fedora 16, it is required to use the bundled enet. You can
make a minor adaptation of the first spec I made, before having
a fedora account, in the first entry at
https://bugzilla.redhat.com/show_bug.cgi?id=818401
or the direct link :-)
http://kenobi.mandriva.com/~pcpa/0ad.spec
Is the version in F16 just too old?
What is the proper way to check for what fedora version it
is being built? I can update the spec to automatically do
that, that is, adding back the "with_system_enet" macro,
that would be set to 0 if in fedora 16.
Probably responding myself, it is ok to add:
%if "%{dist}" == ".fc16"
if so, I can upload a new srpm.
Nah, use the "fedora" macro. Either:
%if 0%{?fedora} >= 16
do something
%endif
or
%if 0%{?fedora} <= 15
do something
%endif
whichever is more appropriate. Just make sure the default/best/safest action is
done if "fedora" doesn't exist. The leading 0 makes sure it resolves to
something.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:39 p.m.
New subject: [Bug 2342] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2342
--- Comment #5 from pcpa <paulo.cesar.pereira.de.andrade(a)gmail.com> 2012-05-27
00:39:04 CEST ---
I update the spec to also make it easier to build with a
nvidia-texture-tools packages or with the bundled version.
Now it should build cleanly in fedora 16 and 17, as well
as rawhide (very likely will also build cleanly in fedora 15).
Spec URL: http://fedorapeople.org/~pcpa/0ad.spec
SRPM URL: http://fedorapeople.org/~pcpa/0ad-r11863-4.fc18.src.rpm
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:35 a.m.
New subject: [Bug 2342] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2342
--- Comment #6 from Richard <hobbes1069(a)gmail.com> 2012-05-30 03:35:31 CEST ---
I was able to build and play the game a little. It looks pretty nice! I'll see
if I can work in a review sometime soon.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:13 p.m.
New subject: [Bug 2342] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2342
--- Comment #7 from Michael Schwendt <mschwendt(a)gmail.com> 2012-06-01 15:13:38 CEST
---
missing "BuildRequires: enet-devel"
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:45 p.m.
New subject: [Bug 2342] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2342
--- Comment #8 from pcpa <paulo.cesar.pereira.de.andrade(a)gmail.com> 2012-06-01
15:45:02 CEST ---
(In reply to comment #7)
missing "BuildRequires: enet-devel"
Ah, I messed when refactorting the spec to build in fedora 16, 17
and rawhide. Used inverted logic in:
%if !%{with_system_enet}
BuildRequires: enet-devel
%endif
I will upload a newer package later today.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:41 a.m.
New subject: [Bug 2342] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2342
pcpa <paulo.cesar.pereira.de.andrade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |2347
--- Comment #9 from pcpa <paulo.cesar.pereira.de.andrade(a)gmail.com> 2012-06-02
04:41:04 CEST ---
Added depends on nvidia-textures-tools review request
as it is very desirable to build with system nvtt.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:42 a.m.
New subject: [Bug 2342] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2342
--- Comment #10 from pcpa <paulo.cesar.pereira.de.andrade(a)gmail.com> 2012-06-02
04:42:56 CEST ---
Updated package for proper build requires of enet-devel
and to actually remove %defattr, that was commented as
removed, but probably added back when refactoring the
spec to build in fedora 16 ... rawhide.
Spec URL: http://fedorapeople.org/~pcpa/0ad.spec
SRPM URL: http://fedorapeople.org/~pcpa/0ad-r11863-5.fc18.src.rpm
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:20 p.m.
New subject: [Bug 2342] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2342
Bug 2342 depends on bug 2347, which changed state.
Bug 2347 Summary: Review request: nvidia-texture-tools - Collection of image processing
and texture manipulation tools
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2347
What |Old Value |New Value
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |WONTFIX
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:02 a.m.
New subject: [Bug 2342] Review Request: 0ad - Cross-Platform RTS Game of Ancient Warfare
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2342
pcpa <paulo.cesar.pereira.de.andrade(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |MOVED
--- Comment #11 from pcpa <paulo.cesar.pereira.de.andrade(a)gmail.com> 2012-09-27
02:02:41 CEST ---
0ad was approved in fedora after removing nvtt, license audit, etc :-)
https://bugzilla.redhat.com/show_bug.cgi?id=818401
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4439
days inactive
4564
days old
rpmfusion-developers@lists.rpmfusion.org
12 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla