http://bugzilla.rpmfusion.org/show_bug.cgi?id=126 Yordanis Tornes Medina <ymedians(a)yahoo.es&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ymedians(a)yahoo.es --- Comment #2 from Yordanis Tornes Medina <ymedians(a)yahoo.es&gt; 2008-12-04 20:44:03 --- transcode-1.0.7-1.fc10 is in rpmfusion repo... -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=126 Marek Matulka <marek(a)matulka.net&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marek(a)matulka.net --- Comment #3 from Marek Matulka <marek(a)matulka.net&gt; 2008-12-05 00:55:04 --- compiles fine, builds fine, ogmtools are required for installation (got them from Fedora 9 freshrpms repo), though I am getting an error: Job 'Grab preview - title #2' failed with error message: Command exits with failure code: Command: mkdir -m 0775 /tmp/dvdrip30841.ppm; cd /tmp/dvdrip30841.ppm; execflow transcode -H 10 --print_status 25 -o snapshot -y ppm,null -x vob,null -i \/home\/marek\/Public\/dvdrip\-data\/lb\-s01\/vob\/002\/ -c 13-14 -L 222638 && execflow convert -size 720x576 /tmp/dvdrip30841.ppm/snapshot*.ppm /home/marek/Public/dvdrip-data/lb-s01/tmp/lb-s01-002-preview-orig.jpg && execflow convert -size 720x576 /tmp/dvdrip30841.ppm/snapshot*.ppm gray:/home/marek/Public/dvdrip-data/lb-s01/tmp/lb-s01-002-preview-orig.raw && rm -r /tmp/dvdrip30841.ppm && echo EXECFLOW_OK Output: transcode v1.0.7 (C) 2001-2003 Thomas Oestreich, 2003-2004 T. Bitterberg, 2004-2008 Transcode Team libdvdread: Using libdvdcss version 1.2.9 for DVD access libdvdread: Couldn't find device name. libdvdnav:DVDOpenFilePath:findDVDFile /VIDEO_TS/VIDEO_TS.IFO failed libdvdnav:DVDOpenFilePath:findDVDFile /VIDEO_TS/VIDEO_TS.BUP failed libdvdread: Can't open file VIDEO_TS.IFO. [import_null.so] v0.2.0 (2002-01-19) (video) null | (audio) null [import_vob.so] v0.6.0 (2003-10-02) (video) MPEG-2 | (audio) MPEG/AC3/PCM | (subtitle) [export_null.so] v0.1.2 (2001-08-17) (video) null | (audio) null [export_ppm.so] v0.1.1 (2002-02-14) (video) PPM/PGM | (audio) MPEG/AC3/PCM [decode_mpeg2.c] libmpeg2 acceleration: none (plain C)[decode_mpeg2.c] failed to write Y data of frame (len=0)(demuxer.c) write program stream packet: Broken pipe [transcode] (probe) suggested AV correction -D 0 (0 ms) | AV 0 ms | 0 ms [transcode] auto-probing source /home/marek/Public/dvdrip-data/lb-s01/vob/002/ (ok) [transcode] V: import format | MPEG-2 (V=vob|A=null) [transcode] V: AV demux/sync | (1) sync AV at initial MPEG sequence [transcode] V: import frame | 720x576 1.25:1 encoded @ 16:9 [transcode] V: bits/pixel | 0.174 [transcode] V: decoding fps,frc | 25.000,3 [transcode] V: Y'CbCr | YV12/I420 [transcode] A: import format | 0x2001 AC3/A52 [48000,16,2] 192 kbps [transcode] A: export | disabled [transcode] V: encoding fps,frc | 25.000,3 [transcode] A: bytes per frame | 7680 (7680.000000) [transcode] A: adjustment | 0@1000 [transcode] V: IA32/AMD64 accel | sse2 (sse2 sse mmxext mmx asm C) [transcode] V: IA32/AMD64 accel | using sse memcpy [transcode] V: video buffer | 10 @ 720x576 [import_vob.so] tccat -i "/home/marek/Public/dvdrip-data/lb-s01/vob/002/" -t vob -d 0 -S 222638 | tcdemux -s 0x80 -x mpeg2 -S 0 -M 1 -d 0 | tcextract -t vob -a 0 -x mpeg2 -d 0 | tcdecode -x mpeg2 -d 0 -y yv12 clean up | frame threads |sh: line 1: 30861 Segmentation fault execflow transcode -H 10 --print_status 25 -o snapshot -y ppm,null -x vob,null -i \/home\/marek\/Public\/dvdrip\-data\/lb\-s01\/vob\/002\/ -c 13-14 -L 222638 -------------------------------------------------------------------------------- -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=126 --- Comment #5 from Marek Matulka <marek(a)matulka.net&gt; 2008-12-05 08:56:05 --- hm... I can rip dvd (so I assume I have read permissions to /dev/cdrom) but it fails on generating preview images - without preview images I can't go any further. I've tried to delete all settings, I've created a new project, problem still exists. DVD playback works - either through dvdrip (using xine) or totem / vlc. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=126 Orcan Ogetbil <orcanbahri(a)yahoo.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |orcanbahri(a)yahoo.com Blocks|2 |3 AssignedTo|rpmfusion-package- |orcanbahri(a)yahoo.com |review(a)rpmfusion.org | --- Comment #7 from Orcan Ogetbil <orcanbahri(a)yahoo.com&gt; 2008-12-05 10:25:06 --- I finished the review. Here are my notes: * rpmlint says dvdrip.src:27: W: non-break-space line 27 dvdrip.src:41: W: non-break-space line 41 dvdrip.src:49: W: non-break-space line 49 dvdrip.x86_64: W: file-not-utf8 /usr/share/doc/dvdrip-0.98.9/Changes dvdrip.x86_64: W: file-not-utf8 /usr/share/doc/dvdrip-0.98.9/Credits dvdrip.x86_64: E: script-without-shebang /usr/lib/perl5/vendor_perl/5.10.0/Video/DVDRip/Cluster/Webserver.pm dvdrip.x86_64: W: file-not-utf8 /usr/share/doc/dvdrip-0.98.9/README dvdrip.x86_64: W: file-not-utf8 /usr/share/doc/dvdrip-0.98.9/COPYRIGHT dvdrip.x86_64: W: file-not-utf8 /usr/share/doc/dvdrip-0.98.9/TODO All of these can be fixed easily * Please package the Changes.0.46, lib/Video/DVDRip/license.txt and lib/Video/DVDRip/translators.txt files * Guidelines say that you need to add BR: gettext when dealing with locales: http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files There are binary .mo files inside the script. They need to be removed and rebuilt from .po files by gettext. ? You can also remove the perl-modules directory in %prep * You should make use of the %{name} macro extensively. * What is wrong with the parallel make? I'm asking for both C side and perl side. * These BR's seem unnecessary: BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(Gtk2) >= 1.081 BuildRequires: perl(Locale::TextDomain) >= 1.16 The first two are pulled up by other ones. The last one isn't used during the build, as far as I can tell. * All patches should be explained in the SPEC file (and submitted upstream if they are not Fedora-specific and links should be provided from their tracking system). The patch #2 uses a hard-coded link. Is that the best solution? * %define _default_patch_fuzz 2 Can't you just provide better patches to eliminate this? * Please make a %check section and run the test script. * The license field should be (GPL+ or Artistic) and CC-BY-SA 2.5 Please have a look at the COPYRIGHT file. Any reason you used GPLv2+ ? ? It would be quite useful for users to make the dependency detection script inside the software display Fedora RPM names for optional packages. for instance subtitle2pgm -> subtitleripper. But this is just an advice and not a blocker, as it needs some patching. I leave it up to you -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=126 --- Comment #8 from Marek Matulka <marek(a)matulka.net&gt; 2008-12-05 10:49:56 --- (In reply to comment #6) everything but rar is installed and I believe rar is not required to grab images (it is used to compress subtitle images, but I don't need subtitles). I've done test on my work computer and have exactly the same error - I can rip a Chapter or Title from DVD, but it fails to grab preview images. ImageMagic is installed, here is an Error Message from dvd::rip: Job 'Grab preview - title #1' failed with error message: Command exits with failure code: Command: mkdir -m 0775 /tmp/dvdrip5205.ppm; cd /tmp/dvdrip5205.ppm; execflow transcode -H 10 --print_status 25 -o snapshot -y ppm,null -x vob,null -i \/home\/marek\/Temporary\/dvdrip\-data\/city\-of\-angels\/vob\/001\/ -c 7-8 -L 1059594 && execflow convert -size 720x576 /tmp/dvdrip5205.ppm/snapshot*.ppm /home/marek/Temporary/dvdrip-data/city-of-angels/tmp/city-of-angels-001-preview-orig.jpg && execflow convert -size 720x576 /tmp/dvdrip5205.ppm/snapshot*.ppm gray:/home/marek/Temporary/dvdrip-data/city-of-angels/tmp/city-of-angels-001-preview-orig.raw && rm -r /tmp/dvdrip5205.ppm && echo EXECFLOW_OK Output: transcode v1.0.7 (C) 2001-2003 Thomas Oestreich, 2003-2004 T. Bitterberg, 2004-2008 Transcode Team libdvdread: Using libdvdcss version 1.2.9 for DVD access libdvdread: Couldn't find device name. libdvdnav:DVDOpenFilePath:findDVDFile /VIDEO_TS/VIDEO_TS.IFO failed libdvdnav:DVDOpenFilePath:findDVDFile /VIDEO_TS/VIDEO_TS.BUP failed libdvdread: Can't open file VIDEO_TS.IFO. [import_null.so] v0.2.0 (2002-01-19) (video) null | (audio) null [import_vob.so] v0.6.0 (2003-10-02) (video) MPEG-2 | (audio) MPEG/AC3/PCM | (subtitle) [export_null.so] v0.1.2 (2001-08-17) (video) null | (audio) null [export_ppm.so] v0.1.1 (2002-02-14) (video) PPM/PGM | (audio) MPEG/AC3/PCM [decode_mpeg2.c] libmpeg2 acceleration: none (plain C)[decode_mpeg2.c] failed to write Y data of frame (len=0)(demuxer.c) write program stream packet: Broken pipe [transcode] (probe) suggested AV correction -D 2 (80 ms) | AV 80 ms | 0 ms [transcode] auto-probing source /home/marek/Temporary/dvdrip-data/city-of-angels/vob/001/ (ok) [transcode] V: import format | MPEG-2 (V=vob|A=null) [transcode] V: AV demux/sync | (1) sync AV at initial MPEG sequence [transcode] V: import frame | 720x576 1.25:1 encoded @ 16:9 [transcode] V: bits/pixel | 0.174 [transcode] V: decoding fps,frc | 25.000,3 [transcode] V: Y'CbCr | YV12/I420 [transcode] A: import format | 0x2001 AC3/A52 [48000,16,2] 384 kbps [transcode] A: export | disabled [transcode] V: encoding fps,frc | 25.000,3 [transcode] A: bytes per frame | 7680 (7680.000000) [transcode] A: adjustment | 0@1000 [transcode] V: IA32/AMD64 accel | sse2 (sse2 sse mmxext mmx asm C) [transcode] V: IA32/AMD64 accel | using sse memcpy [transcode] V: video buffer | 10 @ 720x576 [import_vob.so] tccat -i "/home/marek/Temporary/dvdrip-data/city-of-angels/vob/001/" -t vob -d 0 -S 1059594 | tcdemux -s 0x80 -x mpeg2 -S 0 -M 1 -d 0 | tcextract -t vob -a 0 -x mpeg2 -d 0 | tcdecode -x mpeg2 -d 0 -y yv12 clean up | frame threads |sh: line 1: 5507 Segmentation fault execflow transcode -H 10 --print_status 25 -o snapshot -y ppm,null -x vob,null -i \/home\/marek\/Temporary\/dvdrip\-data\/city\-of\-angels\/vob\/001\/ -c 7-8 -L 1059594 -------------------------------------------------------------------------------- -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=126 --- Comment #10 from Marek Matulka <marek(a)matulka.net&gt; 2008-12-05 11:55:42 --- I am using transcode from this repo, don't know what execflow is. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=126 --- Comment #12 from Orcan Ogetbil <orcanbahri(a)yahoo.com&gt; 2008-12-05 18:41:56 --- I can confirm that I get a similar error message: ... encoding frames [000000-146525], 12.38 fps, EMT: 1:41:51, ( 8| 1| 0) encoding frames [000000-146550], 12.38 fps, EMT: 1:41:52, ( 8| 1| 0) encoding frames [000000-146575], 12.38 fps, EMT: 1:41:53, ( 8| 1| 0) encoding frames [000000-146600], 12.38 fps, EMT: 1:41:54, ( 8| 1| 0) [decode_mpeg2.c] failed to write Y data of frame (len=65536) clean up | frame threads |sh: line 1: 29110 Segmentation fault execflow -n 19 transcode -H 10 -a 0 -x vob -i \/home\/orcan\/dvdrip\-data\/unnamed\/vob\/001\/ -w 1748,50 -b 160,0,5 -s 1.478 --a52_drc_off -f 24,1 -M 2 -Y 4,0,4,0 -Z 640x360 -R 1 -y xvid,null -o /dev/null --print_status 25 -------------------------------------------------------------------------------- Fri Dec 5 05:10:45 2008 Job 'Transcode video - title #1, pass 1' finished But this is transcode related. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=126 --- Comment #14 from Orcan Ogetbil <orcanbahri(a)yahoo.com&gt; 2008-12-06 01:35:27 --- (In reply to comment #7) I consulted spot about the license. You can indicate it just as "CC-BY-SA". You don't need to put the version number. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=126 --- Comment #16 from NicolasChauvet <kwizart(a)gmail.com&gt; 2008-12-09 20:14:35 --- SRPM: http://rpms.kwizart.net/fedora/reviews/dvdrip/dvdrip-0.98.9-3.fc11.src.rpm SPEC: http://rpms.kwizart.net/fedora/reviews/dvdrip/dvdrip.spec Summary: Graphical DVD ripping and encoding tool based on transcode -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=126 --- Comment #18 from NicolasChauvet <kwizart(a)gmail.com&gt; 2008-12-10 13:10:40 --- (In reply to comment #17) I will re-use this, Thx for the improvements. The warning message have disappeared (jobserver unavailable) so I have re-introduced it. But it fails again at locale generation (randomly on my dualcore), so this isn't tread safe. if not added I will have: ----------- Warning: prerequisite AnyEvent 1.02 not found. Warning: prerequisite Event 1.06 not found. Warning: prerequisite Event::ExecFlow 0.62 not found. Warning: prerequisite Event::RPC 0.89 not found. Warning: prerequisite Gtk2 1.121 not found. Warning: prerequisite Gtk2::Ex::FormFactory 0.65 not found. Warning: prerequisite Locale::TextDomain 1.16 not found. ------------- and: ---------- Checking if your kit is complete... Warning: the following files are missing in your kit: perl-modules/AnyEvent-1.02.tar.gz perl-modules/Event-ExecFlow-0.63.tar.gz perl-modules/Event-RPC-0.90.tar.gz perl-modules/Gtk2-Ex-FormFactory-0.65.tar.gz Please inform the author. ---------- If I add the needed Dependencies, I only have the second message. I want to keep all mentioned dependencies as notified in the Makefile.PL (no matters of if they are already bring by another one) since it can allow to control the correct version at build time for each of them. (will be particularly needed for the EL-5 package, but also on update). Changelog - Update BuildRequirement as described in Makefile.PL - Fix Make test SRPM: http://rpms.kwizart.net/fedora/reviews/dvdrip/dvdrip-0.98.9-5.fc11.src.rpm SPEC: http://rpms.kwizart.net/fedora/reviews/dvdrip/dvdrip.spec -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=126 Orcan Ogetbil <orcanbahri(a)yahoo.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|3 |4 --- Comment #20 from Orcan Ogetbil <orcanbahri(a)yahoo.com&gt; 2008-12-11 18:32:22 --- We agreed to push this to testing ------------------------------------------------------------ This package (dvdrip) is APPROVED by oget for rpmfusion-free ------------------------------------------------------------ -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=126 Xavier Lamien <lxtnow(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|33 | --- Comment #22 from Xavier Lamien <lxtnow(a)gmail.com&gt; 2008-12-12 10:19:33 --- cvs branched. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

http://bugzilla.rpmfusion.org/show_bug.cgi?id=126 Thorsten Leemhuis <fedora(a)leemhuis.info&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4 -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.