https://bugzilla.rpmfusion.org/show_bug.cgi?id=118 --- Comment #52 from Antonio Trande <anto.trande(a)gmail.com&gt; 2016-01-15 14:47:56 CET --- Review file is very long, I'm leaving it as attached. Issues: ======= - Please, use V=1 option with 'make' - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros - /quicktime /guicast files are licensed with LGPLv2+ /greycstoration plugin is licensed with CeCILL Some files under /quicktime/ffmpeg are licensed with MIT Many files are relased with GPLv2+ license. I think License should report a multi-license: License: GPLv2+ and MIT and CeCILL and LGPLv2+ - 'cinelerra-cv-devel' requires 'cinelerra-cv': documentation and license files must be packaged in main package only. - Requires: %{name} = %{?epoch:%epoch:}%{version}-%{release} must be Requires: %{name}%{?_isa} = %{?epoch:%epoch:}%{version}-%{release} - Please, leave a comment to the patches - AutoTools: Obsoleted m4s found AC_PROG_LIBTOOL found in: cinelerra-cv-2.3/configure.ac:94 See https://fedorahosted.org/FedoraReview/wiki/AutoTools - Why are execstack commands not executed? - unused-direct-shlib-dependency warnings See https://fedoraproject.org/wiki/Common_Rpmlint_issues?rd=PackageMaintainer... - undefined-non-weak-symbol /usr/lib64/libguicast.so.1.0.0 Probably, needs a link to the libquicktimehv library - non-conffile-in-etc /etc/sysctl.d/cinelerra-cv.conf See https://fedoraproject.org/wiki/Common_Rpmlint_issues?rd=PackageMaintainer... - /usr/bin/update-desktop-database &>/dev/null || : are not necessary - %global __global_ldflags %(echo %{__global_ldflags} | sed 's/-specs=.*hardened-ld//' ) Why? Some minor issues - description-line-too-long errors - A lot of incorrect-fsf-address (work for upstream) - Some spurious-executable-perm warnings - Some macro-in-comment warnings -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.