https://bugzilla.rpmfusion.org/show_bug.cgi?id=2762 Hans de Goede <j.w.r.degoede(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.w.r.degoede(a)gmail.com --- Comment #1 from Hans de Goede <j.w.r.degoede(a)gmail.com&gt; 2013-04-15 09:08:44 CEST --- (In reply to comment #0) Are you already a sponsored Fedora packager? If so then you don't need to do anything special, an admin will do the necessary stuff when you file a CVS admin request after the review has been completed. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2762 --- Comment #3 from Hans de Goede <j.w.r.degoede(a)gmail.com&gt; 2013-05-04 23:29:44 CEST --- Hi, Want to swap reviews? This one for abuse, bug 2782. ? I'll also review warsow-data, I've some other games which I want to package soon too, so we can swap one of those for warsow-data. Deal ? Regards, Hans -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2762 Hans de Goede <j.w.r.degoede(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks|2 |3 AssignedTo|rpmfusion-package-review@rp |j.w.r.degoede(a)gmail.com |mfusion.org | --- Comment #5 from Hans de Goede <j.w.r.degoede(a)gmail.com&gt; 2013-05-05 21:12:22 CEST --- Full review done: Good: - rpmlint checks return: warsow.src:1: E: hardcoded-library-path in %{_prefix}/lib/warsow Thisc an be ignored because of the special nature of the libs - package meets naming guidelines - package meets packaging guidelines - license (GPLv2+) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file properly installed Needs work: - rpmlint checks return: warsow.x86_64: W: file-not-utf8 /usr/share/doc/warsow-1.02/license.txt - See: http://pkgs.fedoraproject.org/cgit/usbview.git/tree/usbview.spec for an example howto fix this warsow.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/warsow-1.02/OLD_player_models_guide.doc warsow.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/warsow-1.02/sourcecode_quickstart.txt warsow.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/warsow-1.02/license.txt -It seems most of the files under docs are not really useful for end-users, so I would only include license.txt in %doc -This warning can be fixed for license.txt like this: sed -i.bak 's/\r//' docs/license.txt touch -r docs/license.txt.bak docs/license.txr -COPYING (gpl text) not in %doc, please ask upstream to include it in future releases of the "sdk" -Does not own all dirs it creates, must add a "Requires: hicolor-icon-theme" for proper owner ship of the icon dirs -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2762 Hans de Goede <j.w.r.degoede(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|3 |4 --- Comment #7 from Hans de Goede <j.w.r.degoede(a)gmail.com&gt; 2013-05-06 12:09:06 CEST --- (In reply to comment #6) You're welcome It is the windows specific cp1252, you can convert it with: iconv -f WINDOWS-1252 -t UTF-8 I no longer see any blockers, so APPROVED! It would be nice if you could add the UTF-8 conversion, and please also keep the original timestamp on license.txt. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2762 Nicolas Chauvet <kwizart(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33 | -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2762 Kalev Lember <kalevlember(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |WONTFIX --- Comment #9 from Kalev Lember <kalevlember(a)gmail.com&gt; 2014-04-26 22:53:21 CEST --- Closing as WONTFIX since rpmfusion didn't have enough disk space for distributing warsow-data. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.