[Bug 1155] New: Review request: ffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers
9:07 a.m.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1155
Summary: Review request: ffmpegthumbnailer - Lightweight video
thumbnailer that can be used by file managers
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: magnus.tuominen(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
Blocks: 2
Estimated Hours: 0.0
http://magnu5.fedorapeople.org/review/ffmpegthumbnailer/SPEC/ffmpegthumbn...
http://magnu5.fedorapeople.org/review/ffmpegthumbnailer/SRPM/ffmpegthumbn...
description:
This video thumbnailer can be used to create thumbnails for your video files.
rpmlint output for binary:
ffmpegthumbnailer.x86_64: I: checking
ffmpegthumbnailer.x86_64: W: spelling-error Summary(en_US) thumbnailer ->
thumbnail er, thumbnail-er, thumbnail
The value of this tag appears to be misspelled. Please double-check.
ffmpegthumbnailer.x86_64: W: spelling-error %description -l en_US thumbnailer
-> thumbnail er, thumbnail-er, thumbnail
The value of this tag appears to be misspelled. Please double-check.
ffmpegthumbnailer.x86_64: I: checking-url
http://code.google.com/p/ffmpegthumbnailer/ (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Url is correct, spelling error not important.
----
rpmlint output on src.rpm:
ffmpegthumbnailer.src: I: checking
ffmpegthumbnailer.src: W: spelling-error Summary(en_US) thumbnailer ->
thumbnail er, thumbnail-er, thumbnail
The value of this tag appears to be misspelled. Please double-check.
ffmpegthumbnailer.src: W: spelling-error %description -l en_US thumbnailer ->
thumbnail er, thumbnail-er, thumbnail
The value of this tag appears to be misspelled. Please double-check.
ffmpegthumbnailer.src: I: checking-url
http://code.google.com/p/ffmpegthumbnailer/ (timeout 10 seconds)
ffmpegthumbnailer.src: I: checking-url
http://ffmpegthumbnailer.googlecode.com/files/ffmpegthumbnailer-2.0.0.tar.gz
(timeout 10 seconds)
ffmpegthumbnailer.src: W: invalid-url Source0:
http://ffmpegthumbnailer.googlecode.com/files/ffmpegthumbnailer-2.0.0.tar.gz
HTTP Error 404: Not Found
The value should be a valid, public HTTP, HTTPS, or FTP URL.
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Url is correct, spelling error not important.
-----
This is my first package on RPMFusion
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
12:43 a.m.
New subject: [Bug 1155] Review request: ffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1155
Rex Dieter <rdieter(a)math.unl.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rdieter(a)math.unl.edu
Blocks|2 |3
Status|NEW |ASSIGNED
--- Comment #1 from Rex Dieter <rdieter(a)math.unl.edu> 2010-04-12 02:43:01 ---
I can help review this (either tonight or tomorrow).
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
2:51 p.m.
New subject: [Bug 1155] Review request: ffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1155
Magnus Tuominen <magnus.tuominen(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |1157
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:01 p.m.
New subject: [Bug 1155] Review request: ffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1155
Rex Dieter <rdieter(a)math.unl.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|3 |4
--- Comment #2 from Rex Dieter <rdieter(a)math.unl.edu> 2010-04-12 18:01:49 ---
source confirmed,
md5sum *.gz
876bb0d57e218bfd76ca77b5abba813b ffmpegthumbnailer-2.0.0.tar.gz
1. SHOULD move %{_includedir}/libffmpegthumbnailer dir ownership to -devel pkg
2. SHOULD move
chmod -x README INSTALL COPYING AUTHORS
to %prep section (not %build)
3. SHOULD remove
%doc README INSTALL COPYING AUTHORS
from -devel, no need to duplicate this from the main pkg. While you're at it,
no need to %doc INSTALL at all really.
4. SHOULD checked the code, it all contains the "or later" clause, so can use
License: GPLv2+
scriptlets: ok
naming: ok
macros: ok, though you can drop
%{?_kde4_macros_api:Requires: kde4-macros(api) = %{_kde4_macros_api} }
none of the _kde4_* macros are used anywhere in this package that I can see.
5. SHOULD track lib sonames closer, currently %files contains,
%{_libdir}/*.so.*
and
%{_libdir}/*.so (-devel)
I'd suggest using
%{_libdir}/libffmpegthumbnailer.so.4*
%{_libdir}/libffmpegthumbnailer.so
respectively instead, to better highlight future ABI breaks.
I don't consider any of these SHOULD items review blockers, but please consider
addressing them before making any package releases.
APPROVED.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:46 p.m.
New subject: [Bug 1155] Review request: ffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1155
--- Comment #3 from Magnus Tuominen <magnus.tuominen(a)gmail.com> 2010-04-12 18:46:23
---
Thank you for your review, I have addressed the issues you mentioned.
http://magnu5.fedorapeople.org/review/ffmpegthumbnailer/SPEC/ffmpegthumbn...
rpmlint:
ffmpegthumbnailer.x86_64: I: checking
ffmpegthumbnailer.x86_64: W: spelling-error Summary(en_US) thumbnailer ->
thumbnail er, thumbnail-er, thumbnail
The value of this tag appears to be misspelled. Please double-check.
ffmpegthumbnailer.x86_64: W: spelling-error %description -l en_US thumbnailer
-> thumbnail er, thumbnail-er, thumbnail
The value of this tag appears to be misspelled. Please double-check.
ffmpegthumbnailer.x86_64: I: checking-url
http://code.google.com/p/ffmpegthumbnailer/ (timeout 10 seconds)
ffmpegthumbnailer-debuginfo.x86_64: I: checking
ffmpegthumbnailer-debuginfo.x86_64: I: checking-url
http://code.google.com/p/ffmpegthumbnailer/ (timeout 10 seconds)
ffmpegthumbnailer-devel.x86_64: I: checking
ffmpegthumbnailer-devel.x86_64: W: spelling-error %description -l en_US
thumbnailer -> thumbnail er, thumbnail-er, thumbnail
The value of this tag appears to be misspelled. Please double-check.
ffmpegthumbnailer-devel.x86_64: I: checking-url
http://code.google.com/p/ffmpegthumbnailer/ (timeout 10 seconds)
ffmpegthumbnailer-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:50 p.m.
New subject: [Bug 1155] Review request: ffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1155
--- Comment #4 from Rex Dieter <rdieter(a)math.unl.edu> 2010-04-12 18:50:45 ---
I just noticed this,
$ cat /usr/lib64/pkgconfig/libffmpegthumbnailer.pc
prefix=/usr
exec_prefix=/usr
libdir=/usr/lib64
includedir=/usr/include
Name: libffmpegthumbnailer
Description: Generates thumbnails for movie files
Version: 2.0.0
Libs: -L${libdir} -lffmpegthumbnailer
Cflags: -I${includedir}
This should be patched to be something like this instead:
Libs: -L${libdir} -lffmpegthumbnailer
Libs.private: -lavutil -lavformat -lavcodec -lswscale -lpng12 -ljpeg
Else, (mostly needless) dependencies will have to be added to -devel
Requires: ffmpeg-devel libpng-devel libjpeg-devel
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:36 a.m.
New subject: [Bug 1155] Review request: ffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1155
Magnus Tuominen <magnus.tuominen(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33
--- Comment #5 from Magnus Tuominen <magnus.tuominen(a)gmail.com> 2010-04-15 10:36:17
---
I have patched this build.
http://magnu5.fedorapeople.org/review/ffmpegthumbnailer/SPEC/ffmpegthumbn...
http://magnu5.fedorapeople.org/review/ffmpegthumbnailer/SRPM/ffmpegthumbn...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:39 a.m.
New subject: [Bug 1155] Review request: ffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1155
Magnus Tuominen <magnus.tuominen(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|33 |
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
9:22 a.m.
New subject: [Bug 1155] Review request: ffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1155
NicolasChauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kwizart(a)gmail.com
--- Comment #6 from NicolasChauvet <kwizart(a)gmail.com> 2010-04-15 11:22:56 ---
(In reply to comment #4)
I just noticed this,
...
Name: libffmpegthumbnailer
Description: Generates thumbnails for movie files
Version: 2.0.0
Libs: -L${libdir} -lffmpegthumbnailer
Cflags: -I${includedir}
This should be patched to be something like this instead:
Libs: -L${libdir} -lffmpegthumbnailer
Libs.private: -lavutil -lavformat -lavcodec -lswscale -lpng12 -ljpeg
Why would you like to hardcode Libs.private dependencies while we do not use
static linking ? That's pointless for us, but if one to make things right. You
need to use the @FFMPEG_LIBS@ flags that was actually used at compilation time.
(or to uses Requires.private: the_right_ffmpeg.pc , but this one will indeed
bring undeeded ffmpeg-devel CFLAGS in libffmpegthumbnailer_CFLAGS also when
using building shared).
Please ask upstream to review this change ASAP.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:15 p.m.
New subject: [Bug 1155] Review request: ffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1155
--- Comment #7 from Rex Dieter <rdieter(a)math.unl.edu> 2010-04-16 22:15:17 ---
The patch is just:
diff -up ffmpegthumbnailer-2.0.0/libffmpegthumbnailer.pc.in.libspatch
ffmpegthumbnailer-2.0.0/libffmpegthumbnailer.pc.in
--- ffmpegthumbnailer-2.0.0/libffmpegthumbnailer.pc.in.libspatch
2010-04-12 20:41:30.230052856 +0300
+++ ffmpegthumbnailer-2.0.0/libffmpegthumbnailer.pc.in 2010-04-12
20:47:57.000000000 +0300
@@ -6,5 +6,6 @@ includedir=@includedir@
Name: libffmpegthumbnailer
Description: Generates thumbnails for movie files
Version: @PACKAGE_VERSION@
-Libs: -L${libdir} -lffmpegthumbnailer @FFMPEG_LIBS@ @PNG_LIBS@ @JPEG_LIBS@
+Libs: -L${libdir} -lffmpegthumbnailer
+Libs.private: @FFMPEG_LIBS@ @PNG_LIBS@ @JPEG_LIBS@
Cflags: -I${includedir}
This is much better that without the patch.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:23 p.m.
New subject: [Bug 1155] Review request: ffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1155
Magnus Tuominen <magnus.tuominen(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33
--- Comment #8 from Magnus Tuominen <magnus.tuominen(a)gmail.com> 2010-04-16 22:23:28
---
Package CVS request
======================
Package Name: ffmpegthumbnailer
Short Description: Lightweight video thumbnailer
Owners: magnu5
Branches:F-12, devel
InitialCC:
----------------------
License tag: free
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
8:57 p.m.
New subject: [Bug 1155] Review request: ffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1155
Kevin Kofler <kevin.kofler(a)chello.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kevin.kofler(a)chello.at
--- Comment #9 from Kevin Kofler <kevin.kofler(a)chello.at> 2010-04-16 22:57:09 ---
5. SHOULD track lib sonames closer
FWIW, I disagree with this, I always use .so.* wildcards, it makes our job as a
packager much easier not to have to update the specfile for each soname bump.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:10 a.m.
New subject: [Bug 1155] Review request: ffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1155
leigh scott <leigh123linux(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |leigh123linux@fedoraproject.
| |org
--- Comment #10 from leigh scott <leigh123linux(a)fedoraproject.org> 2010-04-17
12:10:12 ---
(In reply to comment #8)
Package CVS request
======================
Package Name: ffmpegthumbnailer
Short Description: Lightweight video thumbnailer
Owners: magnu5
Branches:F-12, devel
InitialCC:
----------------------
License tag: free
You have forgotten to apply for the F-13 branch
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:19 a.m.
New subject: [Bug 1155] Review request: ffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1155
--- Comment #11 from Magnus Tuominen <magnus.tuominen(a)gmail.com> 2010-04-17
12:19:59 ---
(In reply to comment #7)
The patch is just:
diff -up ffmpegthumbnailer-2.0.0/libffmpegthumbnailer.pc.in.libspatch
ffmpegthumbnailer-2.0.0/libffmpegthumbnailer.pc.in
--- ffmpegthumbnailer-2.0.0/libffmpegthumbnailer.pc.in.libspatch
2010-04-12 20:41:30.230052856 +0300
+++ ffmpegthumbnailer-2.0.0/libffmpegthumbnailer.pc.in 2010-04-12
20:47:57.000000000 +0300
@@ -6,5 +6,6 @@ includedir=@includedir@
Name: libffmpegthumbnailer
Description: Generates thumbnails for movie files
Version: @PACKAGE_VERSION@
-Libs: -L${libdir} -lffmpegthumbnailer @FFMPEG_LIBS@ @PNG_LIBS@ @JPEG_LIBS@
+Libs: -L${libdir} -lffmpegthumbnailer
+Libs.private: @FFMPEG_LIBS@ @PNG_LIBS@ @JPEG_LIBS@
Cflags: -I${includedir}
This is much better that without the patch.
upstream agrees:
http://code.google.com/p/ffmpegthumbnailer/issues/detail?id=59&can=1
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
10:20 a.m.
New subject: [Bug 1155] Review request: ffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1155
--- Comment #12 from Magnus Tuominen <magnus.tuominen(a)gmail.com> 2010-04-17
12:20:26 ---
Package CVS request
======================
Package Name: ffmpegthumbnailer
Short Description: Lightweight video thumbnailer
Owners: magnu5
Branches:F-12, F-13, devel
InitialCC:
----------------------
License tag: free
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:26 p.m.
New subject: [Bug 1155] Review request: ffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1155
NicolasChauvet <kwizart(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|33 |
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6:31 p.m.
New subject: [Bug 1155] Review request: ffmpegthumbnailer - Lightweight video thumbnailer that can be used by file managers
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1155
Magnus Tuominen <magnus.tuominen(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #13 from Magnus Tuominen <magnus.tuominen(a)gmail.com> 2010-04-19
20:31:49 ---
Imported and built for F-12, F-13, devel branches.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
5383
days inactive
5391
days old
rpmfusion-developers@lists.rpmfusion.org
16 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla