1:25 p.m.
http://bugzilla.rpmfusion.org/show_bug.cgi?id=393
Summary: Package review - perl-IP-Country - Fast lookup of
country codes from IP addresses
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: andreas(a)bawue.net
CC: rpmfusion-package-review(a)rpmfusion.org
Estimated Hours: 0.0
http://home.bawue.de/~ixs/perl-IP-Country/perl-IP-Country.spec
http://home.bawue.de/~ixs/perl-IP-Country/perl-IP-Country-2.26-1.fc7.src.rpm
IP::Country allows fast lookups of IP addresses and their corresponding
countries based on available regional NIC data.
Although the country of assignment will probably be the country associated
with a large ISP rather than the client herself, this is probably good
enough for most log analysis applications, and under test has proved to be as
accurate as reverse-DNS and WHOIS lookup.
Cannot be in fedora as the database needed is not exactly free. RIPE, ARIN etc.
rules apply, thus it's destined to be in -nonfree
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:09 p.m.
New subject: [Bug 393] Package review - perl-IP-Country - Fast lookup of country codes from IP addresses
http://bugzilla.rpmfusion.org/show_bug.cgi?id=393
Paul Howarth <paul(a)city-fan.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |paul(a)city-fan.org
Blocks| |3
Alias| |perl-IP-Country
Status|NEW |ASSIGNED
--- Comment #1 from Paul Howarth <paul(a)city-fan.org> 2009-02-26 00:09:49 ---
A few initial comments:
* The %files section for the -utils subpackage needs a %defattr
* There are lots of "dot files" in the distribution that look to me to be
MacOS resource forks; I suspect they could be removed in %prep without any
detriment to the package.
* Is a separate -utils package really justified? It's substantially smaller
than the main package and only pulls in one more additional dependency
(perl-Geography-Countries) which itself is a small module.
Generally looks like a regular perl module package so it should be an easy
review.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:15 p.m.
New subject: [Bug 393] Package review - perl-IP-Country - Fast lookup of country codes from IP addresses
http://bugzilla.rpmfusion.org/show_bug.cgi?id=393
--- Comment #2 from Andreas Thienemann <andreas(a)bawue.net> 2009-02-26 00:15:19 ---
The util package contains the scripts necessary to generate a new database.
This is basically not needed for normal utilization which is why I put it into
a second package.
The mac stuff should be easyily deleted.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
11:30 p.m.
New subject: [Bug 393] Package review - perl-IP-Country - Fast lookup of country codes from IP addresses
http://bugzilla.rpmfusion.org/show_bug.cgi?id=393
--- Comment #3 from Paul Howarth <paul(a)city-fan.org> 2009-02-26 00:30:39 ---
(In reply to comment #2)
The util package contains the scripts necessary to generate a new
database.
This is basically not needed for normal utilization which is why I put it into
a second package.
I appreciate that but wonder if it's really worth it? What would be the
expectation of someone installing the main package? Usually perl modules are
only split into subpackages along the module boundaries, e.g. perl-Net-DNS and
perl-Net-DNS-Resolver, where the latter subpackage provides
perl(Net::DNS::Resolver), which pulls in significantly more dependencies than
the main package.
It's not a blocker though, so it's up to you.
Do a package with the dot files removed and I'll do a full review.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:55 p.m.
New subject: [Bug 393] Package review - perl-IP-Country - Fast lookup of country codes from IP addresses
http://bugzilla.rpmfusion.org/show_bug.cgi?id=393
--- Comment #4 from Paul Howarth <paul(a)city-fan.org> 2009-04-23 15:55:48 ---
Ping?
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
4:08 p.m.
New subject: [Bug 393] Package review - perl-IP-Country - Fast lookup of country codes from IP addresses
http://bugzilla.rpmfusion.org/show_bug.cgi?id=393
--- Comment #5 from Andreas Thienemann <andreas(a)bawue.net> 2009-04-25 18:08:13 ---
(In reply to comment #4)
Ping?
Thanks for the ping. Forgot about that.
http://home.bawue.de/~ixs/perl-IP-Country/perl-IP-Country-2.26-2.fc7.src.rpm
and http://home.bawue.de/~ixs/perl-IP-Country/perl-IP-Country.spec are updated
according to your suggestions.
About the package split: The usecase for the package is to enable country
lookup for spamassassin as an additional feature. Most people will never use it
for manual lookups or even rebuilding the database. Thus I considered the split
as I remember it being done for some other perl packages in (then) Core.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:26 p.m.
New subject: [Bug 393] Package review - perl-IP-Country - Fast lookup of country codes from IP addresses
http://bugzilla.rpmfusion.org/show_bug.cgi?id=393
Paul Howarth <paul(a)city-fan.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|3 |4
AssignedTo|rpmfusion-package- |paul(a)city-fan.org
|review(a)rpmfusion.org |
Status|ASSIGNED |NEW
--- Comment #6 from Paul Howarth <paul(a)city-fan.org> 2009-05-06 15:26:34 ---
rpmlint output:
perl-IP-Country.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line
26)
perl-IP-Country-utils.noarch: W: spurious-executable-perm
/usr/share/doc/perl-IP-Country-utils-2.26/dbmScripts/whois_filenames
perl-IP-Country-utils.noarch: W: doc-file-dependency
/usr/share/doc/perl-IP-Country-utils-2.26/dbmScripts/whois_filenames /bin/bash
3 packages and 0 specfiles checked; 0 errors, 3 warnings.
review items:
- rpmlint not clean; mixed-use-of-spaces-and-tabs is easy fix, other
complaints can be ignored as it's reasonable to ship executable
documentation and an additional dependency on /bin/bash is nothing to
worry about
- package and spec file names are fine
- package meets packaging guidelines
- license is OK (same as perl), upstream matches package
- no distributed detached license file to include
- spec file written in English and is legible
- source tarball matches upstream for content and timestamp
- package builds successfully in mock for rawhide.x86_64
- buildreqs fine
- no locale data, shared or static libraries, devel files to worry about
- package not intended to be relocatable
- directory ownership is fine
- no duplicate files
- no permissions problems, %defattr present and correct
- %clean section present and correct
- %install section cleans buildroot properly too
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- not a GUI app, no desktop file needed
- no filename encoding problems
- package appears to function correctly
- no scriptlets
- subpackage dependency is fine
- only file dependencies are /bin/bash and /usr/bin/perl (OK)
TODO:
Fix spec to use spaces or tabs but not both, as per rpmlint complaint.
Feel free to do this after import.
I APPROVE perl-IP-Country-2.26-2
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
1:32 p.m.
New subject: [Bug 393] Package review - perl-IP-Country - Fast lookup of country codes from IP addresses
http://bugzilla.rpmfusion.org/show_bug.cgi?id=393
--- Comment #7 from Andreas Thienemann <andreas(a)bawue.net> 2009-05-06 15:32:35 ---
Thank you for the review, I'll do that pre import.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
1:36 p.m.
New subject: [Bug 393] Package review - perl-IP-Country - Fast lookup of country codes from IP addresses
http://bugzilla.rpmfusion.org/show_bug.cgi?id=393
Andreas Thienemann <andreas(a)bawue.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33
--- Comment #8 from Andreas Thienemann <andreas(a)bawue.net> 2009-05-06 15:36:17 ---
Package CVS request
======================
Package Name: perl-IP-Country
Short Description: Fast lookup of country codes from IP addresses
Owners: ixs
Branches: EL-5, F10
InitialCC:
----------------------
License tag: nonfree
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
1:38 p.m.
New subject: [Bug 393] Package review - perl-IP-Country - Fast lookup of country codes from IP addresses
http://bugzilla.rpmfusion.org/show_bug.cgi?id=393
Thorsten Leemhuis <fedora(a)leemhuis.info> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|33 |
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
2:06 p.m.
New subject: [Bug 393] Package review - perl-IP-Country - Fast lookup of country codes from IP addresses
http://bugzilla.rpmfusion.org/show_bug.cgi?id=393
Andreas Thienemann <andreas(a)bawue.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
5684
days inactive
5760
days old
rpmfusion-developers@lists.rpmfusion.org
10 comments
1 participants
participants (1)
-
RPM Fusion Bugzilla