https://bugzilla.rpmfusion.org/show_bug.cgi?id=1034 Richard <hobbes1069(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks|30 | AssignedTo|rpmfusion-package-review@rp |hobbes1069(a)gmail.com |mfusion.org | --- Comment #12 from Richard <hobbes1069(a)gmail.com&gt; 2012-01-10 19:34:25 CET --- Ok, first pass spec review: 1. The following sections or entries are no longer needed and can be removed from the spec: - Python sitelib macro (only needed for Fedora < 13, RHEL < 6) at the top of the spec. - BuildRoot: tag - "rm -rf $RPM_BUILD_ROOT" in %install - %clean entirely - "%defattr(-,root,root,-)" in %files 2. There's no hard rule for this, but as a matter of good practices, I usually reserve using "%exclude" to make sure files don't get globbed by one %files section when I want to put them in another. In this case, you're not including them in another sub-package so I would just: rm -f $RPM_BUILD_ROOT%{_datadir}/sinthgunt/README.txt \ $RPM_BUILD_ROOT%{_datadir}/sinthgunt/LICENSE.txt in %install instead. This way there are no unpackaged files in $RPM_BUILD_ROOT, excluded or otherwise. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.