January 2012 - rpmfusion-developers

by "Jóhann B. Guðmundsson"

Note that the latest Linux kernel ( 3.2 ) has a few ABI changes, most notably in the network stack [1] which affects the Broadcom's wl module and it will fail to build with "error: unknown field 'ndo_set_multicast_list' specified in initializer". "ndo_set_multicast_list" has been replaced with "ndo_set_rx_mode." Attached is a patched that fixes this issue with the broadcom driver which needs to be included in those packages. Tested against upstream source [2]. JBG 1. http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit... 2. http://www.broadcom.com/support/802.11/linux_sta.php /**//**/

12 years, 11 months

3
6
0 / 0

[Bug 1034] Review request: sinthgunt - An easy to use GUI for ffmpeg

by RPM Fusion Bugzilla

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1034 --- Comment #16 from Richard <hobbes1069(a)gmail.com> 2012-01-11 16:01:51 CET --- (In reply to comment #15) > Thanks for the comment. I will try to solve these as soon as I can (mostly, by > the end of the week). > > If you can point me to a guideline on what should we do for the icons. Do we > provide a new one that is square, do we use the one that upstream provide even > if it's not good, etc? It would help as it is the first time that this problem > happen to a package I own. Ok, here's the (convoluted) short version :) The packaging guidelines say we need to adhere to freedesktop's Desktop Entry Specification[1] which in turn says we have to follow the Icon Theme Specification[2], which says we should supply a 48x48 icon as a minimum[3]. [1] http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files [2] http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-la... [3] http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.h... Ok, now what to do about it? There's no absolute requirement that I know of that an icon be "square", but if you look in /usr/share/icons/hicolor you'll see that all (or the vast majority) of the directories indicate a 1:1 ratio. If upstream is at all active, I would petition them for a 48x48 icon and a scalable icon. If you have the scalable, then you can create your own 48x48 (either statically and include it as a Source: or on the fly during package building using mogify from ImageMagick). Ok, having actually looked at the images now... The icon is just one rampant horse while the logo is two with a film reel in between. I think this makes a much better icon but we still need to get it in a usable resolution. I'm not a graphic artist but it's pretty easy to increase the height since the background is white to square it up to 128x128. Then we can make a scaled version in 48x48. I would install both. If you can manage that I'd send it upstream for inclusion. If not, I'll see what I can do but I'm not sure when I can get to it. Another fix that's needed is that the Icon tag in the desktop file uses the extension of the icon. There's only two options: 1. Use absolute path to the icon file (including the extension) 2. Use just the basename of the icon file and let the DM figure out the extension (preferred). So the Icon tag in the desktop file would just be: Icon=sinthgunt Ok, last issue. Because this package will not own the directory the icon goes into, per the guidelines (another convoluted issue) we muse Require: the package that does own the directory, in this case "hicolor-icon-theme". Since this is a side effect and not an explicit requirement, not everyone knows about this so it would be good to add a comment above it like: # We must require the package that owns the directories where the icon file is being installed. Require: hicolor-icon-theme OK! I think that's it for now! :) Just remember we need to push upstream to accept these changes as much as possible. That will make your job MUCH easier in the future. Richard -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

12 years, 11 months

1
0
0 / 0

[Bug 1034] Review request: sinthgunt - An easy to use GUI for ffmpeg

by RPM Fusion Bugzilla

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1034 --- Comment #15 from Jean-Francois Saucier <jsaucier(a)gmail.com> 2012-01-11 14:46:06 CET --- Thanks for the comment. I will try to solve these as soon as I can (mostly, by the end of the week). If you can point me to a guideline on what should we do for the icons. Do we provide a new one that is square, do we use the one that upstream provide even if it's not good, etc? It would help as it is the first time that this problem happen to a package I own. Thank you! -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

12 years, 11 months

1
0
0 / 0

[Bug 1034] Review request: sinthgunt - An easy to use GUI for ffmpeg

by RPM Fusion Bugzilla

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1034 --- Comment #14 from Richard <hobbes1069(a)gmail.com> 2012-01-10 23:14:47 CET --- I was looking at the files in the package and had some observations: $ rpm -qlp sinthgunt-2.0.3-2.fc16.noarch.rpm /usr/bin/sinthgunt /usr/bin/youtube-dl-sinthgunt /usr/lib/python2.7/site-packages/Sinthgunt /usr/lib/python2.7/site-packages/Sinthgunt/__init__.py /usr/lib/python2.7/site-packages/Sinthgunt/__init__.pyc /usr/lib/python2.7/site-packages/Sinthgunt/__init__.pyo /usr/lib/python2.7/site-packages/Sinthgunt/app.py /usr/lib/python2.7/site-packages/Sinthgunt/app.pyc /usr/lib/python2.7/site-packages/Sinthgunt/app.pyo /usr/lib/python2.7/site-packages/sinthgunt-2.0.3-py2.7.egg-info /usr/share/applications/sinthgunt.desktop /usr/share/doc/sinthgunt-2.0.3 /usr/share/doc/sinthgunt-2.0.3/LICENSE.txt /usr/share/doc/sinthgunt-2.0.3/README.txt /usr/share/pixmaps/sinthgunt.png /usr/share/sinthgunt /usr/share/sinthgunt/icon.png /usr/share/sinthgunt/logo.png /usr/share/sinthgunt/presets.xml /usr/share/sinthgunt/sinthgunt.glade /usr/share/sinthgunt/sinthgunt.html Putting icons in /usr/share/pixmaps is pretty much depreciated but not forbidden. It would be better to put them in the appropriate /usr/share/icons/ location. I also noticed that there's sinthgunt.pnd which is identical to logo.png, that's probably because the logo is used in the html file. Also, sinthgunt is not square: $ file pixmaps/sinthgunt.png pixmaps/sinthgunt.png: PNG image data, 128 x 93, 8-bit/color RGBA, non-interlaced but icon.png is: $ file sinthgunt/icon.png sinthgunt/icon.png: PNG image data, 24 x 24, 8-bit/color RGBA, non-interlaced BUT it's only 24x24 and the Fedora guidelines indirectly require at least a 48x48 icon. Ick. I did all this remotely so I'm not sure what the image files even look like. I'll take a look at that and possible solutions tonight at home. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

12 years, 11 months

1
0
0 / 0

Re: kmods on rawhide

by Ken Dreyer

On Mon, Jan 2, 2012 at 11:59 PM, Thorsten Leemhuis <Thorsten_Leemhuis(a)gmx.de> wrote: > Ken Dreyer wrote on 02.01.2012 21:19: >> I'm guessing that the buildsys-build-rpmfusion package only gets rev'd >> for kernels in Fedora releases, and not for Rawhide kernels? > > That's how it always has been done. But someone simply needs to do a > diff like this and your problem should vanish, as kmodtool then should > pick up the latest kernel that is available: > > http://cvs.rpmfusion.org/viewvc/rpms/buildsys-build-rpmfusion/devel/build... > > Doing that in the RPM Fusion buildsys bears the risk that different > builders or builds see different latest kernels. Thanks Nicolas for updating buildsys-build-rpmfusion-17-0.1 to this setting. - Ken

12 years, 11 months

1
0
0 / 0

[Bug 1034] Review request: sinthgunt - An easy to use GUI for ffmpeg

by RPM Fusion Bugzilla

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1034 --- Comment #13 from Jean-Francois Saucier <jsaucier(a)gmail.com> 2012-01-10 19:50:38 CET --- Spec URL: http://djj-consultants.com/rpms/sinthgunt.spec SRPM URL: http://djj-consultants.com/rpms/sinthgunt-2.0.3-2.fc16.src.rpm Thank you for your review. I have addressed both of your points in this new version. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

12 years, 11 months

1
0
0 / 0

[Bug 30] Tracker : Sponsorship Request

by RPM Fusion Bugzilla

https://bugzilla.rpmfusion.org/show_bug.cgi?id=30 Richard <hobbes1069(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|1034 | -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.

12 years, 11 months

1
0
0 / 0

[Bug 1034] Review request: sinthgunt - An easy to use GUI for ffmpeg

by RPM Fusion Bugzilla

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1034 Richard <hobbes1069(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks|30 | AssignedTo|rpmfusion-package-review@rp |hobbes1069(a)gmail.com |mfusion.org | --- Comment #12 from Richard <hobbes1069(a)gmail.com> 2012-01-10 19:34:25 CET --- Ok, first pass spec review: 1. The following sections or entries are no longer needed and can be removed from the spec: - Python sitelib macro (only needed for Fedora < 13, RHEL < 6) at the top of the spec. - BuildRoot: tag - "rm -rf $RPM_BUILD_ROOT" in %install - %clean entirely - "%defattr(-,root,root,-)" in %files 2. There's no hard rule for this, but as a matter of good practices, I usually reserve using "%exclude" to make sure files don't get globbed by one %files section when I want to put them in another. In this case, you're not including them in another sub-package so I would just: rm -f $RPM_BUILD_ROOT%{_datadir}/sinthgunt/README.txt \ $RPM_BUILD_ROOT%{_datadir}/sinthgunt/LICENSE.txt in %install instead. This way there are no unpackaged files in $RPM_BUILD_ROOT, excluded or otherwise. -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

12 years, 11 months

1
0
0 / 0

Request to become a contributor for rpmfusion

by Jean-Francois Saucier

Hi everyone, As noted in my review request ( https://bugzilla.rpmfusion.org/show_bug.cgi?id=1034#c10 ), I am already a Fedora contributor and I would like to add this package to rpmfusion when the review get OK. Also, I would like to take ownership of lastfm that was orphaned in F-16. When I am cleared as a contributor, I will do the "Package Change Request" procedure. I already have my rpmfusion account and I am subscribed to the relevant mailing list. Do I need to complete other tasks for this? Thanks a lot! -- Jean-Francois Saucier (djf_jeff) GPG key : 0xA9E6E953

12 years, 11 months

1
0
0 / 0

[Bug 1034] Review request: sinthgunt - An easy to use GUI for ffmpeg

by RPM Fusion Bugzilla

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1034 --- Comment #11 from Jean-Francois Saucier <jsaucier(a)gmail.com> 2012-01-10 19:01:41 CET --- Spec URL: http://djj-consultants.com/rpms/sinthgunt.spec SRPM URL: http://djj-consultants.com/rpms/sinthgunt-2.0.3-1.fc16.src.rpm Yes, I am still interested in this package. I uploaded a new build for F16 with the same old spec file since there is no new version. I will post on the devel list as well. Thank you! -- Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.

12 years, 11 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

rpmfusion-developers January 2012