[Bug 4216] Review request: mp3diags - Find and fix Problems in MP3 Files
by RPM Fusion Bugzilla
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4216
MartinKG <mgansser(a)alice.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |33
--- Comment #3 from MartinKG <mgansser(a)alice.de> ---
@Sergio thanks for the review.
> issues just "These BR are not needed: make gcc-c++"
I will change the BR in the spec file.
Package CVS request
======================
Package Name: mp3diags
Short Description: Find and fix Problems in MP3 Files
Owners: martinkg
Branches: f24 f25 rawhide
InitialCC:
----------------------
License tag: free
--
You are receiving this mail because:
You are on the CC list for the bug.
8 years, 1 month
you are missing rfpkg new-sources fdkaac-0.6.3.tar.gz command Re: [fdkaac] Initial push
by Sérgio Basto
Hi, Christopher
looking at koji logs [1] , seems to me that you haven't upload the
sources ... , i.e. , you need do something like:
rfpkg new-sources fdkaac-0.6.3.tar.gz
git commit .
git push
and just after that
rfpkg build
Thank you ,
[1]
DEBUG util.py:495: Executing command: ['rfpkg-minimal', 'sources']
with env {'HOSTNAME': 'mock', 'TERM': 'vt100', 'PROMPT_COMMAND':
'printf "\x1b]0;<mock-chroot>\x07<mock-chroot>"', 'http_proxy': 'http:/
/proxy:3128', 'LANG': 'en_US.UTF-8', 'HOME': '/builddir', 'SHELL':
'/bin/bash', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin'} and shell False
DEBUG util.py:283: Unsharing. Flags: 134217728
DEBUG util.py:417: % Total % Received % Xferd Average
Speed Time Time Time Current
DEBUG
util.py:417: Dload Upload Total
Spent Left Speed
DEBUG util.py:417:
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-
- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-
- 0
DEBUG util.py:417: curl: (22) The requested URL returned error: 404
Not Found
DEBUG util.py:417: % Total % Received % Xferd Average
Speed Time Time Time Current
DEBUG
util.py:417: Dload Upload Total
Spent Left Speed
DEBUG util.py:417:
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-
- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-
- 0
DEBUG util.py:417: curl: (22) The requested URL returned error: 404
Not Found
DEBUG util.py:417: Error: download of fdkaac-0.6.3.tar.gz failed.
On Qua, 2016-10-12 at 01:17 +0200, Christopher Atherton wrote:
> commit 9b183c5dabe50a3dc1fb080d0f6c0a9f993913c1
> Author: Christopher Atherton <the8lack8ox(a)gmail.com>
> Date: Tue Oct 11 19:17:13 2016 -0400
>
> Initial push
>
> .gitignore | 1 +
> fdkaac.spec | 61
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> sources | 1 +
> 3 files changed, 63 insertions(+)
> ---
> diff --git a/.gitignore b/.gitignore
> index e69de29..35b6678 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -0,0 +1 @@
> +/fdkaac-0.6.3.tar.gz
> diff --git a/fdkaac.spec b/fdkaac.spec
> new file mode 100644
> index 0000000..6e2eb33
> --- /dev/null
> +++ b/fdkaac.spec
> @@ -0,0 +1,61 @@
> +Name: fdkaac
> +Version: 0.6.3
> +Release: 3%{?dist}
> +Summary: Command line frontend for libfdk-aac encoder
> +
> +License: zlib
> +URL: https://github.com/nu774/%{name}
> +Source: https://github.com/nu774/%{name}/archive/v%{version}
> .tar.gz#/%{name}-%{version}.tar.gz
> +
> +BuildRequires: autoconf automake
> +BuildRequires: fdk-aac-devel
> +
> +
> +%description
> +fdkaac reads linear PCM audio in either WAV, raw PCM, or CAF format,
> +and encodes it into either M4A / AAC file.
> +
> +If the input file is "-", data is read from stdin. Likewise, if the
> +output file is "-", data is written to stdout if one of streamable
> AAC
> +transport formats are selected by -f.
> +
> +When CAF input and M4A output is used, tags in CAF file are copied
> into
> +the resulting M4A.
> +
> +
> +%prep
> +%autosetup
> +
> +
> +%build
> +autoreconf -fiv
> +%configure
> +%make_build
> +
> +%install
> +%make_install
> +
> +
> +%files
> +%license COPYING
> +%doc README ChangeLog
> +%{_bindir}/fdkaac
> +%{_mandir}/man1/*
> +
> +
> +%changelog
> +* Fri Sep 16 2016 Christopher Atherton <the8lack8ox(a)gmail.com> -
> 0.6.3-3
> +- Add BuildRequires autoconf automake
> +
> +* Fri Sep 16 2016 Christopher Atherton <the8lack8ox(a)gmail.com> -
> 0.6.3-2
> +- Spec file cleanup
> +
> +* Sun Sep 11 2016 Christopher Atherton <the8lack8ox(a)gmail.com> -
> 0.6.3-1
> +- Update to latest release
> +- Spec file cleanup
> +
> +* Wed Jan 13 2016 Christopher Atherton <the8lack8ox(a)gmail.com> -
> 0.6.2-2
> +- Change package name to fdkaac-cli
> +
> +* Mon Jan 11 2016 Christopher Atherton <the8lack8ox(a)gmail.com> -
> 0.6.2-1
> +- Initial spec
> diff --git a/sources b/sources
> index e69de29..b9fef35 100644
> --- a/sources
> +++ b/sources
> @@ -0,0 +1 @@
> +20cdcfcf1e3ea4060f021b6eefa9b75b fdkaac-0.6.3.tar.gz
--
Sérgio M. B.
8 years, 1 month
[Bug 4216] Review request: mp3diags - Find and fix Problems in MP3 Files
by RPM Fusion Bugzilla
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4216
Sérgio Basto <sergio(a)serjux.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |sergio(a)serjux.com
Blocks|3 |4
Assignee|rpmfusion-package-review@rp |sergio(a)serjux.com
|mfusion.org |
--- Comment #1 from Sérgio Basto <sergio(a)serjux.com> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: make gcc-c++
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
===== MUST items =====
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2) (with incorrect FSF address)", "Unknown or
generated". 11 files have unknown license. Detailed output of
licensecheck in /home/sergio/rpmbuild/4216-mp3diags/licensecheck.txt
[ ]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/icons/hicolor/40x40, /usr/share/icons/hicolor/40x40/apps
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in mp3diags
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[ ]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: mp3diags-1.2.03-1.fc26.x86_64.rpm
mp3diags-1.2.03-1.fc26.src.rpm
mp3diags.x86_64: W: spelling-error %description -l en_US renamer -> rename,
reamer, renames
mp3diags.x86_64: E: incorrect-fsf-address /usr/share/licenses/mp3diags/COPYING
mp3diags.x86_64: W: no-manual-page-for-binary MP3Diags
mp3diags.x86_64: W: no-manual-page-for-binary mp3diags
mp3diags.src: W: spelling-error %description -l en_US renamer -> rename,
reamer, renames
2 packages and 0 specfiles checked; 1 errors, 4 warnings.
Rpmlint (debuginfo)
-------------------
Checking: mp3diags-debuginfo-1.2.03-1.fc26.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
mp3diags.x86_64: W: spelling-error %description -l en_US renamer -> rename,
reamer, renames
mp3diags.x86_64: E: incorrect-fsf-address /usr/share/licenses/mp3diags/COPYING
mp3diags.x86_64: W: no-manual-page-for-binary mp3diags
mp3diags.x86_64: W: no-manual-page-for-binary MP3Diags
2 packages and 0 specfiles checked; 1 errors, 3 warnings.
Requires
--------
mp3diags (rpmlib, GLIBC filtered):
/bin/sh
hicolor-icon-theme
libQtCore.so.4()(64bit)
libQtGui.so.4()(64bit)
libQtNetwork.so.4()(64bit)
libQtXml.so.4()(64bit)
libboost_program_options.so.1.60.0()(64bit)
libboost_serialization.so.1.60.0()(64bit)
libc.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libm.so.6()(64bit)
libmp3lame.so.0()(64bit)
libpthread.so.0()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libstdc++.so.6(CXXABI_1.3.1)(64bit)
libstdc++.so.6(CXXABI_1.3.9)(64bit)
libz.so.1()(64bit)
mp3gain
rtld(GNU_HASH)
Provides
--------
mp3diags:
application()
application(mp3diags.desktop)
mp3diags
mp3diags(x86-64)
Source checksums
----------------
http://prdownloads.sourceforge.net/mp3diags/MP3Diags-1.2.03.tar.gz :
CHECKSUM(SHA256) this package :
8dce26781123150eb920acd1a1217601c55c8366f72b4cccd62bba53c3a73f53
CHECKSUM(SHA256) upstream package :
8dce26781123150eb920acd1a1217601c55c8366f72b4cccd62bba53c3a73f53
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review --other-bz https://bugzilla.rpmfusion.org
-b 4216 -m fedora-rawhide-x86_64-rpmfusion_nonfree
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
To finish all mp3 tools ... , issues just "These BR are not needed: make
gcc-c++" I also agree that may stay.
rpmlint incorrect-fsf-address https://sourceforge.net/p/mp3diags/tickets/3101/
(correct), the other 3 warnings can't be fixed.
Package approved !
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
8 years, 1 month
[Bug 4224] Review Request: siril - Astronomical image (pre-)processing program
by RPM Fusion Bugzilla
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4224
--- Comment #17 from Nicolas Chauvet <kwizart(a)gmail.com> ---
(In reply to Cyril Richard from comment #16)
...
> Does the idea is ok for you ?
This is okay as long as you have a maintainer for each package (it can be the
same person or not).
On a side note, I would advertise what is done in firefox in fedora.
Firefox is currently built with the ffmpeg headers (bundled in source tarball),
then dlopen the appropriate libavcodec version at runtime to get enable support
for what they call potentially nonfree codecs.
Having such dlopenable support in siril would avoid having a duplicated
packaging.
I don't know if that can easily be done in siril, but at least that will
certainly workaround the legal issue for not having ffmpeg in fedora and avoid
to have two different package for siril.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
8 years, 1 month
Is rsync broken on download1.rpmfusion.org?
by Jonathan Dieter
I run a local mirror for rpmfusion, and over the last couple of days,
this is what I receive when I try to rsync from it:
$ rsync download1.rpmfusion.org::rpmfusion/
@ERROR: chroot failed
rsync error: error starting client-server protocol (code 5) at
main.c(1516) [Receiver=3.0.9]
Is there a different URL I should be using?
Jonathan
8 years, 1 month