[Bug 3965] Review request: miam-player - Miam-Player is a cross-platform open source music player
by RPM Fusion Bugzilla
http://bugzilla.rpmfusion.org/show_bug.cgi?id=3965
leigh scott <leigh123linux(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |leigh123linux(a)gmail.com
--- Comment #15 from leigh scott <leigh123linux(a)gmail.com> ---
A couple of things.
you have this in the spec file.
%check
appstream-util validate-relax --nonet
%{buildroot}%{_datadir}/appdata/%{name}.appdata.xml
But have missed the build requires needed for it, add
BuildRequires: libappstream-glib
second is the wrong use of LDFLAGS
%build
%{_qt5_qmake} \
QMAKE_CFLAGS="%{optflags}" \
QMAKE_CXXFLAGS="%{optflags}" \
QMAKE_LFLAGS="%{optflags} -Wl,--as-needed" \
LIB_SUFFIX="$(echo %_lib | cut -b4-)" \
CONFIG+="no_rpath recheck config_libass_link debug"
%make_build
You use optflags when it should be ldflags, change to
%build
%{_qt5_qmake} \
QMAKE_CFLAGS="${RPM_OPT_FLAGS}" \
QMAKE_CXXFLAGS="${RPM_OPT_FLAGS}" \
QMAKE_LFLAGS="${RPM_LD_FLAGS} -Wl,--as-needed" \
LIB_SUFFIX="$(echo %_lib | cut -b4-)" \
CONFIG+="no_rpath recheck config_libass_link debug"
%make_build
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
8 years, 3 months
[Bug 4222] cAudio-freeworld - MP3 support for cAudio
by RPM Fusion Bugzilla
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4222
--- Comment #1 from Antonio Trande <anto.trande(a)gmail.com> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- These files are involved in the build and released under a LGPLv2+
license:
cAudio-2.3.1/Plugins/mp3Decoder/mpaudec/bits.c
cAudio-2.3.1/Plugins/mp3Decoder/mpaudec/mpaudec.c
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "LGPL (v2 or later) (with incorrect FSF address)", "Unknown or
generated", "zlib/libpng". 188 files have unknown license. Detailed
output of licensecheck in /home/sagitter/review-cAudio-
freeworld/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cAudio-
freeworld-debuginfo
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: cAudio-freeworld-2.3.1-1.fc26.x86_64.rpm
cAudio-freeworld-devel-2.3.1-1.fc26.x86_64.rpm
cAudio-freeworld-debuginfo-2.3.1-1.fc26.x86_64.rpm
cAudio-freeworld-2.3.1-1.fc26.src.rpm
cAudio-freeworld.x86_64: W: spelling-error %description -l en_US ffmpeg -> MPEG
cAudio-freeworld-devel.x86_64: W: only-non-binary-in-usr-lib
cAudio-freeworld-devel.x86_64: W: no-documentation
cAudio-freeworld.src: W: spelling-error %description -l en_US ffmpeg -> MPEG
4 packages and 0 specfiles checked; 0 errors, 4 warnings.
Rpmlint (debuginfo)
-------------------
Checking: cAudio-freeworld-debuginfo-2.3.1-1.fc26.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages)
----------------------------
cAudio-freeworld-devel.x86_64: W: only-non-binary-in-usr-lib
cAudio-freeworld-devel.x86_64: W: no-documentation
cAudio-freeworld.x86_64: W: spelling-error %description -l en_US ffmpeg -> MPEG
3 packages and 0 specfiles checked; 0 errors, 3 warnings.
Requires
--------
cAudio-freeworld-devel (rpmlib, GLIBC filtered):
cAudio-freeworld(x86-64)
libcAp_mp3Decoder.so.2()(64bit)
cAudio-freeworld-debuginfo (rpmlib, GLIBC filtered):
cAudio-freeworld (rpmlib, GLIBC filtered):
/sbin/ldconfig
cAudio(x86-64)
libc.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libm.so.6()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libstdc++.so.6(CXXABI_1.3.9)(64bit)
rtld(GNU_HASH)
Provides
--------
cAudio-freeworld-devel:
cAudio-freeworld-devel
cAudio-freeworld-devel(x86-64)
cAudio-freeworld-debuginfo:
cAudio-freeworld-debuginfo
cAudio-freeworld-debuginfo(x86-64)
cAudio-freeworld:
cAudio-freeworld
cAudio-freeworld(x86-64)
libcAp_mp3Decoder.so.2()(64bit)
Source checksums
----------------
https://github.com/R4stl1n/cAudio/archive/2.3.1/cAudio-2.3.1.tar.gz :
CHECKSUM(SHA256) this package :
1c9a63c85fcbbc76ddbc012f1555f9097e8fd7e3bb79f7b30284d1f5c3b2b3b5
CHECKSUM(SHA256) upstream package :
1c9a63c85fcbbc76ddbc012f1555f9097e8fd7e3bb79f7b30284d1f5c3b2b3b5
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64-rpmfusion_free -u
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4222
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
8 years, 3 months
[Bug 4258] New: Review request: libav - Audio and video processing libraries
by RPM Fusion Bugzilla
http://bugzilla.rpmfusion.org/show_bug.cgi?id=4258
Bug ID: 4258
Summary: Review request: libav - Audio and video processing
libraries
Product: Package Reviews
Version: Current
Hardware: All
OS: GNU/Linux
Status: NEW
Severity: enhancement
Priority: P1
Component: Review Request
Assignee: rpmfusion-package-review(a)rpmfusion.org
Reporter: anto.trande(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
SPEC: https://drive.google.com/open?id=0Bz6cHSZ6ZzsYQ3RHNE8xMmVJYlU
SRPM: https://drive.google.com/open?id=0Bz6cHSZ6ZzsYUDNnbjUwcTZpVEk
%description
Libav provides cross-platform tools and libraries to convert,
manipulate and stream a wide range of multimedia formats and protocols.
This package is not eligible on Fedora because it needs unavailable packages.
## rpmlint output
$ rpmlint libav-11.7-1.fc24.x86_64.rpm libav-debuginfo-11.7-1.fc24.x86_64.rpm
libav-devel-11.7-1.fc24.x86_64.rpm libav-tools-11.7-1.fc24.x86_64.rpm
../../SRPMS/libav-11.7-1.fc24.src.rpm
libav-devel.x86_64: W: only-non-binary-in-usr-lib
libav-devel.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 2 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
8 years, 3 months