[Bug 4639] New: dfhack - Memory hacking library for Dwarf Fortress
and a set of tools that use it
by RPM Fusion Bugzilla
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4639
Bug ID: 4639
Summary: dfhack - Memory hacking library for Dwarf Fortress and
a set of tools that use it
Product: Package Reviews
Version: Current
Hardware: x86_64
OS: GNU/Linux
Status: NEW
Severity: enhancement
Priority: P1
Component: Review Request
Assignee: rpmfusion-package-review(a)rpmfusion.org
Reporter: rosser.bjr(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
namespace: nonfree
Now that Dwarf Fortress is in the distribution, I guess I should submit this
review request too.
Spec URL:
https://www.acm.jhu.edu/~bjr/fedora/dwarffortress/rpmfusion/dfhack.spec
SRPM URL:
https://www.acm.jhu.edu/~bjr/fedora/dwarffortress/rpmfusion/dfhack-0.43.0...
Description:
DFHack is a Dwarf Fortress memory access library, distributed with a wide
variety of useful scripts and plugins.
For users, it provides a significant suite of bugfixes and interface
enhancements by default, and more can be enabled. There are also many tools
(such as workflow or autodump) which can make life easier. You can even add
third-party scripts and plugins to do almost anything!
For modders, DFHack makes many things possible. Custom reactions, new
interactions, magic creature abilities, and more can be set through Scripts
for Modders and custom raws. Non-standard DFHack scripts and inits can be
stored in the raw directory, making raws or saves fully self-contained for
distribution - or for coexistence in a single DF install, even with
incompatible components.
For developers, DFHack unites the various ways tools access DF memory and
allows easier development of new tools. As an open-source project under
various copyleft licences, contributions are welcome.
FAS Username: tc01
Namespace: nonfree
Why not in Fedora: dfhack is fully open source. However it depends directly on
Dwarf Fortress, a nonfree game (nonfree/dwarffortress); dfhack communicates
directly with the running dwarffortess process. Thus it must be in nonfree.
Notes:
This package is a bit messy, which is one reason I've been hesitant to open a
review request for it. There are a number of points to note, most of which are
documented in the spec itself as well (it is quite well commented).
1. Upstream uses a lot of git submodules, but also the build fails if .git
metadata isn't present. However, when I inquired upstream, they were not
interested in releasing a "source tarball" from which DH could be built without
doing additional git checkouts. Therefore I wrote a script (see link below) to
*actually* generate the dfhack tarball for which I've been managing releases.
That is why there is no source url.
https://www.acm.jhu.edu/~bjr/fedora/dwarffortress/rpmfusion/build-dfhack-...
2. There are a number of bundled bits with no support for unbundling. Worse,
many of the bundled bits have been forked by dfhack, meaning that it's
basically never going to be possible to unbundle (the most egregious example is
likely a dfhack fork of protobuf).
3. dfhack has a plugin (and script) architecture. Most plugins are included in
dfhack itself, but some are distributed and maintained separately, somewhat
like the Linux kernel. (Note that one of the in-tree plugins, stonesense, is
distributed here as a subpackage, since it contains a fair amount of data
specific to itself). I have been meaning to figure out a better way to do
out-of-tree dfhack plugin builds, but for now I just have this package fill in
and install a pkgconfig file.
4. ...unfortunately, dfhack plugins need to link statically against a helper
library, "dfhack-version.a", and so a static devel package is needed too.
5. One of dfhack's plugins is an interpreter for ruby scripts, which works by
directly trying to dlopen "libruby.so" (the intention was to ship a bundled
libruby that would be downloaded during the build, but I upstreamed a patch to
disable the download). Currently, therefore, I've made dfhack Require
libruby-devel as a runtime dependency. While I guess I could patch this out, it
would then mean that dfhack needs to be rebuilt whenever there's a ruby soname
bump.
I think those are the major pain points with the current state of the package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
6 years, 8 months
[Bug 4059] New: Review request: dwarftherapist - Management tool designed to run side-by-side with Dwarf Fortress
by RPM Fusion Bugzilla
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4059
Bug #: 4059
Summary: Review request: dwarftherapist - Management tool
designed to run side-by-side with Dwarf Fortress
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: rosser.bjr(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
Spec URL:
https://www.acm.jhu.edu/~bjr/fedora/dwarffortress/rpmfusion/dwarftherapis...
SRPM URL:
https://www.acm.jhu.edu/~bjr/fedora/dwarffortress/23/SRPMs/dwarftherapist...
Description:
Management tool designed to run side-by-side with Dwarf Fortress.
Offers several views and interface improvements to Dwarf Fortress.
Some features include:
Persistent custom professions - import and manage any number of custom
professions across all your forts.
Assign multiple dwarves to a custom profession at once to unify active labors
Manage labors and professions much more easily than in-game using a flexible
UI, allowing quick review of all dwarves at-a-glance
Display all pending changes before they're written to the game
Sort labor columns by associated skill level
Persistent and customizable display; change colors, reposition/hide
information screens
Group your dwarves by several criteria
This is a heavily modified version of the original Dwarf Therapist that
is still maintained for new versions of Dwarf Fortress.
rpmlint output:
dwarftherapist.x86_64: W: spelling-error %description -l en_US dwarves ->
wharves
dwarftherapist.x86_64: W: spelling-error %description -l en_US customizable ->
customization
dwarftherapist.x86_64: W: spelling-error %description -l en_US reposition ->
preposition, deposition, re position
dwarftherapist.x86_64: W: no-manual-page-for-binary dwarftherapist
dwarftherapist.x86_64: W: no-manual-page-for-binary DwarfTherapist
dwarftherapist.src: W: spelling-error %description -l en_US dwarves -> wharves
dwarftherapist.src: W: spelling-error %description -l en_US customizable ->
customization
dwarftherapist.src: W: spelling-error %description -l en_US reposition ->
preposition, deposition, re position
dwarftherapist.src:62: W: rpm-buildroot-usage %build %qmake_qt5
PREFIX=%{buildroot}%{_prefix}
The only questionable thing here is the rpm-buildroot-usage warning, and (for
the moment) I'm ignoring that because there doesn't seem to be another way to
change where the buildsystem installs (the DESTDIR option seems to be entirely
ignored by "make install").
Why not in Fedora:
dwarftherapist requires an installation of Dwarf Fortress on the system to be
useful. I've added a Requires: dwarffortress(x86-32), meaning that this package
would need to be in -nonfree. (The architecture dependency is needed because,
at the moment, DF is only built for 32-bit systems, although that may be
changing in the near future).
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6 years, 8 months
[Bug 2222] New: Review request: libactp - Adaptive Clearing Tool Path Library
by RPM Fusion Bugzilla
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2222
Bug #: 2222
Summary: Review request: libactp - Adaptive Clearing Tool Path
Library
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: SpikeFedora(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
Blocks: 2
Spec URL:
http://spike.fedorapeople.org/libactp/libactp.spec
SRPM URL:
http://spike.fedorapeople.org/libactp/libactp-0.0.2-0.1.20111219giteb97a6...
Description:
The libactp (Adaptive Clearing Tool Path Library) is an implementation of the
GPL'ed algorithm demonstrated in FreeSteel as a set of C library functions
Why this package is not eligible to be included in Fedora:
"Some software is not functional or useful without the presence of external
code dependencies in the runtime operating system environment. When those
external code dependencies are non-free, legally unacceptable, or binary-only
[...], then the dependent software is not acceptable for inclusion in
Fedora"[1]
Since atm only HeeksCNC uses this lib and HeeksCNC depends on OCE
(HeeksCNC->HeeksCAD-devel->OCE-devel), which is considered non-free, I assume
the term "not useful" applies here.
[1] http://fedoraproject.org/wiki/Packaging:Guidelines
rpmlint output:
SPECS/libactp.spec: W: invalid-url Source0: libactp-svnHEAD.tar.bz2
libactp.src: W: invalid-url Source0: libactp-svnHEAD.tar.bz2
1 packages and 1 specfiles checked; 0 errors, 2 warnings.
Upstream doesn't provide a release package tarball.
Careful: I usually don't do any python packaging. Here be dragons!
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6 years, 9 months
[Bug 2363] New: jitsi - Open Source Video Calls and Chat
by RPM Fusion Bugzilla
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2363
Bug #: 2363
Summary: jitsi - Open Source Video Calls and Chat
Classification: Unclassified
Product: Package Reviews
Version: Current
Platform: All
OS/Version: GNU/Linux
Status: NEW
Severity: normal
Priority: P5
Component: Review Request
AssignedTo: rpmfusion-package-review(a)rpmfusion.org
ReportedBy: fedora(a)marionline.it
CC: rpmfusion-package-review(a)rpmfusion.org
SPEC: http://marionline.fedorapeople.org/packages/SPECS/jitsi.spec
SRPMS:
http://marionline.fedorapeople.org/packages/SRPMS/jitsi-1.1-1.nightly.bui...
Description:
Jitsi (previously SIP Communicator) is an audio/video and chat communicator
that supports protocols such as SIP, XMPP/Jabber, AIM/ICQ, Windows Live, Yahoo!
and many other useful features.
Why here:
This package cannot be shipped into official fedora repository because upstream
use ffmpeg library.
Rpmlint:
jitsi.src: W: invalid-url Source4: portaudio-hotplug-r1838.tar.gz
jitsi.src: W: invalid-url Source3: jdic-r1736.tar.gz
jitsi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/portaudio-hotplug-r1838/libportaudio.a
jitsi.x86_64: W: devel-file-in-non-devel-package
/usr/include/portaudio-hotplug-r1838/portaudio.h
jitsi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/portaudio-hotplug-r1838/pkgconfig/portaudio-2.0.pc
jitsi.x86_64: W: devel-file-in-non-devel-package
/usr/include/portaudio-hotplug-r1838/pa_linux_alsa.h
jitsi.x86_64: W: no-manual-page-for-binary jitsi
4 packages and 0 specfiles checked; 0 errors, 7 warnings.
I think jdic and portaudio branch hotplug for now is useful just for jitsi so I
include them directly in this package. There are not official releases of this
two packages, I checkout the code from svn repository.
This is not my first RPM package. I just open another review request here for
another SIP software, homer:
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2237
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
6 years, 9 months
nVidia howto question or solution
by Sérgio Basto
Hello,
After on IRC another fellow, had problems on install nVidia drives on
first installation and reboot, I also had a similar problem that make
me think. And I think I found the issue, instead try blacklist nouveau
on boot we should run:
dracut -f /boot/initramfs-$(uname -r).img $(uname -r)
xorg-x11-drv-nvidia package have blacklist-nouveau.conf [1] but just
install a new kernel nouveau enter in blacklist isn't it ? , so after
installing nVidia drives (for the first time) we should also run dracut
to generate initramfs without nouveau module isn't it ? anyway like
blacklist-nouveau.conf text says.
Conclusion we should/need update https://rpmfusion.org/Howto/nVidia
Best regards,
[1]
https://pkgs.rpmfusion.org/cgit/nonfree/xorg-x11-drv-nvidia.git/tree/bl
acklist-nouveau.conf
--
Sérgio M. B.
6 years, 9 months
[Bug 4441] New: Review request: discord - All-in-one voice and text
chat for gamers
by RPM Fusion Bugzilla
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4441
Bug ID: 4441
Summary: Review request: discord - All-in-one voice and text
chat for gamers
Product: Package Reviews
Version: Current
Hardware: x86_64
OS: GNU/Linux
Status: NEW
Severity: enhancement
Priority: P1
Component: Review Request
Assignee: rpmfusion-package-review(a)rpmfusion.org
Reporter: seancallaway(a)gmail.com
CC: rpmfusion-package-review(a)rpmfusion.org
SPEC URL: https://seansblag.com/software/discord/discord.spec
SRPM URL: https://seansblag.com/software/discord/discord-0.0.1-1.fc25.src.rpm
DESCRIPTION:
Discord is a free-of-cost proprietary VoIP application designed for gaming
communities.
WHY NOT IN FEDORA?
Discord is a proprietary application *and* relies on nonfree libraries (such as
ffmpeg), which the developer has bundled into the application.
RPMLINT OUTPUT (SRPM):
discord.src: W: spelling-error Summary(en_US) gamers -> gamer, games, tamers
discord.src: W: invalid-license Proprietary
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
RPMLINT OUTPUT (RPM):
discord.x86_64: W: spelling-error Summary(en_US) gamers -> gamer, games, tamers
discord.x86_64: W: invalid-license Proprietary
discord.x86_64: W: binaryinfo-readelf-failed
/usr/lib64/discord/resources/bootstrap/discord_voice.zip readelf: Error: Not an
ELF file - it has the wrong magic bytes at the start
discord.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/discord/Discord
['$ORIGIN', '$ORIGIN/lib/']
discord.x86_64: W: binaryinfo-readelf-failed
/usr/lib64/discord/resources/bootstrap/discord_toaster.zip readelf: Error: Not
an ELF file - it has the wrong magic bytes at the start
discord.x86_64: W: binaryinfo-readelf-failed
/usr/lib64/discord/resources/bootstrap/discord_utils.zip readelf: Error: Not an
ELF file - it has the wrong magic bytes at the start
discord.x86_64: W: no-documentation
discord.x86_64: W: no-manual-page-for-binary Discord
discord.x86_64: W: desktopfile-without-binary
/usr/share/applications/discord.desktop /usr/bin/Discord
JUSTIFICATIONS FOR ERRORS AND WARNINGS:
* spelling-error: gamers is the proper plural of gamer.
* invalid-license: rpmlint doesn't seem to support nonfree licenses
* binaryinfo-readelf-failed: It's right. There's aren't ELF binaries, as
they're ZIP files. Not sure how to remove this error, but am more than willing
to do something to fix this.
* binary-or-shlib-defines-rpath: The developer has built their proprietary
binary to use bundled libraries. It's not ideal, but it's what they've done. I
can try to convince them to just include those libs as a requirement in their
Linux release.
* no-documentation and no-manual-page-for-binary: No documentation is provided
for Discord outside of their website.
* desktopfile-without-binary: /usr/bin/Discord is a symlink to
/usr/lib64/discord/Discord due to the bundled libraries.
NOTES:
This is my first RPMFusion package (and first desktop application package), but
not my first package. I package re2c and openvpn-auth-ldap for EPEL.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
6 years, 9 months
