Re: [ffmpeg] Fixes for cuda enabled repo
by Dominik 'Rathann' Mierzejewski
Hi, Nicolas.
On Friday, 09 November 2018 at 18:37, Nicolas Chauvet wrote:
> commit 8ce6dfb678c50dbc4094f9d99c58264091b00235
> Author: Nicolas Chauvet <kwizart(a)gmail.com>
> Date: Fri Nov 9 18:36:20 2018 +0100
>
> Fixes for cuda enabled repo
>
> ffmpeg.spec | 23 +++++++++++++----------
> 1 file changed, 13 insertions(+), 10 deletions(-)
> ---
> diff --git a/ffmpeg.spec b/ffmpeg.spec
> index 48452eb..0f55274 100644
> --- a/ffmpeg.spec
> +++ b/ffmpeg.spec
[...]
> %ifarch %{cuda_arches}
> -%global _with_cuda 1
> %global _with_cuvid 1
> %global _with_libnpp 1
> %endif
Why?
> @@ -42,6 +42,7 @@
> %global _without_cdio 1
> %global _without_frei0r 1
> %global _without_gpl 1
> +%global _without_vidstab 1
> %global _without_x264 1
> %global _without_x265 1
> %global _without_xvid 1
Why?
[...]
> @@ -321,6 +323,7 @@ mkdir -p _doc/examples
> cp -pr doc/examples/{*.c,Makefile,README} _doc/examples/
>
> %build
> +export PATH=${PATH}:%{_cuda_bindir}
> %{ff_configure}\
> --shlibdir=%{_libdir} \
> %if 0%{?_without_tools:1}
Why are you adding this unconditionally?
> @@ -381,7 +384,7 @@ install -pm755 tools/qt-faststart %{buildroot}%{_bindir}
> %endif
>
> %ldconfig_scriptlets libs
> -%ldconfig_scriptlets libavdevice%{?flavor}
> +%ldconfig_scriptlets -n libavdevice%{?flavor}
>
> %if 0%{!?_without_tools:1}
> %files
Please don't mix CUDA-related changes with general fixes in the same
commit.
Regards,
Dominik
--
Fedora https://getfedora.org | RPMFusion http://rpmfusion.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
-- from "Collected Sayings of Muad'Dib" by the Princess Irulan