RPM Fusion is branched for f28
by Nicolas Chauvet
Hi there,
Just to mention that RPM Fusion is branched for f28
It means that you need to fetch the f28 branch in git and master now
point to f29
(same as in fedora).
The f29 buildroot isn't yet working, but it should be fixed in the coming hours.
Please hold your build until Tuesday, as the packages aren't all
pushed out of the infra yet.
The plan is to have all f28 packages signed, then push both rawhide
and branched repositories.
Thx
--
-
Nicolas (kwizart)
6 years, 9 months
[Bug 1156] Review request: performous - Karaoke game
by RPM Fusion Bugzilla
https://bugzilla.rpmfusion.org/show_bug.cgi?id=1156
--- Comment #27 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
- There are fonts under ASL 2.0 and SIL licenses:
*No copyright* Apache (v2.0)
----------------------------
performous-1.1/docs/license/Apache-2.0-DroidSansMono.txt
SIL (v1.1)
----------
performous-1.1/data/fonts/GoblinOne.otf
performous-1.1/data/fonts/NewRocker-Regular.otf
performous-1.1/docs/license/SIL OFL Font License New Rocker.txt
Add them to the license field, with a comment explaining the licence
breakdown. Add the license texts for each font to %license too.
- These are files with incorrect FSF address:
performous-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/performous-1.1-2.fc29.x86_64/tools/gh_fsb/fsbext.c
performous-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/performous-1.1-2.fc29.x86_64/tools/gh_fsb/mywav.h
performous-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/performous-1.1-2.fc29.x86_64/tools/gh_fsb/show_dump.h
Patch them in %prep and notify upstream.
- [!]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Note: Arch-ed rpms have a total of 5191680 bytes in /usr/share
Split out the/usr files into a noarch -data subpackage.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "*No copyright* BSL", "GPL (v2 or later)", "*No copyright* GPL
(v3)", "Unknown or generated", "BSL (v1.0)", "SIL (v1.1)", "GPL (v2 or
later) (with incorrect FSF address)", "GPL (v2)", "*No copyright*
Apache (v2.0)". 415 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/performous/review-
performous/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[!]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Note: Arch-ed rpms have a total of 5191680 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: performous-1.1-2.fc29.x86_64.rpm
performous-debuginfo-1.1-2.fc29.x86_64.rpm
performous-debugsource-1.1-2.fc29.x86_64.rpm
performous-1.1-2.fc29.src.rpm
performous.x86_64: W: only-non-binary-in-usr-lib
performous.x86_64: W: no-manual-page-for-binary itg_pck
performous.x86_64: W: no-manual-page-for-binary ss_archive_extract
performous-debugsource.x86_64: W: no-documentation
performous-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/performous-1.1-2.fc29.x86_64/tools/gh_fsb/fsbext.c
performous-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/performous-1.1-2.fc29.x86_64/tools/gh_fsb/mywav.h
performous-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/performous-1.1-2.fc29.x86_64/tools/gh_fsb/show_dump.h
4 packages and 0 specfiles checked; 3 errors, 4 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
6 years, 9 months
