[Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
--- Comment #31 from Simone Caronni <negativo17(a)gmail.com> 2013-10-23 15:27:17 CEST
---
(In reply to comment #29)
Issues:
[!]: Useful -debuginfo package or justification otherwise.
Disabling debuginfo is fine here, but needs a justification comment.
Added comment.
[!]: Requires correct, justified where necessary.
[!]: Package must own all directories that it creates.
/usr/lib/udev and /usr/lib/udev/rules.d are owned by systemd,
/etc/profile.d by setup. These need to be Require:'d.
I've added them as BuildRequirements so I can avoid the "mkdir -p"
commands;
the folder is already available at build time and I can just copy the files
into them.
Adding them as Requirement is not required as setup and systemd are already
pulled in by other packages.
wrong-file-end-of-line-encoding
/usr/share/doc/steam/steam_install_agreement.txt
Done, did as packaging guidelines suggested and removed dos2unix
(https://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-li...).
steam.src:35: W: macro-in-comment %{name}
steam.src:36: W: macro-in-comment %{_isa}
Fixed, escaped them (%%).
[!]: Package is licensed with an open-source compatible license and
meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
-->OK for rpmfusion, though. Please add some kind of reference to
the license in a comment above it.
Done, added a comment.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.