Re: rpms/avidemux/devel avidemux.spec,1.40,1.41
On Thursday, 21 April 2011 at 03:56, Richard Shaw wrote:
[...]
Modified Files:
avidemux.spec
Log Message:
* Wed Apr 20 2011 Richard Shaw <hobbes1069(a)gmail.com> - 2.5.4-4
- Disabled non-working patch for experimental aac encoding with ffmpeg.
- Removed dependency on bundled javascript library. Now uses system library.
- Added optional opencore-amr decoding support.
I noticed that you enabled support for system js library, but I don't see
any BuildRequires added for it (maybe Requires too?).
Also please ensure that your patches don't contain cosmetic changes
(whitespace, empty lines, etc.). It makes them smaller and easier
to review.
Regards,
Dominik
--
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org | MPlayer http://mplayerhq.hu
"Faith manages."
-- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"